You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Yufei Gu (JIRA)" <ji...@apache.org> on 2017/09/28 00:56:00 UTC
[jira] [Commented] (HADOOP-12672) RPC timeout should not override
IPC ping interval
[ https://issues.apache.org/jira/browse/HADOOP-12672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183509#comment-16183509 ]
Yufei Gu commented on HADOOP-12672:
-----------------------------------
By looking at the following code, rpcTimeout is disabled if you set rpcTimeout to zero(the default value) since rpcTimeout need to be greater than 0 to make it work. Is that a behavior by design? I think it would be better to make -1 is value to disable rpcTimeout and at least document which value can disable rpcTimeout.
{code}
private void handleTimeout(SocketTimeoutException e, int waiting)
throws IOException {
if (shouldCloseConnection.get() || !running.get() ||
(0 < rpcTimeout && rpcTimeout <= waiting)) {
throw e;
} else {
sendPing();
}
}
{code}
> RPC timeout should not override IPC ping interval
> -------------------------------------------------
>
> Key: HADOOP-12672
> URL: https://issues.apache.org/jira/browse/HADOOP-12672
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 2.8.0, 2.7.3, 2.6.4
> Reporter: Masatake Iwasaki
> Assignee: Masatake Iwasaki
> Fix For: 2.8.0, 3.0.0-alpha1
>
> Attachments: HADOOP-12672.001.patch, HADOOP-12672.002.patch, HADOOP-12672.003.patch, HADOOP-12672.004.patch, HADOOP-12672.005.patch, HADOOP-12672.006.patch
>
>
> Currently if the value of ipc.client.rpc-timeout.ms is greater than 0, the timeout overrides the ipc.ping.interval and client will throw exception instead of sending ping when the interval is passed. RPC timeout should work without effectively disabling IPC ping.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org