You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by tivv <gi...@git.apache.org> on 2012/08/17 14:23:00 UTC
pig pull request: Fix newline right after quote
GitHub user tivv opened a pull request:
https://github.com/apache/pig/pull/6
Fix newline right after quote
PIG-2556 PiggyBank CSVExcelStorage treats "\nData" field incorrectly in multiline mode
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tivv/pig CSVExcelNewLineBug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/pig/pull/6.patch
----
commit c2c077c30d3934577425f351eb097778047ad7b2
Author: Vitalii Tymchyshyn <ti...@gmail.com>
Date: 2012-08-17T05:17:46-07:00
Fix newline right after quote
----
Re: pig pull request: Fix newline right after quote
Posted by Dmitriy Ryaboy <dv...@gmail.com>.
Committed today, thanks both.
D
On Sat, Aug 18, 2012 at 9:26 AM, Віталій Тимчишин <ti...@gmail.com> wrote:
> I understand. I did add patch to PIG-2556 at the same time. Patch is
> generated with git, if it's not OK I can try to redo it.
> See
> https://issues.apache.org/jira/secure/attachment/12541355/CSVExcelProblems-2.patch
>
> 2012/8/17 Jonathan Coveney <jc...@gmail.com>
>
>> Howdy Vitalii,
>>
>> We actually can't merge in pull requests via github. It's purely a mirror.
>>
>> The version control of truth is subversion, and you need to submit a patch
>> to a ticket via JIRA.
>>
>> Thanks for your submission, but alas, github isn't the way to do it yet.
>> This has it's good and bade sides, but hope it will not discourage you from
>> contributing
>> Jon
>>
>> 2012/8/17 tivv <gi...@git.apache.org>
>>
>>> GitHub user tivv opened a pull request:
>>>
>>> https://github.com/apache/pig/pull/6
>>>
>>> Fix newline right after quote
>>>
>>> PIG-2556 PiggyBank CSVExcelStorage treats "\nData" field incorrectly
>>> in multiline mode
>>>
>>> You can merge this pull request into a Git repository by running:
>>>
>>> $ git pull https://github.com/tivv/pig CSVExcelNewLineBug
>>>
>>> Alternatively you can review and apply these changes as the patch at:
>>>
>>> https://github.com/apache/pig/pull/6.patch
>>>
>>> ----
>>> commit c2c077c30d3934577425f351eb097778047ad7b2
>>> Author: Vitalii Tymchyshyn <ti...@gmail.com>
>>> Date: 2012-08-17T05:17:46-07:00
>>>
>>> Fix newline right after quote
>>>
>>> ----
>>>
>>>
>>
>
>
> --
> Best regards,
> Vitalii Tymchyshyn
Re: pig pull request: Fix newline right after quote
Posted by Віталій Тимчишин <ti...@gmail.com>.
I understand. I did add patch to PIG-2556 at the same time. Patch is
generated with git, if it's not OK I can try to redo it.
See
https://issues.apache.org/jira/secure/attachment/12541355/CSVExcelProblems-2.patch
2012/8/17 Jonathan Coveney <jc...@gmail.com>
> Howdy Vitalii,
>
> We actually can't merge in pull requests via github. It's purely a mirror.
>
> The version control of truth is subversion, and you need to submit a patch
> to a ticket via JIRA.
>
> Thanks for your submission, but alas, github isn't the way to do it yet.
> This has it's good and bade sides, but hope it will not discourage you from
> contributing
> Jon
>
> 2012/8/17 tivv <gi...@git.apache.org>
>
>> GitHub user tivv opened a pull request:
>>
>> https://github.com/apache/pig/pull/6
>>
>> Fix newline right after quote
>>
>> PIG-2556 PiggyBank CSVExcelStorage treats "\nData" field incorrectly
>> in multiline mode
>>
>> You can merge this pull request into a Git repository by running:
>>
>> $ git pull https://github.com/tivv/pig CSVExcelNewLineBug
>>
>> Alternatively you can review and apply these changes as the patch at:
>>
>> https://github.com/apache/pig/pull/6.patch
>>
>> ----
>> commit c2c077c30d3934577425f351eb097778047ad7b2
>> Author: Vitalii Tymchyshyn <ti...@gmail.com>
>> Date: 2012-08-17T05:17:46-07:00
>>
>> Fix newline right after quote
>>
>> ----
>>
>>
>
--
Best regards,
Vitalii Tymchyshyn
Re: pig pull request: Fix newline right after quote
Posted by Jonathan Coveney <jc...@gmail.com>.
Howdy Vitalii,
We actually can't merge in pull requests via github. It's purely a mirror.
The version control of truth is subversion, and you need to submit a patch
to a ticket via JIRA.
Thanks for your submission, but alas, github isn't the way to do it yet.
This has it's good and bade sides, but hope it will not discourage you from
contributing
Jon
2012/8/17 tivv <gi...@git.apache.org>
> GitHub user tivv opened a pull request:
>
> https://github.com/apache/pig/pull/6
>
> Fix newline right after quote
>
> PIG-2556 PiggyBank CSVExcelStorage treats "\nData" field incorrectly
> in multiline mode
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/tivv/pig CSVExcelNewLineBug
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/pig/pull/6.patch
>
> ----
> commit c2c077c30d3934577425f351eb097778047ad7b2
> Author: Vitalii Tymchyshyn <ti...@gmail.com>
> Date: 2012-08-17T05:17:46-07:00
>
> Fix newline right after quote
>
> ----
>
>