[GitHub] [arrow] jorisvandenbossche commented on pull request #12452: ARROW-14292: [C++][Python] Join foundation for Tables

[GitBox <gi...@apache.org>]

jorisvandenbossche commented on pull request #12452:
URL: https://github.com/apache/arrow/pull/12452#issuecomment-1064231559


   I would personally prefer to see this comment addressed as well (or at least get some thoughts on it):
   
   > You also need to specify the key column for both left and right table separate. While this is certainly the most generic (since it can handle different names in left and right table), I think it could also be nice to give the user the possibility to just give one name (or list of names) in case it is the same in left/right table (for better ergonomics when using this method)
   
   For the join keys columns in the output: you now selected one of the columns for most joins, but not for outer join, I think? I am not fully sure if we should do something different here for outer join (for example, both pandas and dplyr will only have a single key column in the output also in the case of an outer join)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org