[GitHub] [solr] joshgog commented on a diff in pull request #1374: SolrClientTestRule for JettySolrRunner

["joshgog (via GitHub)" <gi...@apache.org>]

joshgog commented on code in PR #1374:
URL: https://github.com/apache/solr/pull/1374#discussion_r1113434652


##########
solr/core/src/test/org/apache/solr/TestSolrCoreProperties.java:
##########
@@ -79,11 +79,10 @@ public static void beforeTest() throws Exception {
     if (System.getProperty("solr.data.dir") == null) {
       nodeProperties.setProperty("solr.data.dir", createTempDir().toFile().getCanonicalPath());
     }
-    jetty =
-        new JettySolrRunner(homeDir.getAbsolutePath(), nodeProperties, buildJettyConfig("/solr"));
 
-    jetty.start();
-    port = jetty.getLocalPort();
+    new JettySolrRunner(homeDir.getAbsolutePath(), nodeProperties, buildJettyConfig("/solr"));

Review Comment:
   Right! He was supposed to do this `solrClientTestRule.startSolr(Path.of(homeDir.getAbsolutePath()), nodeProperties, buildJettyConfig("/solr"));`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org