You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "amorynan (via GitHub)" <gi...@apache.org> on 2024/10/12 10:06:40 UTC
[PR] [improve](ip-function)improve is_ip_address_in_range for inverted index speed [doris]
amorynan opened a new pull request, #41768:
URL: https://github.com/apache/doris/pull/41768
## Proposed changes
speed up is_ip_address_in_range with inverted index
Issue Number: close #xxx
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](ip-function)improve is_ip_address_in_range for inverted index speed [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #41768:
URL: https://github.com/apache/doris/pull/41768#discussion_r1799095738
##########
be/src/vec/functions/function_ip.h:
##########
@@ -606,110 +606,177 @@ class FunctionIsIPAddressInRange : public IFunction {
return std::make_shared<DataTypeUInt8>();
}
- Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
- size_t result, size_t input_rows_count) const override {
- const auto& addr_column_with_type_and_name = block.get_by_position(arguments[0]);
- const auto& cidr_column_with_type_and_name = block.get_by_position(arguments[1]);
- WhichDataType addr_type(addr_column_with_type_and_name.type);
- WhichDataType cidr_type(cidr_column_with_type_and_name.type);
- const auto& [addr_column, addr_const] =
- unpack_if_const(addr_column_with_type_and_name.column);
- const auto& [cidr_column, cidr_const] =
- unpack_if_const(cidr_column_with_type_and_name.column);
- const auto* str_addr_column = assert_cast<const ColumnString*>(addr_column.get());
- const auto* str_cidr_column = assert_cast<const ColumnString*>(cidr_column.get());
-
- auto col_res = ColumnUInt8::create(input_rows_count, 0);
+ template <PrimitiveType PT, typename ColumnType>
+ void execute_impl_with_ip(size_t input_rows_count, bool addr_const, bool cidr_const,
+ const ColumnString* str_cidr_column, const ColumnPtr addr_column,
+ ColumnUInt8* col_res) const {
auto& col_res_data = col_res->get_data();
-
+ const auto& ip_data = assert_cast<const ColumnType*>(addr_column.get())->get_data();
for (size_t i = 0; i < input_rows_count; ++i) {
auto addr_idx = index_check_const(i, addr_const);
auto cidr_idx = index_check_const(i, cidr_const);
-
- const auto addr =
- IPAddressVariant(str_addr_column->get_data_at(addr_idx).to_string_view());
const auto cidr =
parse_ip_with_cidr(str_cidr_column->get_data_at(cidr_idx).to_string_view());
- col_res_data[i] = is_address_in_range(addr, cidr) ? 1 : 0;
+ if constexpr (PT == PrimitiveType::TYPE_IPV4) {
+ if (cidr._address.as_v4()) {
+ col_res_data[i] = match_ipv4_subnet(ip_data[addr_idx], cidr._address.as_v4(),
+ cidr._prefix)
+ ? 1
+ : 0;
+ } else {
+ col_res_data[i] = 0;
+ }
+ } else if constexpr (PT == PrimitiveType::TYPE_IPV6) {
+ if (cidr._address.as_v6()) {
+ col_res_data[i] = match_ipv6_subnet((uint8*)(&ip_data[addr_idx]),
+ cidr._address.as_v6(), cidr._prefix)
+ ? 1
+ : 0;
+ } else {
+ col_res_data[i] = 0;
+ }
+ }
}
-
- block.replace_by_position(result, std::move(col_res));
- return Status::OK();
}
-};
-
-// old version throw exception when meet null value
-class FunctionIsIPAddressInRangeOld : public IFunction {
-public:
- static constexpr auto name = "is_ip_address_in_range";
- static FunctionPtr create() { return std::make_shared<FunctionIsIPAddressInRange>(); }
-
- String get_name() const override { return name; }
- size_t get_number_of_arguments() const override { return 2; }
+ Status evaluate_inverted_index(
Review Comment:
warning: function 'evaluate_inverted_index' exceeds recommended size/complexity thresholds [readability-function-size]
```cpp
Status evaluate_inverted_index(
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/functions/function_ip.h:641:** 90 lines including whitespace and comments (threshold 80)
```cpp
Status evaluate_inverted_index(
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](ip-function)improve is_ip_address_in_range for inverted index speed [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41768:
URL: https://github.com/apache/doris/pull/41768#issuecomment-2409817375
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](ip-function)improve is_ip_address_in_range for inverted index speed [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41768:
URL: https://github.com/apache/doris/pull/41768#issuecomment-2408508350
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](ip-function)improve is_ip_address_in_range for inverted index speed [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #41768:
URL: https://github.com/apache/doris/pull/41768#issuecomment-2408507146
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](ip-function)improve is_ip_address_in_range for inverted index speed [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41768:
URL: https://github.com/apache/doris/pull/41768#issuecomment-2410870776
TeamCity be ut coverage result:
Function Coverage: 37.47% (9709/25912)
Line Coverage: 28.73% (80603/280539)
Region Coverage: 28.18% (41708/148020)
Branch Coverage: 24.76% (21212/85678)
Coverage Report: http://coverage.selectdb-in.cc/coverage/75140747133e72cd0aa25f393db4dac0ea9e556d_75140747133e72cd0aa25f393db4dac0ea9e556d/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](ip-function)improve is_ip_address_in_range for inverted index speed [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41768:
URL: https://github.com/apache/doris/pull/41768#issuecomment-2408507132
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](ip-function)improve is_ip_address_in_range for inverted index speed [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41768:
URL: https://github.com/apache/doris/pull/41768#issuecomment-2413108409
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](ip-function)improve is_ip_address_in_range for inverted index speed [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on code in PR #41768:
URL: https://github.com/apache/doris/pull/41768#discussion_r1799089935
##########
regression-test/suites/inverted_index_p0/test_ip_cidr_search_with_inverted_index.groovy:
##########
@@ -0,0 +1,94 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("test_ip_cidr_search_with_inverted_index"){
+ // prepare test table
+ sql "DROP TABLE IF EXISTS tc_ip_cidr_search_with_inverted_index"
+ // create 1 replica table
+ sql """
+ CREATE TABLE IF NOT EXISTS `tc_ip_cidr_search_with_inverted_index` (
+ `id` INT NULL,
+ `ipv4` IPV4 NULL,
+ `ipv6` IPV6 NULL,
+ `cidr` TEXT NULL,
+ INDEX v4_index (`ipv4`) USING INVERTED,
+ INDEX v6_index (`ipv6`) USING INVERTED
+ ) ENGINE=OLAP
+ DUPLICATE KEY(`id`)
+ COMMENT 'OLAP'
+ DISTRIBUTED BY HASH(`id`) BUCKETS 4
+ PROPERTIES (
+ "replication_allocation" = "tag.location.default: 1",
+ "is_being_synced" = "false",
+ "storage_format" = "V2",
+ "light_schema_change" = "true",
+ "disable_auto_compaction" = "false",
+ "enable_single_replica_compaction" = "false"
+ );
+ """
+ sql """ set enable_profile = true;"""
+
+ sql """ insert into tc_ip_cidr_search_with_inverted_index values(1, '59.50.185.152', '2a02:e980:83:5b09:ecb8:c669:b336:650e', '127.0.0.0/8'),(3, '119.36.22.147', '2001:4888:1f:e891:161:26::', '127.0.0.0/8'),(2, '42.117.228.166', '2001:16a0:2:200a::2', null); """
+ sql """ insert into tc_ip_cidr_search_with_inverted_index values(4, '.', '2001:1b70:a1:610::b102:2', null); """
+ sql """ insert into tc_ip_cidr_search_with_inverted_index values(5, '255.255.255.255', 'ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffffg', null) """
+
+ qt_sql """ select count() from tc_ip_cidr_search_with_inverted_index"""
+ // without inverted index query
+ sql """ set enable_common_expr_pushdown = false; """
+ sql """ set enable_inverted_index_query=false; """
+ // select ipv6 in ipv4 cidr
+ qt_sql_without_ii_0 """ select id, ipv4, ipv6, is_ip_address_in_range(ipv6, '255.255.255.255/12') from tc_ip_cidr_search_with_inverted_index where is_ip_address_in_range(ipv6, '255.255.255.255/12') order by id; """
+ // select ipv6 in ipv6 cidr
+ qt_sql_without_ii_1 """ select id, ipv4, ipv6, is_ip_address_in_range(ipv6, 'ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff/12') from tc_ip_cidr_search_with_inverted_index where is_ip_address_in_range(ipv6, 'ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff/12') order by id; """
+ qt_sql_without_ii_2 """ select id, ipv4, ipv6, is_ip_address_in_range(ipv6, '::ffff:192.168.0.4/128') from tc_ip_cidr_search_with_inverted_index where is_ip_address_in_range(ipv6, '::ffff:192.168.0.4/128') order by id; """
+ qt_sql_without_ii_3 """ select id, ipv4, ipv6, is_ip_address_in_range(ipv6, '2001:16a0:2:200a::2/64') from tc_ip_cidr_search_with_inverted_index where is_ip_address_in_range(ipv6, '2001:16a0:2:200a::2/64') order by id; """
+
+ // select ipv4 in ipv6 cidr
+ qt_sql_without_ii_4 """ select id, ipv4, ipv6, is_ip_address_in_range(ipv4, 'ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff/12') from tc_ip_cidr_search_with_inverted_index where is_ip_address_in_range(ipv4, 'ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff/12') order by id; """
+ // select ipv4 in ipv4 cidr
+ qt_sql_without_ii_5 """ select id, ipv4, ipv6, is_ip_address_in_range(ipv6, '255.255.255.255/12') from tc_ip_cidr_search_with_inverted_index where is_ip_address_in_range(ipv4, '255.255.255.255/12') order by id; """
+ qt_sql_without_ii_6 """ select id, ipv4, ipv6, is_ip_address_in_range(ipv4, '127.0.0.0/8') from tc_ip_cidr_search_with_inverted_index where is_ip_address_in_range(ipv4, '127.0.0.0/8') order by id; """
+ qt_sql_without_ii_7 """ select id, ipv4, ipv6, is_ip_address_in_range(ipv4, '192.168.100.0/24') from tc_ip_cidr_search_with_inverted_index where is_ip_address_in_range(ipv4, '192.168.100.0/24') order by id; """
+
+ // select in null cidr
+ qt_sql_without_ii_8 """ select id, ipv4, ipv6, is_ip_address_in_range(ipv4, null) from tc_ip_cidr_search_with_inverted_index where is_ip_address_in_range(ipv4, null) order by id; """
+ qt_sql_without_ii_9 """ select id, ipv4, ipv6, is_ip_address_in_range(ipv6, null) from tc_ip_cidr_search_with_inverted_index where is_ip_address_in_range(ipv6, null) order by id; """
+
+ // with inverted index query
+ // If we use common expr pass to inverted index , we should set enable_common_expr_pushdown = true
Review Comment:
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](ip-function)improve is_ip_address_in_range for inverted index speed [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 merged PR #41768:
URL: https://github.com/apache/doris/pull/41768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](ip-function)improve is_ip_address_in_range for inverted index speed [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41768:
URL: https://github.com/apache/doris/pull/41768#issuecomment-2408531879
TeamCity be ut coverage result:
Function Coverage: 37.43% (9679/25858)
Line Coverage: 28.67% (80253/279958)
Region Coverage: 28.11% (41527/147735)
Branch Coverage: 24.69% (21112/85504)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e4ee6a1f016145534da19b6b8b40ec38b32f8538_e4ee6a1f016145534da19b6b8b40ec38b32f8538/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](ip-function)improve is_ip_address_in_range for inverted index speed [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on code in PR #41768:
URL: https://github.com/apache/doris/pull/41768#discussion_r1797691237
##########
regression-test/suites/inverted_index_p0/test_ip_cidr_search_with_inverted_index.groovy:
##########
@@ -0,0 +1,94 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("test_ip_cidr_search_with_inverted_index"){
+ // prepare test table
+ sql "DROP TABLE IF EXISTS tc_ip_cidr_search_with_inverted_index"
+ // create 1 replica table
+ sql """
+ CREATE TABLE IF NOT EXISTS `tc_ip_cidr_search_with_inverted_index` (
+ `id` INT NULL,
+ `ipv4` IPV4 NULL,
+ `ipv6` IPV6 NULL,
+ `cidr` TEXT NULL,
+ INDEX v4_index (`ipv4`) USING INVERTED,
+ INDEX v6_index (`ipv6`) USING INVERTED
+ ) ENGINE=OLAP
+ DUPLICATE KEY(`id`)
+ COMMENT 'OLAP'
+ DISTRIBUTED BY HASH(`id`) BUCKETS 4
+ PROPERTIES (
+ "replication_allocation" = "tag.location.default: 1",
+ "is_being_synced" = "false",
+ "storage_format" = "V2",
+ "light_schema_change" = "true",
+ "disable_auto_compaction" = "false",
+ "enable_single_replica_compaction" = "false"
+ );
+ """
+ sql """ set enable_profile = true;"""
+
+ sql """ insert into tc_ip_cidr_search_with_inverted_index values(1, '59.50.185.152', '2a02:e980:83:5b09:ecb8:c669:b336:650e', '127.0.0.0/8'),(3, '119.36.22.147', '2001:4888:1f:e891:161:26::', '127.0.0.0/8'),(2, '42.117.228.166', '2001:16a0:2:200a::2', null); """
+ sql """ insert into tc_ip_cidr_search_with_inverted_index values(4, '.', '2001:1b70:a1:610::b102:2', null); """
+ sql """ insert into tc_ip_cidr_search_with_inverted_index values(5, '255.255.255.255', 'ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffffg', null) """
+
+ qt_sql """ select count() from tc_ip_cidr_search_with_inverted_index"""
+ // without inverted index query
+ sql """ set enable_common_expr_pushdown = false; """
+ sql """ set enable_inverted_index_query=false; """
+ // select ipv6 in ipv4 cidr
+ qt_sql_without_ii_0 """ select id, ipv4, ipv6, is_ip_address_in_range(ipv6, '255.255.255.255/12') from tc_ip_cidr_search_with_inverted_index where is_ip_address_in_range(ipv6, '255.255.255.255/12') order by id; """
+ // select ipv6 in ipv6 cidr
+ qt_sql_without_ii_1 """ select id, ipv4, ipv6, is_ip_address_in_range(ipv6, 'ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff/12') from tc_ip_cidr_search_with_inverted_index where is_ip_address_in_range(ipv6, 'ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff/12') order by id; """
+ qt_sql_without_ii_2 """ select id, ipv4, ipv6, is_ip_address_in_range(ipv6, '::ffff:192.168.0.4/128') from tc_ip_cidr_search_with_inverted_index where is_ip_address_in_range(ipv6, '::ffff:192.168.0.4/128') order by id; """
+ qt_sql_without_ii_3 """ select id, ipv4, ipv6, is_ip_address_in_range(ipv6, '2001:16a0:2:200a::2/64') from tc_ip_cidr_search_with_inverted_index where is_ip_address_in_range(ipv6, '2001:16a0:2:200a::2/64') order by id; """
+
+ // select ipv4 in ipv6 cidr
+ qt_sql_without_ii_4 """ select id, ipv4, ipv6, is_ip_address_in_range(ipv4, 'ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff/12') from tc_ip_cidr_search_with_inverted_index where is_ip_address_in_range(ipv4, 'ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff/12') order by id; """
+ // select ipv4 in ipv4 cidr
+ qt_sql_without_ii_5 """ select id, ipv4, ipv6, is_ip_address_in_range(ipv6, '255.255.255.255/12') from tc_ip_cidr_search_with_inverted_index where is_ip_address_in_range(ipv4, '255.255.255.255/12') order by id; """
+ qt_sql_without_ii_6 """ select id, ipv4, ipv6, is_ip_address_in_range(ipv4, '127.0.0.0/8') from tc_ip_cidr_search_with_inverted_index where is_ip_address_in_range(ipv4, '127.0.0.0/8') order by id; """
+ qt_sql_without_ii_7 """ select id, ipv4, ipv6, is_ip_address_in_range(ipv4, '192.168.100.0/24') from tc_ip_cidr_search_with_inverted_index where is_ip_address_in_range(ipv4, '192.168.100.0/24') order by id; """
+
+ // select in null cidr
+ qt_sql_without_ii_8 """ select id, ipv4, ipv6, is_ip_address_in_range(ipv4, null) from tc_ip_cidr_search_with_inverted_index where is_ip_address_in_range(ipv4, null) order by id; """
+ qt_sql_without_ii_9 """ select id, ipv4, ipv6, is_ip_address_in_range(ipv6, null) from tc_ip_cidr_search_with_inverted_index where is_ip_address_in_range(ipv6, null) order by id; """
+
+ // with inverted index query
+ // If we use common expr pass to inverted index , we should set enable_common_expr_pushdown = true
Review Comment:
need debug point to ensure evaluated by inverted index
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](ip-function)improve is_ip_address_in_range for inverted index speed [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #41768:
URL: https://github.com/apache/doris/pull/41768#issuecomment-2410612913
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org