You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "valdar (via GitHub)" <gi...@apache.org> on 2023/10/12 10:26:47 UTC
[PR] Added build-catalog-tool-timeout parameter to install command. [camel-k]
valdar opened a new pull request, #4821:
URL: https://github.com/apache/camel-k/pull/4821
Added `build-catalog-tool-timeout` parameter to the `install` command.
Added `CAMEL_K_BUILD_CATALOG_TOOL_TIMEOUT` to e2e tests scripts to leverage the new install parameter.
Updated doc.
Small addition to .gitignore
This is useful in environment where the default timeout of 2 minutes is not sufficient.
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added build-catalog-tool-timeout parameter to install command. [camel-k]
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on code in PR #4821:
URL: https://github.com/apache/camel-k/pull/4821#discussion_r1356805326
##########
docs/modules/ROOT/pages/contributing/e2e.adoc:
##########
@@ -31,15 +31,22 @@ This is the list of the groups we are using (please, notice that they can slight
* builder (`make test-builder`)
* common (`make test-common`)
* commonwithcustominstall (`make test-common-with-custom-install`)
- * install (`make test-install` and `make test-install-olm`)
+ * install (`make test-install`, `make test-install-olm` and `test-install-upgrade`)
Review Comment:
```suggestion
* install (`make test-install`, `make test-install-olm` and `make test-install-upgrade`)
```
##########
docs/modules/ROOT/pages/installation/advanced/advanced.adoc:
##########
@@ -45,6 +45,7 @@ We have several configuration used to influence the building of an integration:
--build-strategy string Set the build strategy
--build-order-strategy string Set the build order strategy
--build-timeout string Set how long the build process can last
+--"build-catalog-tool-timeout string Set how long the catalogtool image build can last
Review Comment:
```suggestion
--build-catalog-tool-timeout string Set how long the catalogtool image build can last
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added build-catalog-tool-timeout parameter to install command. [camel-k]
Posted by "valdar (via GitHub)" <gi...@apache.org>.
valdar commented on PR #4821:
URL: https://github.com/apache/camel-k/pull/4821#issuecomment-1764905223
Ok thank to @squakez I figured out that for some days this PR is actually irrelevant for `main` due to https://github.com/apache/camel-k/pull/4764 .
I have ported it to `release-2.0.x` and opened against that branch here https://github.com/apache/camel-k/pull/4827 if it can be useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added build-catalog-tool-timeout parameter to install command. [camel-k]
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #4821:
URL: https://github.com/apache/camel-k/pull/4821#issuecomment-1761170634
If 2.0.x is going to have patch releases, we need to merge this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added build-catalog-tool-timeout parameter to install command. [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4821:
URL: https://github.com/apache/camel-k/pull/4821#issuecomment-1761281823
:camel: **Thank you for contributing!**
Code Coverage Report :heavy_check_mark: - Coverage unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added build-catalog-tool-timeout parameter to install command. [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4821:
URL: https://github.com/apache/camel-k/pull/4821#issuecomment-1761281001
:camel: **Thank you for contributing!**
Code Coverage Report :heavy_check_mark: - Coverage unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added build-catalog-tool-timeout parameter to install command. [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4821:
URL: https://github.com/apache/camel-k/pull/4821#issuecomment-1761180226
> If 2.0.x is going to have patch releases, we need to merge this one.
In case we should do on `release-2.x` branch only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added build-catalog-tool-timeout parameter to install command. [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4821:
URL: https://github.com/apache/camel-k/pull/4821#issuecomment-1759354243
:camel: **Thank you for contributing!**
Code Coverage Report :heavy_check_mark: - Coverage unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added build-catalog-tool-timeout parameter to install command. [camel-k]
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #4821:
URL: https://github.com/apache/camel-k/pull/4821#issuecomment-1761213395
> > If 2.0.x is not going to be released anymore, we should avoid publishing nightly. This PR is not dangerous and I think the target is the nightly release, so we could merge and in case there will be any future release it will be there, in case not, there is always the nightly.
>
> Yes. The target of this PR is `main`. If we want it on release branch it should be created another PR targeting it.
Ah, maybe I should check the branch before commenting nonsense!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added build-catalog-tool-timeout parameter to install command. [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4821:
URL: https://github.com/apache/camel-k/pull/4821#issuecomment-1761212415
> If 2.0.x is not going to be released anymore, we should avoid publishing nightly. This PR is not dangerous and I think the target is the nightly release, so we could merge and in case there will be any future release it will be there, in case not, there is always the nightly.
Yes. The target of this PR is `main`. If we want it on release branch it should be created another PR targeting it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added build-catalog-tool-timeout parameter to install command. [camel-k]
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #4821:
URL: https://github.com/apache/camel-k/pull/4821#issuecomment-1761186207
We are still publishing the nightly for 2.0.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added build-catalog-tool-timeout parameter to install command. [camel-k]
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #4821:
URL: https://github.com/apache/camel-k/pull/4821#issuecomment-1761188299
If 2.0.x is not going to be released anymore, we should avoid publishing nightly. This PR is not dangerous and I think the target is the nightly release, so we could merge and in case there will be any future release it will be there, in case not, there is always the nightly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added build-catalog-tool-timeout parameter to install command. [camel-k]
Posted by "valdar (via GitHub)" <gi...@apache.org>.
valdar closed pull request #4821: Added build-catalog-tool-timeout parameter to install command.
URL: https://github.com/apache/camel-k/pull/4821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org