[jira] [Commented] (THRIFT-1407) Typo in Python socket server causes Thrift to fail when we enable a global socket timout

["Hudson (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135913#comment-13135913 ] 

Hudson commented on THRIFT-1407:
--------------------------------

Integrated in Thrift #309 (See [https://builds.apache.org/job/Thrift/309/])
    THRIFT-1407: Typo in Python socket server causes Thrift to fail when we enable a global socket timout
Client: py
Patch: adalc

Fixes typo in python socket server timeout

jfarrell : http://svn.apache.org/viewvc/?view=rev&rev=1189170
Files : 
* /thrift/trunk/lib/py/src/transport/TSocket.py

                
> Typo in Python socket server causes Thrift to fail when we enable a global socket timout
> ----------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1407
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1407
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Library
>    Affects Versions: 0.8
>            Reporter: adalc@adobe.com
>              Labels: patch, python, socket, timeout
>             Fix For: 0.8
>
>         Attachments: TSocket.py.patch
>
>
> There is a typo in thrift.transport.TSocket.TServerSocket: instead of "settimeout", we have "set_timeout". This causes the code to not work properly when we enable a global socket timeout in Python, using "socket.settimeout(30)". Because of the typo, the Python Thrift server will fail to change it's socket back to a non-timing out mode, and the listen call will fail after the timeout passes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira