Re: [PR] ci: run pre-commit checks via prek [superset]

["bito-code-review[bot] (via GitHub)" <gi...@apache.org>]

bito-code-review[bot] commented on PR #42500:
URL: https://github.com/apache/superset/pull/42500#issuecomment-5196966473

   <!-- Bito Reply -->
   The line `echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"` is necessary because the `prek` installer places the binary in `$HOME/.cargo/bin`. Since this directory is not in the default system path, adding it to `GITHUB_PATH` ensures that the subsequent `prek run` commands can locate the executable. Removing this line would cause the job to fail with a "command not found" error for `prek`.
   
   **.github/workflows/pre-commit.yml**
   ```
   curl --proto '=https' --tlsv1.2 -LsSf https://github.com/j178/prek/releases/download/v0.4.11/prek-installer.sh | sh
             echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org