[GitHub] merlimat commented on a change in pull request #982: Retry on failure of ledger-deletion and avoid running callback in executor

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #982: Retry on failure of ledger-deletion and avoid running callback in executor
URL: https://github.com/apache/incubator-pulsar/pull/982#discussion_r157033562
 
 

 ##########
 File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
 ##########
 @@ -2156,47 +2156,55 @@ void readOperationCompleted() {
     }
 
     void asyncDeleteLedger(final LedgerHandle lh) {
-        if (lh == null) {
+        asyncDeleteLedger(lh, 3);
 
 Review comment:
   Also, should the retry be happening also for data ledgers?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services