You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ashutosh Mestry <am...@hortonworks.com> on 2017/08/02 22:26:45 UTC
Review Request 61389: ATLAS-2017: Import API: Request Parameter Made
Optional
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61389/
-----------------------------------------------------------
Review request for atlas and Madhan Neethiraj.
Bugs: ATLAS-2017
https://issues.apache.org/jira/browse/ATLAS-2017
Repository: atlas
Description
-------
**Implementation**
REST Import: Added _DefaultValue_. Removed empty check.
_ImportService.run_: Added overload to not have _AtlasRequest_ argument.
_ImportServiceTest_: Used the new method.
Documentation: Updated to reflect the paramter.
Diffs
-----
docs/src/site/twiki/Import-API.twiki 00ac9c4
repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java bdeed7d
repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java b96197b
repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java 3ccbd8e
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java fe9111b
Diff: https://reviews.apache.org/r/61389/diff/1/
Testing
-------
**Unit tests**
Updated to include new method.
Thanks,
Ashutosh Mestry
Re: Review Request 61389: ATLAS-2017: Import API: Request Parameter
Made Optional
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61389/#review182065
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Aug. 2, 2017, 10:26 p.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61389/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2017, 10:26 p.m.)
>
>
> Review request for atlas and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2017
> https://issues.apache.org/jira/browse/ATLAS-2017
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Implementation**
> REST Import: Added _DefaultValue_. Removed empty check.
> _ImportService.run_: Added overload to not have _AtlasRequest_ argument.
> _ImportServiceTest_: Used the new method.
> Documentation: Updated to reflect the paramter.
>
>
> Diffs
> -----
>
> docs/src/site/twiki/Import-API.twiki 00ac9c4
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java bdeed7d
> repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java b96197b
> repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java 3ccbd8e
> webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java fe9111b
>
>
> Diff: https://reviews.apache.org/r/61389/diff/1/
>
>
> Testing
> -------
>
> **Unit tests**
> Updated to include new method.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>