You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Daniel Pravat <dp...@outlook.com> on 2016/01/14 02:15:06 UTC

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40620/
-----------------------------------------------------------

(Updated Jan. 14, 2016, 1:15 a.m.)


Review request for Alex Naparu, Alex Clemmer, M Lawindi, and Yi Sun.


Summary (updated)
-----------------

Windows: Added suppport for `slave/monitor.cpp`.


Repository: mesos


Description
-------

Windows: Added suppport for `slave/monitor.cpp`.


Diffs
-----

  src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10 

Diff: https://reviews.apache.org/r/40620/diff/


Testing
-------

OSX: make
Windows: make


Thanks,

Daniel Pravat


Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp`.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40620/#review121553
-----------------------------------------------------------


Fix it, then Ship it!





src/CMakeLists.txt (line 248)
<https://reviews.apache.org/r/40620/#comment183273>

    Alphabetize.


- Joris Van Remoortere


On March 1, 2016, 11:58 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40620/
> -----------------------------------------------------------
> 
> (Updated March 1, 2016, 11:58 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Added suppport for `slave/monitor.cpp`.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a 
> 
> Diff: https://reviews.apache.org/r/40620/diff/
> 
> 
> Testing
> -------
> 
> OSX: make
> Windows: make
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp`.

Posted by Daniel Pravat <dp...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40620/
-----------------------------------------------------------

(Updated March 1, 2016, 11:58 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
-------

Windows: Added suppport for `slave/monitor.cpp`.


Diffs (updated)
-----

  src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a 

Diff: https://reviews.apache.org/r/40620/diff/


Testing
-------

OSX: make
Windows: make


Thanks,

Daniel Pravat