You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by ielcoro <gi...@git.apache.org> on 2015/07/20 17:59:16 UTC

[GitHub] cordova-plugin-file pull request: Prevent passing encoded URIS to ...

GitHub user ielcoro opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/126

    Prevent passing encoded URIS to native fs apis

    The current implementation of FileProxy.js passes encoded URIs to native filesystem apis, causing problems when handling files and directories with international or special characters.
    
    This pulls request prevents passing encoded URIS to native fs apis by decoding them first, like the java implementations does when using the java library's Uri class.
    
    In my tests the best pint to do this results inside sanitize method on FileProxy.js

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ielcoro/cordova-plugin-file feature/encoding

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/126.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #126
    
----
commit 6e3a98fa077f3f9cfdf792536eefd13692a04fd2
Author: IƱaki Elcoro <ie...@asemblia.com>
Date:   2015-07-20T15:13:53Z

    Prevent passing encoded URIS to native fs apis

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org