[jira] [Comment Edited] (HBASE-25359) create-release scripts releasedocmaker step should be optional

["Michael Stack (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-25359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244228#comment-17244228 ] 

Michael Stack edited comment on HBASE-25359 at 12/4/20, 6:50 PM:
-----------------------------------------------------------------

{quote}I see, that helps, but what if the RM manually updated the files and still wants to opt out?
{quote}
Smile. This is not supported. Will add it.

The create-release scripts are trying to do everything involved making an RC. There is little provision for mix and match of script and manual steps. Would take a good bit more effort making such allowance. It is an understandable desire though. RMs have a hard time 'trusting' the RC-maker is doing the right thing especially when it runs for hours seemingly silent on what it is doing and that it fails frequently (A few of us have been working on making it fail less frequently as well as on adding move coverage and better security).

The RC-making scripts currently do three steps: tag, build, and publiish. Could work on. making more steps. If the steps were documented, RM could do a step themselves manually and then let the RC-maker do the rest. That should be less work than making each step manual or script.


was (Author: stack):
{quote}I see, that helps, but what if the RM manually updated the files and still wants to opt out?
{quote}
Smile. This is not supported. Will add it.

The create-release scripts are trying to do everything involved making an RC. There is little provision for mix and match of script and manual steps. Would take a good bit more effort making such allowance. It is an understandable desire though. RMs have a hard time 'trusting' the RC-maker is doing the right thing especially when it runs for hours seemingly silent on what it is doing and that it fails frequently.

The RC-making scripts currently do three steps: tag, build, and publiish. Could work on. making more steps. If the steps were documented, RM could do a step themselves manually and then let the RC-maker do the rest. That should be less work than making each step manual or script.

> create-release scripts releasedocmaker step should be optional
> --------------------------------------------------------------
>
>                 Key: HBASE-25359
>                 URL: https://issues.apache.org/jira/browse/HBASE-25359
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Andrew Kyle Purtell
>            Priority: Major
>
> The create-release scripts assume, when invoking releasedocmaker and performing surgery on CHANGES.md and RELEASENOTES.md during the 'tag' stage, that the current RC step is RC0. The entirety of the generated CHANGES.md and RELEASENOTES.md files are stitched in at the head, just below the ASF notice. If we are at a RC step that is not zero, wouldn't this duplicate all CHANGES.md and RELEASENOTES.md content for the release? There would be all the content added for RC0, then the same content (with delta) added for RC1, and so on. 
> For this reason the releasedocmaker invocation should itself be optional.
> For RC steps > 0, assume the RM has updated CHANGES.md and RELEASENOTES.md to reflect the delta. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)