You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/10 04:15:53 UTC

[GitHub] [spark] beliefer opened a new pull request, #36492: [SPARK-39135][SQL] DS V2 aggregate partial push-down should supports group by without aggregate functions

beliefer opened a new pull request, #36492:
URL: https://github.com/apache/spark/pull/36492

   ### What changes were proposed in this pull request?
   Currently, the SQL show below not supported by DS V2 aggregate partial push-down.
   `select key from tab group by key`
   
   
   ### Why are the changes needed?
   Make DS V2 aggregate partial push-down supports group by without aggregate functions.
   
   
   ### Does this PR introduce _any_ user-facing change?
   'No'.
   New feature.
   
   
   ### How was this patch tested?
   New tests
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan closed pull request #36492: [SPARK-39135][SQL] DS V2 aggregate partial push-down should supports group by without aggregate functions

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #36492: [SPARK-39135][SQL] DS V2 aggregate partial push-down should supports group by without aggregate functions
URL: https://github.com/apache/spark/pull/36492


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #36492: [SPARK-39135][SQL] DS V2 aggregate partial push-down should supports group by without aggregate functions

Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #36492:
URL: https://github.com/apache/spark/pull/36492#issuecomment-1121977213

   ping @huaxingao cc @cloud-fan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #36492: [SPARK-39135][SQL] DS V2 aggregate partial push-down should supports group by without aggregate functions

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #36492:
URL: https://github.com/apache/spark/pull/36492#issuecomment-1122160068

   thanks, merging to master/3.3! (it's kind of a mistake in the agg pushdown)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #36492: [SPARK-39135][SQL] DS V2 aggregate partial push-down should supports group by without aggregate functions

Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #36492:
URL: https://github.com/apache/spark/pull/36492#issuecomment-1122185622

   @cloud-fan Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org