You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/06/09 15:58:19 UTC

[GitHub] [calcite] zabetak opened a new pull request #2009: Site: Add instructions for managing Calcite repos through GitHub

zabetak opened a new pull request #2009:
URL: https://github.com/apache/calcite/pull/2009


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [calcite] zabetak closed pull request #2009: Site: Add instructions for managing Calcite repos through GitHub

Posted by GitBox <gi...@apache.org>.
zabetak closed pull request #2009:
URL: https://github.com/apache/calcite/pull/2009


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [calcite] michaelmior commented on a change in pull request #2009: Site: Add instructions for managing Calcite repos through GitHub

Posted by GitBox <gi...@apache.org>.
michaelmior commented on a change in pull request #2009:
URL: https://github.com/apache/calcite/pull/2009#discussion_r442895483



##########
File path: site/_docs/howto.md
##########
@@ -474,6 +474,32 @@ $ ./src/main/scripts/generate-protobuf.sh
 The following sections are of interest to Calcite committers and in
 particular release managers.
 
+## Managing Calcite repositories through GitHub (for Calcite committers)
+
+Committers have write access to Calcite's 
+[ASF git repositories](https://gitbox.apache.org/repos/asf#calcite) hosting
+the source code of the project as well as the website.
+
+All repositories present on gitbox are available on GitHub with write-access 
+enabled, including rights to open/close/merge pull requests and address issues.
+
+In order to exploit the GitHub services, committers should link their accounts
+(ASF, GitHub) via the [account linking page](https://gitbox.apache.org/setup/).
+
+Here are the steps:
+
+ * Set your GitHub ID into your [Apache ID profile](https://id.apache.org/).
+ * Enable [GitHub 2FA](https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/)
+on your GitHub account. 
+ * Activating GitHub 2FA changes the authentication process and may affect the way you 
+ [access GitHub](https://help.github.com/en/github/authenticating-to-github/accessing-github-using-two-factor-authentication#using-two-factor-authentication-with-the-command-line).
+You may need to establish personal access tokens or upload your public SSH key to GitHub depending on the 
+protocol (HTTPS vs. SSH) that you are using.     

Review comment:
       (HTTPS vs. SSH) that you are using. ->  that you are using (HTTPS vs. SSH).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [calcite] michaelmior commented on a change in pull request #2009: Site: Add instructions for managing Calcite repos through GitHub

Posted by GitBox <gi...@apache.org>.
michaelmior commented on a change in pull request #2009:
URL: https://github.com/apache/calcite/pull/2009#discussion_r442894745



##########
File path: site/_docs/howto.md
##########
@@ -474,6 +474,32 @@ $ ./src/main/scripts/generate-protobuf.sh
 The following sections are of interest to Calcite committers and in
 particular release managers.
 
+## Managing Calcite repositories through GitHub (for Calcite committers)
+
+Committers have write access to Calcite's 
+[ASF git repositories](https://gitbox.apache.org/repos/asf#calcite) hosting
+the source code of the project as well as the website.
+
+All repositories present on gitbox are available on GitHub with write-access 
+enabled, including rights to open/close/merge pull requests and address issues.
+
+In order to exploit the GitHub services, committers should link their accounts
+(ASF, GitHub) via the [account linking page](https://gitbox.apache.org/setup/).

Review comment:
       accounts (ASF, GitHub) -> ASF and GitHub accounts




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [calcite] michaelmior commented on a change in pull request #2009: Site: Add instructions for managing Calcite repos through GitHub

Posted by GitBox <gi...@apache.org>.
michaelmior commented on a change in pull request #2009:
URL: https://github.com/apache/calcite/pull/2009#discussion_r442895164



##########
File path: site/_docs/howto.md
##########
@@ -474,6 +474,32 @@ $ ./src/main/scripts/generate-protobuf.sh
 The following sections are of interest to Calcite committers and in
 particular release managers.
 
+## Managing Calcite repositories through GitHub (for Calcite committers)
+
+Committers have write access to Calcite's 
+[ASF git repositories](https://gitbox.apache.org/repos/asf#calcite) hosting
+the source code of the project as well as the website.
+
+All repositories present on gitbox are available on GitHub with write-access 
+enabled, including rights to open/close/merge pull requests and address issues.
+
+In order to exploit the GitHub services, committers should link their accounts
+(ASF, GitHub) via the [account linking page](https://gitbox.apache.org/setup/).
+
+Here are the steps:
+
+ * Set your GitHub ID into your [Apache ID profile](https://id.apache.org/).

Review comment:
       Set your GitHub ID into your [Apache ID profile](https://id.apache.org/)
   vv
   Set your GitHub username in your [Apache profile](https://id.apache.org/)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [calcite] michaelmior commented on pull request #2009: Site: Add instructions for managing Calcite repos through GitHub

Posted by GitBox <gi...@apache.org>.
michaelmior commented on pull request #2009:
URL: https://github.com/apache/calcite/pull/2009#issuecomment-646689693


   Forgive me for being rather pedantic. This looks great. Just a few small suggested changes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [calcite] michaelmior commented on a change in pull request #2009: Site: Add instructions for managing Calcite repos through GitHub

Posted by GitBox <gi...@apache.org>.
michaelmior commented on a change in pull request #2009:
URL: https://github.com/apache/calcite/pull/2009#discussion_r442896178



##########
File path: site/_docs/howto.md
##########
@@ -474,6 +474,32 @@ $ ./src/main/scripts/generate-protobuf.sh
 The following sections are of interest to Calcite committers and in
 particular release managers.
 
+## Managing Calcite repositories through GitHub (for Calcite committers)
+
+Committers have write access to Calcite's 
+[ASF git repositories](https://gitbox.apache.org/repos/asf#calcite) hosting
+the source code of the project as well as the website.
+
+All repositories present on gitbox are available on GitHub with write-access 
+enabled, including rights to open/close/merge pull requests and address issues.
+
+In order to exploit the GitHub services, committers should link their accounts
+(ASF, GitHub) via the [account linking page](https://gitbox.apache.org/setup/).
+
+Here are the steps:
+
+ * Set your GitHub ID into your [Apache ID profile](https://id.apache.org/).
+ * Enable [GitHub 2FA](https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/)
+on your GitHub account. 
+ * Activating GitHub 2FA changes the authentication process and may affect the way you 
+ [access GitHub](https://help.github.com/en/github/authenticating-to-github/accessing-github-using-two-factor-authentication#using-two-factor-authentication-with-the-command-line).
+You may need to establish personal access tokens or upload your public SSH key to GitHub depending on the 
+protocol (HTTPS vs. SSH) that you are using.     
+ * Merge your Apache and GitHub accounts using the [account linking page](https://gitbox.apache.org/setup/)
+(you should see 3 green checks in GitBox).
+ * Wait at least 30  minutes for an email inviting you to Apache GitHub Organization. 
+ * Accept invitation and verify that you are a [member of the team](https://github.com/orgs/apache/teams/calcite-committers/members). 

Review comment:
       Accept invitation -> Accept the invitation




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [calcite] michaelmior commented on a change in pull request #2009: Site: Add instructions for managing Calcite repos through GitHub

Posted by GitBox <gi...@apache.org>.
michaelmior commented on a change in pull request #2009:
URL: https://github.com/apache/calcite/pull/2009#discussion_r442895916



##########
File path: site/_docs/howto.md
##########
@@ -474,6 +474,32 @@ $ ./src/main/scripts/generate-protobuf.sh
 The following sections are of interest to Calcite committers and in
 particular release managers.
 
+## Managing Calcite repositories through GitHub (for Calcite committers)
+
+Committers have write access to Calcite's 
+[ASF git repositories](https://gitbox.apache.org/repos/asf#calcite) hosting
+the source code of the project as well as the website.
+
+All repositories present on gitbox are available on GitHub with write-access 
+enabled, including rights to open/close/merge pull requests and address issues.
+
+In order to exploit the GitHub services, committers should link their accounts
+(ASF, GitHub) via the [account linking page](https://gitbox.apache.org/setup/).
+
+Here are the steps:
+
+ * Set your GitHub ID into your [Apache ID profile](https://id.apache.org/).
+ * Enable [GitHub 2FA](https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/)
+on your GitHub account. 
+ * Activating GitHub 2FA changes the authentication process and may affect the way you 
+ [access GitHub](https://help.github.com/en/github/authenticating-to-github/accessing-github-using-two-factor-authentication#using-two-factor-authentication-with-the-command-line).
+You may need to establish personal access tokens or upload your public SSH key to GitHub depending on the 
+protocol (HTTPS vs. SSH) that you are using.     
+ * Merge your Apache and GitHub accounts using the [account linking page](https://gitbox.apache.org/setup/)
+(you should see 3 green checks in GitBox).
+ * Wait at least 30  minutes for an email inviting you to Apache GitHub Organization. 

Review comment:
       "30  minutes" has an extra space




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [calcite] zabetak commented on pull request #2009: Site: Add instructions for managing Calcite repos through GitHub

Posted by GitBox <gi...@apache.org>.
zabetak commented on pull request #2009:
URL: https://github.com/apache/calcite/pull/2009#issuecomment-650835726


   > Forgive me for being rather pedantic. This looks great. Just a few small suggested changes.
   
   Thanks for the second pair of eyes @michaelmior and @chunweilei , much appreciated. I addressed the comments, if nothing comes up in the following days I will push it through ;)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [calcite] michaelmior commented on a change in pull request #2009: Site: Add instructions for managing Calcite repos through GitHub

Posted by GitBox <gi...@apache.org>.
michaelmior commented on a change in pull request #2009:
URL: https://github.com/apache/calcite/pull/2009#discussion_r442894462



##########
File path: site/_docs/howto.md
##########
@@ -474,6 +474,32 @@ $ ./src/main/scripts/generate-protobuf.sh
 The following sections are of interest to Calcite committers and in
 particular release managers.
 
+## Managing Calcite repositories through GitHub (for Calcite committers)
+
+Committers have write access to Calcite's 
+[ASF git repositories](https://gitbox.apache.org/repos/asf#calcite) hosting
+the source code of the project as well as the website.
+
+All repositories present on gitbox are available on GitHub with write-access 

Review comment:
       gitbox -> GitBox




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [calcite] michaelmior commented on a change in pull request #2009: Site: Add instructions for managing Calcite repos through GitHub

Posted by GitBox <gi...@apache.org>.
michaelmior commented on a change in pull request #2009:
URL: https://github.com/apache/calcite/pull/2009#discussion_r442894462



##########
File path: site/_docs/howto.md
##########
@@ -474,6 +474,32 @@ $ ./src/main/scripts/generate-protobuf.sh
 The following sections are of interest to Calcite committers and in
 particular release managers.
 
+## Managing Calcite repositories through GitHub (for Calcite committers)
+
+Committers have write access to Calcite's 
+[ASF git repositories](https://gitbox.apache.org/repos/asf#calcite) hosting
+the source code of the project as well as the website.
+
+All repositories present on gitbox are available on GitHub with write-access 

Review comment:
       gitbox -> Gitbox




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org