You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Olga Natkovich (JIRA)" <ji...@apache.org> on 2007/12/20 00:52:43 UTC

[jira] Created: (PIG-54) built in aggregate functions fail on invalid input

built in aggregate functions fail on invalid input
--------------------------------------------------

                 Key: PIG-54
                 URL: https://issues.apache.org/jira/browse/PIG-54
             Project: Pig
          Issue Type: Bug
            Reporter: Olga Natkovich


This issue is true for all built-in aggregate functions. If they get type different from what they expect, they through an exception. Instead, they should treat the value as null. We still need to define what that means in Pig but if we stick with SQL definition, all but count(*) computations would ignore them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-54) built in aggregate functions fail on invalid input

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-54:
------------------------------

        Fix Version/s: types_branch
             Assignee: Pradeep Kamath
    Affects Version/s: types_branch
               Status: Patch Available  (was: Open)

Attached patch

> built in aggregate functions fail on invalid input
> --------------------------------------------------
>
>                 Key: PIG-54
>                 URL: https://issues.apache.org/jira/browse/PIG-54
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Olga Natkovich
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: PIG-54.patch
>
>
> This issue is true for all built-in aggregate functions. If they get type different from what they expect, they through an exception. Instead, they should treat the value as null. We still need to define what that means in Pig but if we stick with SQL definition, all but count(*) computations would ignore them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (PIG-54) built in aggregate functions fail on invalid input

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635850#action_12635850 ] 

pkamath edited comment on PIG-54 at 9/30/08 1:39 PM:
------------------------------------------------------------

SUM handles this, we count NULLs in COUNT - AVG works using these semantics.

The patch fixed MIN and MAX

      was (Author: pkamath):
    SUM handles this, we count NULLs in COUNT - AVG works based on these.

The patch fixed MIN and MAX
  
> built in aggregate functions fail on invalid input
> --------------------------------------------------
>
>                 Key: PIG-54
>                 URL: https://issues.apache.org/jira/browse/PIG-54
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Olga Natkovich
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: PIG-54.patch
>
>
> This issue is true for all built-in aggregate functions. If they get type different from what they expect, they through an exception. Instead, they should treat the value as null. We still need to define what that means in Pig but if we stick with SQL definition, all but count(*) computations would ignore them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-54) built in aggregate functions fail on invalid input

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635850#action_12635850 ] 

Pradeep Kamath commented on PIG-54:
-----------------------------------

SUM handles this, we count NULLs in COUNT - AVG works based on these.

The patch fixed MIN and MAX

> built in aggregate functions fail on invalid input
> --------------------------------------------------
>
>                 Key: PIG-54
>                 URL: https://issues.apache.org/jira/browse/PIG-54
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Olga Natkovich
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: PIG-54.patch
>
>
> This issue is true for all built-in aggregate functions. If they get type different from what they expect, they through an exception. Instead, they should treat the value as null. We still need to define what that means in Pig but if we stick with SQL definition, all but count(*) computations would ignore them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-54) built in aggregate functions fail on invalid input

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-54:
------------------------------

    Attachment: PIG-54.patch

> built in aggregate functions fail on invalid input
> --------------------------------------------------
>
>                 Key: PIG-54
>                 URL: https://issues.apache.org/jira/browse/PIG-54
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Olga Natkovich
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: PIG-54.patch
>
>
> This issue is true for all built-in aggregate functions. If they get type different from what they expect, they through an exception. Instead, they should treat the value as null. We still need to define what that means in Pig but if we stick with SQL definition, all but count(*) computations would ignore them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-54) built in aggregate functions fail on invalid input

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich updated PIG-54:
------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

patch committed; thaks, pradeep

> built in aggregate functions fail on invalid input
> --------------------------------------------------
>
>                 Key: PIG-54
>                 URL: https://issues.apache.org/jira/browse/PIG-54
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Olga Natkovich
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: PIG-54.patch
>
>
> This issue is true for all built-in aggregate functions. If they get type different from what they expect, they through an exception. Instead, they should treat the value as null. We still need to define what that means in Pig but if we stick with SQL definition, all but count(*) computations would ignore them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.