You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/21 22:47:48 UTC

[GitHub] [tvm] mbs-octoml commented on pull request #11091: [AOT] Enable A-Normal Form in the AOT executor

mbs-octoml commented on PR #11091:
URL: https://github.com/apache/tvm/pull/11091#issuecomment-1105832777

   In an ideal world we'd convert to ANF early on. In addition to making eval order explicit, it would also mean we could retire MixedModeVisitor in favor since the deep recursion will be in lets. However we can't do that without interrupting all uses of DFPatterns since the matcher does not 'see through' vars. You thankfully stay well out of that mess, so I'd support this.
   
   That said the visit order is deterministic, right? Or pehaps we're accidentally depending on arbitrary undordered_set iteration order somewher is the visitor machinery?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org