[GitHub] [spark] cloud-fan commented on a change in pull request #27509: [SPARK-30764][SQL] Improve the readability of EXPLAIN FORMATTED style

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #27509: [SPARK-30764][SQL] Improve the readability of EXPLAIN FORMATTED style
URL: https://github.com/apache/spark/pull/27509#discussion_r381960415
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ExplainUtils.scala
 ##########
 @@ -182,6 +181,17 @@ object ExplainUtils {
     }
   }
 
+  /**
+   * Generate detailed field string with different format based on type of input value
+   */
+  def generateFieldString(fieldName: String, values: Any): String = values match {
+    case iter: Iterable[_] if (iter.size == 0) => s"${fieldName}: []"
 
 Review comment:
   nit: `if iter.size == 0`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org