You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/12/06 14:02:40 UTC
[GitHub] [trafficcontrol] zrhoffman opened a new pull request #6407: Minor upgrade of Go dependencies
zrhoffman opened a new pull request #6407:
URL: https://github.com/apache/trafficcontrol/pull/6407
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
This PR updates our Go modules by wiping and regenerating our `go.mod` file. Our dependency versions our now the highest stable versions that our dependencies agree on (not necessarily the highest versions overall).
### Version changes
Package | Old version | New version | Upgrade type
------- | ----------- | ----------- | ------------
[code.cloudfoundry.org/bytefmt](https://pkg.go.dev/code.cloudfoundry.org/bytefmt) | **commit upgrade** | [`v0.0.0-20180108190415-b31f603f5e1e`](https://pkg.go.dev/code.cloudfoundry.org/bytefmt@v0.0.0-20180108190415-b31f603f5e1e) | [`v0.0.0-20211005130812-5bb3c17173e5`](https://pkg.go.dev/code.cloudfoundry.org/bytefmt@v0.0.0-20211005130812-5bb3c17173e5)
[github.com/asaskevich/govalidator](https://pkg.go.dev/github.com/asaskevich/govalidator) | **commit upgrade** | [`v0.0.0-20180319081651-7d2e70ef918f`](https://pkg.go.dev/github.com/asaskevich/govalidator@v0.0.0-20180319081651-7d2e70ef918f) | [`v0.0.0-20210307081110-f21760c49a8d`](https://pkg.go.dev/github.com/asaskevich/govalidator@v0.0.0-20210307081110-f21760c49a8d)
[github.com/Azure/go-ntlmssp](https://pkg.go.dev/github.com/Azure/go-ntlmssp) | unchanged | [`v0.0.0-20200615164410-66371956d46c`](https://pkg.go.dev/github.com/Azure/go-ntlmssp@v0.0.0-20200615164410-66371956d46c) | [`v0.0.0-20200615164410-66371956d46c`](https://pkg.go.dev/github.com/Azure/go-ntlmssp@v0.0.0-20200615164410-66371956d46c)
[github.com/basho/backoff](https://pkg.go.dev/github.com/basho/backoff) | unchanged | [`v0.0.0-20150307023525-2ff7c4694083`](https://pkg.go.dev/github.com/basho/backoff@v0.0.0-20150307023525-2ff7c4694083) | [`v0.0.0-20150307023525-2ff7c4694083`](https://pkg.go.dev/github.com/basho/backoff@v0.0.0-20150307023525-2ff7c4694083)
[github.com/basho/riak-go-client](https://pkg.go.dev/github.com/basho/riak-go-client) | unchanged | [`v1.7.1-0.20170327205844-5587c16e0b8b`](https://pkg.go.dev/github.com/basho/riak-go-client@v1.7.1-0.20170327205844-5587c16e0b8b) | [`v1.7.1-0.20170327205844-5587c16e0b8b`](https://pkg.go.dev/github.com/basho/riak-go-client@v1.7.1-0.20170327205844-5587c16e0b8b)
[github.com/cenkalti/backoff](https://pkg.go.dev/github.com/cenkalti/backoff) | unchanged | [`v2.2.1+incompatible`](https://pkg.go.dev/github.com/cenkalti/backoff@v2.2.1+incompatible) | [`v2.2.1+incompatible`](https://pkg.go.dev/github.com/cenkalti/backoff@v2.2.1+incompatible)
[github.com/cihub/seelog](https://pkg.go.dev/github.com/cihub/seelog) | **commit upgrade** | [`v0.0.0-20170110094445-7bfb7937d106`](https://pkg.go.dev/github.com/cihub/seelog@v0.0.0-20170110094445-7bfb7937d106) | [`v0.0.0-20170130134532-f561c5e57575`](https://pkg.go.dev/github.com/cihub/seelog@v0.0.0-20170130134532-f561c5e57575)
[github.com/dchest/siphash](https://pkg.go.dev/github.com/dchest/siphash) | **minor upgrade** | [`v1.1.0`](https://pkg.go.dev/github.com/dchest/siphash@v1.1.0) | [`v1.2.2`](https://pkg.go.dev/github.com/dchest/siphash@v1.2.2)
[github.com/decred/dcrd/dcrec/secp256k1/v4](https://pkg.go.dev/github.com/decred/dcrd/dcrec/secp256k1/v4) | unchanged | [`v4.0.0-20210816181553-5444fa50b93d`](https://pkg.go.dev/github.com/decred/dcrd/dcrec/secp256k1/v4@v4.0.0-20210816181553-5444fa50b93d) | [`v4.0.0-20210816181553-5444fa50b93d`](https://pkg.go.dev/github.com/decred/dcrd/dcrec/secp256k1/v4@v4.0.0-20210816181553-5444fa50b93d)
[github.com/dgrijalva/jwt-go](https://pkg.go.dev/github.com/dgrijalva/jwt-go) | unchanged | [`v3.2.1-0.20190620180102-5e25c22bd5d6+incompatible`](https://pkg.go.dev/github.com/dgrijalva/jwt-go@v3.2.1-0.20190620180102-5e25c22bd5d6+incompatible) | [`v3.2.1-0.20190620180102-5e25c22bd5d6+incompatible`](https://pkg.go.dev/github.com/dgrijalva/jwt-go@v3.2.1-0.20190620180102-5e25c22bd5d6+incompatible)
[github.com/fsnotify/fsnotify](https://pkg.go.dev/github.com/fsnotify/fsnotify) | **minor upgrade** | [`v1.3.0`](https://pkg.go.dev/github.com/fsnotify/fsnotify@v1.3.0) | [`v1.5.1`](https://pkg.go.dev/github.com/fsnotify/fsnotify@v1.5.1)
[github.com/GehirnInc/crypt](https://pkg.go.dev/github.com/GehirnInc/crypt) | **commit upgrade** | [`v0.0.0-20190301055215-6c0105aabd46`](https://pkg.go.dev/github.com/GehirnInc/crypt@v0.0.0-20190301055215-6c0105aabd46) | [`v0.0.0-20200316065508-bb7000b8a962`](https://pkg.go.dev/github.com/GehirnInc/crypt@v0.0.0-20200316065508-bb7000b8a962)
[github.com/go-acme/lego](https://pkg.go.dev/github.com/go-acme/lego) | unchanged | [`v2.7.2+incompatible`](https://pkg.go.dev/github.com/go-acme/lego@v2.7.2+incompatible) | [`v2.7.2+incompatible`](https://pkg.go.dev/github.com/go-acme/lego@v2.7.2+incompatible)
[github.com/go-asn1-ber/asn1-ber](https://pkg.go.dev/github.com/go-asn1-ber/asn1-ber) | unchanged | [`v1.5.1`](https://pkg.go.dev/github.com/go-asn1-ber/asn1-ber@v1.5.1) | [`v1.5.1`](https://pkg.go.dev/github.com/go-asn1-ber/asn1-ber@v1.5.1)
[github.com/goccy/go-json](https://pkg.go.dev/github.com/goccy/go-json) | unchanged | [`v0.7.10`](https://pkg.go.dev/github.com/goccy/go-json@v0.7.10) | [`v0.7.10`](https://pkg.go.dev/github.com/goccy/go-json@v0.7.10)
[github.com/gofrs/flock](https://pkg.go.dev/github.com/gofrs/flock) | **minor upgrade** | [`v0.7.2-0.20190320160742-5135e617513b`](https://pkg.go.dev/github.com/gofrs/flock@v0.7.2-0.20190320160742-5135e617513b) | [`v0.8.1`](https://pkg.go.dev/github.com/gofrs/flock@v0.8.1)
[github.com/golang-migrate/migrate/v4](https://pkg.go.dev/github.com/golang-migrate/migrate/v4) | **minor upgrade** | [`v4.14.1`](https://pkg.go.dev/github.com/golang-migrate/migrate/v4@v4.14.1) | [`v4.15.1`](https://pkg.go.dev/github.com/golang-migrate/migrate/v4@v4.15.1)
[github.com/golang/protobuf](https://pkg.go.dev/github.com/golang/protobuf) | technically **major upgrade** (though [`1643683...v1.0.0`](https://github.com/golang/protobuf/compare/1643683e1b54...v1.0.0) is 3 commits) | [`v0.0.0-20171021043952-1643683e1b54`](https://pkg.go.dev/github.com/golang/protobuf@v0.0.0-20171021043952-1643683e1b54) | [`v1.5.2`](https://pkg.go.dev/github.com/golang/protobuf@v1.5.2)
[github.com/go-ldap/ldap/v3](https://pkg.go.dev/github.com/go-ldap/ldap/v3) | unchanged | [`v3.4.1`](https://pkg.go.dev/github.com/go-ldap/ldap/v3@v3.4.1) | [`v3.4.1`](https://pkg.go.dev/github.com/go-ldap/ldap/v3@v3.4.1)
[github.com/google/uuid](https://pkg.go.dev/github.com/google/uuid) | **minor upgrade** | [`v1.1.2`](https://pkg.go.dev/github.com/google/uuid@v1.1.2) | [`v1.3.0`](https://pkg.go.dev/github.com/google/uuid@v1.3.0)
[github.com/go-ozzo/ozzo-validation](https://pkg.go.dev/github.com/go-ozzo/ozzo-validation) | **minor upgrade** | [`v3.0.3-0.20180119232150-44af65fe9adf+incompatible`](https://pkg.go.dev/github.com/go-ozzo/ozzo-validation@v3.0.3-0.20180119232150-44af65fe9adf+incompatible) | [`v3.6.0+incompatible`](https://pkg.go.dev/github.com/go-ozzo/ozzo-validation@v3.6.0+incompatible)
[github.com/hashicorp/errwrap](https://pkg.go.dev/github.com/hashicorp/errwrap) | unchanged | [`v1.0.0`](https://pkg.go.dev/github.com/hashicorp/errwrap@v1.0.0) | [`v1.0.0`](https://pkg.go.dev/github.com/hashicorp/errwrap@v1.0.0)
[github.com/hashicorp/go-multierror](https://pkg.go.dev/github.com/hashicorp/go-multierror) | unchanged | [`v1.1.0`](https://pkg.go.dev/github.com/hashicorp/go-multierror@v1.1.0) | [`v1.1.0`](https://pkg.go.dev/github.com/hashicorp/go-multierror@v1.1.0)
[github.com/hydrogen18/stoppableListener](https://pkg.go.dev/github.com/hydrogen18/stoppableListener) | **commit upgrade** | [`v0.0.0-20151210151943-dadc9ccc400c`](https://pkg.go.dev/github.com/hydrogen18/stoppableListener@v0.0.0-20151210151943-dadc9ccc400c) | [`v0.0.0-20161101122645-827d760f0663`](https://pkg.go.dev/github.com/hydrogen18/stoppableListener@v0.0.0-20161101122645-827d760f0663)
[github.com/influxdata/influxdb](https://pkg.go.dev/github.com/influxdata/influxdb) | **minor upgrade** | [`v1.1.1-0.20170104212736-6a94d200c826`](https://pkg.go.dev/github.com/influxdata/influxdb@v1.1.1-0.20170104212736-6a94d200c826) | [`v1.9.5`](https://pkg.go.dev/github.com/influxdata/influxdb@v1.9.5)
[github.com/jmoiron/sqlx](https://pkg.go.dev/github.com/jmoiron/sqlx) | **minor upgrade** | [`v1.2.0`](https://pkg.go.dev/github.com/jmoiron/sqlx@v1.2.0) | [`v1.3.4`](https://pkg.go.dev/github.com/jmoiron/sqlx@v1.3.4)
[github.com/json-iterator/go](https://pkg.go.dev/github.com/json-iterator/go) | **patch upgrade** | [`v1.1.6-0.20181024152841-05d041de1043`](https://pkg.go.dev/github.com/json-iterator/go@v1.1.6-0.20181024152841-05d041de1043) | [`v1.1.12`](https://pkg.go.dev/github.com/json-iterator/go@v1.1.12)
[github.com/kelseyhightower/envconfig](https://pkg.go.dev/github.com/kelseyhightower/envconfig) | **minor upgrade** | [`v1.3.1-0.20180308190516-b2c5c876e265`](https://pkg.go.dev/github.com/kelseyhightower/envconfig@v1.3.1-0.20180308190516-b2c5c876e265) | [`v1.4.0`](https://pkg.go.dev/github.com/kelseyhightower/envconfig@v1.4.0)
[github.com/kylelemons/godebug](https://pkg.go.dev/github.com/kylelemons/godebug) | unchanged | [`v1.1.1-0.20201107061927-e693023230a4`](https://pkg.go.dev/github.com/kylelemons/godebug@v1.1.1-0.20201107061927-e693023230a4) | [`v1.1.1-0.20201107061927-e693023230a4`](https://pkg.go.dev/github.com/kylelemons/godebug@v1.1.1-0.20201107061927-e693023230a4)
[github.com/lestrrat-go/backoff/v2](https://pkg.go.dev/github.com/lestrrat-go/backoff/v2) | unchanged | [`v2.0.8`](https://pkg.go.dev/github.com/lestrrat-go/backoff/v2@v2.0.8) | [`v2.0.8`](https://pkg.go.dev/github.com/lestrrat-go/backoff/v2@v2.0.8)
[github.com/lestrrat-go/blackmagic](https://pkg.go.dev/github.com/lestrrat-go/blackmagic) | unchanged | [`v1.0.0`](https://pkg.go.dev/github.com/lestrrat-go/blackmagic@v1.0.0) | [`v1.0.0`](https://pkg.go.dev/github.com/lestrrat-go/blackmagic@v1.0.0)
[github.com/lestrrat-go/httpcc](https://pkg.go.dev/github.com/lestrrat-go/httpcc) | unchanged | [`v1.0.0`](https://pkg.go.dev/github.com/lestrrat-go/httpcc@v1.0.0) | [`v1.0.0`](https://pkg.go.dev/github.com/lestrrat-go/httpcc@v1.0.0)
[github.com/lestrrat-go/iter](https://pkg.go.dev/github.com/lestrrat-go/iter) | unchanged | [`v1.0.1`](https://pkg.go.dev/github.com/lestrrat-go/iter@v1.0.1) | [`v1.0.1`](https://pkg.go.dev/github.com/lestrrat-go/iter@v1.0.1)
[github.com/lestrrat-go/jwx](https://pkg.go.dev/github.com/lestrrat-go/jwx) | unchanged | [`v1.2.12`](https://pkg.go.dev/github.com/lestrrat-go/jwx@v1.2.12) | [`v1.2.12`](https://pkg.go.dev/github.com/lestrrat-go/jwx@v1.2.12)
[github.com/lestrrat-go/option](https://pkg.go.dev/github.com/lestrrat-go/option) | unchanged | [`v1.0.0`](https://pkg.go.dev/github.com/lestrrat-go/option@v1.0.0) | [`v1.0.0`](https://pkg.go.dev/github.com/lestrrat-go/option@v1.0.0)
[github.com/lib/pq](https://pkg.go.dev/github.com/lib/pq) | **minor upgrade** | [`v1.8.0`](https://pkg.go.dev/github.com/lib/pq@v1.8.0) | [`v1.10.4`](https://pkg.go.dev/github.com/lib/pq@v1.10.4)
[github.com/miekg/dns](https://pkg.go.dev/github.com/miekg/dns) | **minor upgrade** | [`v1.0.6-0.20180406150955-01d59357d468`](https://pkg.go.dev/github.com/miekg/dns@v1.0.6-0.20180406150955-01d59357d468) | [`v1.1.43`](https://pkg.go.dev/github.com/miekg/dns@v1.1.43)
[github.com/modern-go/concurrent](https://pkg.go.dev/github.com/modern-go/concurrent) | unchanged | [`v0.0.0-20180306012644-bacd9c7ef1dd`](https://pkg.go.dev/github.com/modern-go/concurrent@v0.0.0-20180306012644-bacd9c7ef1dd) | [`v0.0.0-20180306012644-bacd9c7ef1dd`](https://pkg.go.dev/github.com/modern-go/concurrent@v0.0.0-20180306012644-bacd9c7ef1dd)
[github.com/modern-go/reflect2](https://pkg.go.dev/github.com/modern-go/reflect2) | **patch upgrade** | [`v1.0.1`](https://pkg.go.dev/github.com/modern-go/reflect2@v1.0.1) | [`v1.0.2`](https://pkg.go.dev/github.com/modern-go/reflect2@v1.0.2)
[github.com/nxadm/tail](https://pkg.go.dev/github.com/nxadm/tail) | **patch upgrade** | [`v1.4.4`](https://pkg.go.dev/github.com/nxadm/tail@v1.4.4) | [`v1.4.8`](https://pkg.go.dev/github.com/nxadm/tail@v1.4.8)
[github.com/onsi/ginkgo](https://pkg.go.dev/github.com/onsi/ginkgo) | **minor upgrade** | [`v1.14.2`](https://pkg.go.dev/github.com/onsi/ginkgo@v1.14.2) | [`v1.16.5`](https://pkg.go.dev/github.com/onsi/ginkgo@v1.16.5)
[github.com/onsi/gomega](https://pkg.go.dev/github.com/onsi/gomega) | **minor upgrade** | [`v1.10.3`](https://pkg.go.dev/github.com/onsi/gomega@v1.10.3) | [`v1.17.0`](https://pkg.go.dev/github.com/onsi/gomega@v1.17.0)
[github.com/pborman/getopt/v2](https://pkg.go.dev/github.com/pborman/getopt/v2) | unchanged | [`v2.1.0`](https://pkg.go.dev/github.com/pborman/getopt/v2@v2.1.0) | [`v2.1.0`](https://pkg.go.dev/github.com/pborman/getopt/v2@v2.1.0)
[github.com/pkg/errors](https://pkg.go.dev/github.com/pkg/errors) | unchanged | [`v0.9.1`](https://pkg.go.dev/github.com/pkg/errors@v0.9.1) | [`v0.9.1`](https://pkg.go.dev/github.com/pkg/errors@v0.9.1)
[go.etcd.io/bbolt](https://pkg.go.dev/go.etcd.io/bbolt) | **patch upgrade** | [`v1.3.5`](https://pkg.go.dev/go.etcd.io/bbolt@v1.3.5) | [`v1.3.6`](https://pkg.go.dev/go.etcd.io/bbolt@v1.3.6)
[golang.org/x/crypto](https://pkg.go.dev/golang.org/x/crypto) | unchanged | [`v0.0.0-20211202192323-5770296d904e`](https://pkg.go.dev/golang.org/x/crypto@v0.0.0-20211202192323-5770296d904e) | [`v0.0.0-20211202192323-5770296d904e`](https://pkg.go.dev/golang.org/x/crypto@v0.0.0-20211202192323-5770296d904e)
[golang.org/x/net](https://pkg.go.dev/golang.org/x/net) | **commit upgrade** | [`v0.0.0-20211201190559-0a0e4e1bb54c`](https://pkg.go.dev/golang.org/x/net@v0.0.0-20211201190559-0a0e4e1bb54c) | [`v0.0.0-20211205041911-012df41ee64c`](https://pkg.go.dev/golang.org/x/net@v0.0.0-20211205041911-012df41ee64c)
[golang.org/x/sys](https://pkg.go.dev/golang.org/x/sys) | **commit upgrade** | [`v0.0.0-20211124211545-fe61309f8881`](https://pkg.go.dev/golang.org/x/sys@v0.0.0-20211124211545-fe61309f8881) | [`v0.0.0-20211205182925-97ca703d548d`](https://pkg.go.dev/golang.org/x/sys@v0.0.0-20211205182925-97ca703d548d)
[golang.org/x/text](https://pkg.go.dev/golang.org/x/text) | unchanged | [`v0.3.7`](https://pkg.go.dev/golang.org/x/text@v0.3.7) | [`v0.3.7`](https://pkg.go.dev/golang.org/x/text@v0.3.7)
[google.golang.org/protobuf](https://pkg.go.dev/google.golang.org/protobuf) | **minor upgrade** | [`v1.25.0`](https://pkg.go.dev/google.golang.org/protobuf@v1.25.0) | [`v1.27.1`](https://pkg.go.dev/google.golang.org/protobuf@v1.27.1)
[gopkg.in/DATA-DOG/go-sqlmock.v1](https://pkg.go.dev/gopkg.in/DATA-DOG/go-sqlmock.v1) | unchanged | [`v1.3.0`](https://pkg.go.dev/gopkg.in/DATA-DOG/go-sqlmock.v1@v1.3.0) | [`v1.3.0`](https://pkg.go.dev/gopkg.in/DATA-DOG/go-sqlmock.v1@v1.3.0)
[gopkg.in/square/go-jose.v2](https://pkg.go.dev/gopkg.in/square/go-jose.v2) | **minor upgrade** | [`v2.3.1`](https://pkg.go.dev/gopkg.in/square/go-jose.v2@v2.3.1) | [`v2.5.1`](https://pkg.go.dev/gopkg.in/square/go-jose.v2@v2.5.1)
[gopkg.in/tomb.v1](https://pkg.go.dev/gopkg.in/tomb.v1) | unchanged | [`v1.0.0-20141024135613-dd632973f1e7`](https://pkg.go.dev/gopkg.in/tomb.v1@v1.0.0-20141024135613-dd632973f1e7) | [`v1.0.0-20141024135613-dd632973f1e7`](https://pkg.go.dev/gopkg.in/tomb.v1@v1.0.0-20141024135613-dd632973f1e7)
[gopkg.in/yaml.v2](https://pkg.go.dev/gopkg.in/yaml.v2) | **minor upgrade** | [`v2.2.8`](https://pkg.go.dev/gopkg.in/yaml.v2@v2.2.8) | [`v2.4.0`](https://pkg.go.dev/gopkg.in/yaml.v2@v2.4.0)
[go.uber.org/atomic](https://pkg.go.dev/go.uber.org/atomic) | **new dependency** | - | [`v1.6.0`](https://pkg.go.dev/go.uber.org/atomic@v1.6.0)
### Major upgrades
Note that, other than [github.com/golang/protobuf](https://pkg.go.dev/github.com/golang/protobuf), there are no major dependency version upgrades in this PR. The following dependencies have new versions we could upgrade to in a later PR:
Package | New module path
------- | ---------------
[github.com/cenkalti/backoff@`v2.2.1+incompatible`](https://pkg.go.dev/github.com/cenkalti/backoff@v2.2.1+incompatible) | [github.com/cenkalti/backoff/v4](https://pkg.go.dev/github.com/cenkalti/backoff/v4)
[github.com/dgrijalva/jwt-go@`v3.2.1-0.20190620180102-5e25c22bd5d6+incompatible`](https://pkg.go.dev/github.com/dgrijalva/jwt-go@v3.2.1-0.20190620180102-5e25c22bd5d6+incompatible) | [github.com/dgrijalva/jwt-go/v4](https://pkg.go.dev/github.com/dgrijalva/jwt-go/v4)
[github.com/go-acme/lego@`v2.7.2+incompatible`](https://pkg.go.dev/github.com/go-acme/lego@v2.7.2+incompatible) | [github.com/go-acme/lego/v4](https://pkg.go.dev/github.com/go-acme/lego/v4)
[github.com/golang/protobuf@`v1.5.2`](https://pkg.go.dev/github.com/golang/protobuf@v1.5.2) | [google.golang.org/protobuf](https://pkg.go.dev/google.golang.org/protobuf)
[github.com/go-ozzo/ozzo-validation@`v3.6.0+incompatible`](https://pkg.go.dev/github.com/go-ozzo/ozzo-validation@v3.6.0+incompatible) | [github.com/go-ozzo/ozzo-validation/v4](https://pkg.go.dev/github.com/go-ozzo/ozzo-validation/v4)
[github.com/influxdata/influxdb@`v1.9.5`](https://pkg.go.dev/github.com/influxdata/influxdb@v1.9.5) | [github.com/influxdata/influxdb/v2](https://pkg.go.dev/github.com/influxdata/influxdb/v2)
[github.com/onsi/ginkgo@`v1.16.5`](https://pkg.go.dev/github.com/onsi/ginkgo@v1.16.5) | [github.com/onsi/ginkgo/v2](https://pkg.go.dev/github.com/onsi/ginkgo/v2)
<!-- **^ Add meaningful description above** --><hr>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- Traffic Control Cache Config (T3C, formerly ORT)
- Traffic Control Health Client (tc-health-client)
- Traffic Control Client <!-- Please specify which (Python, Go, or Java) -->
- Traffic Monitor
- Traffic Ops
- Traffic Stats
- Grove
- CDN in a Box - Enroller
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
Run tests
## PR submission checklist
- [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [ ] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #6407: Minor upgrade of Go dependencies
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #6407:
URL: https://github.com/apache/trafficcontrol/pull/6407#discussion_r765041472
##########
File path: lib/go-tc/statuses.go
##########
@@ -65,7 +65,7 @@ type Status struct {
// StatusNullable is a nullable single Status response for Update and Create to
// depict what changed.
type StatusNullable struct {
- Description *string `json:"description"`
+ Description *string `json:"description" db:"description"`
Review comment:
Yes, this was necessary. Without it, the v4, v3, and v2 API tests failed with
```go
--- FAIL: TestStatuses (0.30s)
statuses_test.go:210: results do not match actual: OFFLINE, expected: new description
```
The reason is linked in the commit message of f3d809c087:
> Remove null Status description workaround from apache#3148 now that jmoiron/sqlx#429 is merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #6407: Minor upgrade of Go dependencies
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #6407:
URL: https://github.com/apache/trafficcontrol/pull/6407#discussion_r765033460
##########
File path: lib/go-tc/statuses.go
##########
@@ -65,7 +65,7 @@ type Status struct {
// StatusNullable is a nullable single Status response for Update and Create to
// depict what changed.
type StatusNullable struct {
- Description *string `json:"description"`
+ Description *string `json:"description" db:"description"`
Review comment:
Were these changes to Statuses and their handler(s) in TO necessary consequences of upgrading dependencies? Or just something you did because you noticed it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 merged pull request #6407: Minor upgrade of Go dependencies
Posted by GitBox <gi...@apache.org>.
ocket8888 merged pull request #6407:
URL: https://github.com/apache/trafficcontrol/pull/6407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #6407: Minor upgrade of Go dependencies
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on pull request #6407:
URL: https://github.com/apache/trafficcontrol/pull/6407#issuecomment-986872864
Your columns headings look a little messed up in that first table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on pull request #6407: Minor upgrade of Go dependencies
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on pull request #6407:
URL: https://github.com/apache/trafficcontrol/pull/6407#issuecomment-986902015
Thanks, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org