You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by sanju1010 <gi...@git.apache.org> on 2015/12/03 11:57:25 UTC
[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
GitHub user sanju1010 opened a pull request:
https://github.com/apache/cloudstack/pull/1156
Fixed issues with test_vpc_vpn script
There are few issues with this test file. Please refer to JIRA Ticket https://issues.apache.org/jira/browse/CLOUDSTACK-9102 for details on the issues that have been fixed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sanju1010/cloudstack testvpn
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1156.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1156
----
commit 09409a7ac264e864c45146927b86229c8e67fbc8
Author: sanjeevn <sa...@citrix.com>
Date: 2015-12-03T10:26:08Z
Fixed issues with test_vpc_vpn script
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Posted by terbolous <gi...@git.apache.org>.
Github user terbolous commented on the pull request:
https://github.com/apache/cloudstack/pull/1156#issuecomment-162544664
@sanju1010 the error lies in the script due to different outputs. the test seems to use macchinina as template, which has the following output for ping:
# ping -c 1 -t 1 x.y.z.40
PING x.y.z.40 (x.y.z.40): 56 data bytes
--- x.y.z.40 ping statistics ---
1 packets transmitted, 0 packets received, 100% packet loss
The cut on line 711 picks field 6, which is 'received' and not 0.
a regular debian derivate has the following output:
--- x.y.z.40 ping statistics ---
1 packets transmitted, 0 received, +1 errors, 100% packet loss, time 0ms
where your cut would match '+1' and work.
conclusion; either change the template or change the cut
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Posted by Sanjeev N <sa...@apache.org>.
@michaelandersen, if we want to use that template it only works for kvm. So
either we have to skip the tests for other hypervisors or make the similar
templates for all other hypervisors as well.
On Tue, Dec 8, 2015 at 2:00 AM, michaelandersen <gi...@git.apache.org> wrote:
> Github user michaelandersen commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/1156#issuecomment-162651522
>
> So removed my last comment about field 7 to 6. We need to choose 1
> type of template os for both kvm and xen and base the test on that.
> @sanju1010: the machininna was already in there and working for kvm at
> least. would you mind making that template work?
>
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Posted by michaelandersen <gi...@git.apache.org>.
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/1156#issuecomment-162651522
So removed my last comment about field 7 to 6. We need to choose 1 type of template os for both kvm and xen and base the test on that. @sanju1010: the machininna was already in there and working for kvm at least. would you mind making that template work?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 closed the pull request at:
https://github.com/apache/cloudstack/pull/1156
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1156#issuecomment-197537506
Is this PR still relevant or did the changes in the other mentioned PRs make this PR outdated? If it is still active, please rebase the PR to get rid of merge conflicts so we can more easily test and merge this code. Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Posted by michaelandersen <gi...@git.apache.org>.
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/1156#issuecomment-162522267
ping @sanju1010
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Posted by Sanjeev N <sa...@apache.org>.
@Wilder, forgot to mention, either we should also add template for LXC or
skip the test for LXC.
On Thu, Dec 10, 2015 at 2:40 PM, Sanjeev N <sa...@apache.org> wrote:
> @wilder, I am ok with it. You can take it over.
> One comment, is ostype "Other PV (64-bit)" valid for other hypervisors
> otherthan Xenserver? And vmware template format should be in .ova
> The one you have mentioned in the Services class won't work.
>
> On Thu, Dec 10, 2015 at 2:03 PM, wilderrodrigues <gi...@git.apache.org>
> wrote:
>
>> Github user wilderrodrigues commented on the pull request:
>>
>> https://github.com/apache/cloudstack/pull/1156#issuecomment-163533177
>>
>> @sanju1010
>>
>> Are you still working on this? It's currently holding us a bit
>> because we need to do some work on this test as well. For instance, I want
>> to make it rVPC compliant.
>>
>> The point is: I'm trying to avoid conflicts when merging your changes
>> with my changes.
>>
>> If that would be fine, I would like to suggest I take it over. I
>> already applied some fixes to the test_internal_lb.py, which was suffering
>> from the same problem. See PR #1204
>>
>> Is that okay if I take it ove?
>>
>> Cheers,
>> Wilder
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and have
>> your
>> reply appear on GitHub as well. If your project does not have this feature
>> enabled and wishes so, or if the feature is enabled but not working,
>> please
>> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>> with INFRA.
>> ---
>>
>
>
Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Posted by Sanjeev N <sa...@apache.org>.
@wilder, I am ok with it. You can take it over.
One comment, is ostype "Other PV (64-bit)" valid for other hypervisors
otherthan Xenserver? And vmware template format should be in .ova
The one you have mentioned in the Services class won't work.
On Thu, Dec 10, 2015 at 2:03 PM, wilderrodrigues <gi...@git.apache.org> wrote:
> Github user wilderrodrigues commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/1156#issuecomment-163533177
>
> @sanju1010
>
> Are you still working on this? It's currently holding us a bit because
> we need to do some work on this test as well. For instance, I want to make
> it rVPC compliant.
>
> The point is: I'm trying to avoid conflicts when merging your changes
> with my changes.
>
> If that would be fine, I would like to suggest I take it over. I
> already applied some fixes to the test_internal_lb.py, which was suffering
> from the same problem. See PR #1204
>
> Is that okay if I take it ove?
>
> Cheers,
> Wilder
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1156#issuecomment-163533177
@sanju1010
Are you still working on this? It's currently holding us a bit because we need to do some work on this test as well. For instance, I want to make it rVPC compliant.
The point is: I'm trying to avoid conflicts when merging your changes with my changes.
If that would be fine, I would like to suggest I take it over. I already applied some fixes to the test_internal_lb.py, which was suffering from the same problem. See PR #1204
Is that okay if I take it ove?
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1156#issuecomment-162342696
@sanju1010 Thanks for the PR. Can you make it PEP8 compliant again please?
Most tests seem to create the offering the test needs. Isn't that a better idea?
I will run your version of the test. The previous one always succeeds for me, but I agree with the hypervisor specific part. That should be generic.
Will run it and report back.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Posted by michaelandersen <gi...@git.apache.org>.
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/1156#issuecomment-166835953
Hi @sanju1010, @wilderrodrigues asked me to extend the test_vpc_vpn script and in the proces i added the other hypervisors.
https://github.com/apache/cloudstack/pull/1276
Could you review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1156#issuecomment-162535442
Doesn't work for me either:
```
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn | Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : EXCEPTION ===
ERROR
```
The original one works:
```
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn | Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 2 tests in 1054.998s
OK
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Posted by Sanjeev N <sa...@apache.org>.
@terbolour, as per the previous logic in the test, it will register
xenserver template for any hypervisor other than kvm and vm deployment
fails for other hypervisors like vmware,hyper-v and lxc.
So I was asking how we should handle this.
On Tue, Dec 8, 2015 at 12:44 PM, terbolous <gi...@git.apache.org> wrote:
> Github user terbolous commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/1156#issuecomment-162797528
>
> @sanju1010 it works for XenServer as well atleast, haven't tried
> VMware. But you'll have to change your script to adjust to the different
> output
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Posted by terbolous <gi...@git.apache.org>.
Github user terbolous commented on the pull request:
https://github.com/apache/cloudstack/pull/1156#issuecomment-162797528
@sanju1010 it works for XenServer as well atleast, haven't tried VMware. But you'll have to change your script to adjust to the different output
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Posted by Sanjeev N <sa...@apache.org>.
Thanks @michaelandersen, I will take those templates and make the test
generic.
On Tue, Dec 8, 2015 at 3:35 PM, michaelandersen <gi...@git.apache.org> wrote:
> Github user michaelandersen commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/1156#issuecomment-162837936
>
> Gotcha. We could add templates for the other hypervisors (vmware and
> hyperv) from http://dl.openvm.eu/cloudstack/macchinina/x86_64/
>
> And remove the default_hypervisor variable and replace it for a
> dynamic template selection based on the nosetests hypervisor parameter.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Posted by michaelandersen <gi...@git.apache.org>.
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/1156#issuecomment-162837936
Gotcha. We could add templates for the other hypervisors (vmware and hyperv) from http://dl.openvm.eu/cloudstack/macchinina/x86_64/
And remove the default_hypervisor variable and replace it for a dynamic template selection based on the nosetests hypervisor parameter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1156#issuecomment-161599503
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 169.692s
OK
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : FAILED ===
FAIL
======================================================================
FAIL: Test VPN in VPC
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\CCPRepo\internal-cloudstack\test\integration\smoke\test_vpc_vpn.py", line 695, in test_vpc_site2site_vpn
self.assert_(int(packet_loss) == 0, "Ping did not succeed")
AssertionError: Ping did not succeed
-------------------- >> begin captured stdout << ---------------------
=== TestName: test_vpc_site2site_vpn | Status : FAILED ===
The second test failure is not related to these changes. It is something to do with the connectivity issues between the vms.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1156#issuecomment-162546287
:-1: Tests are failing, we need to fix it before we consider a merge, sorry.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1156#issuecomment-197701355
@swill, PR #1276 outdated this PR. So closing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Posted by michaelandersen <gi...@git.apache.org>.
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/1156#issuecomment-162520027
Just tested this on 4.6.1-SNAPSHOT with the command:
```
nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone1-xen1.cfg -a tags=advanced,required_hardware=true /tmp/test_vpc_vpn.py
```
and it failed:
```
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn | Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : EXCEPTION ===
ERROR
======================================================================
ERROR: Test VPN in VPC
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/test_vpc_vpn.py", line 712, in test_vpc_site2site_vpn
self.assert_(int(packet_loss) == 0, "Ping did not succeed")
ValueError: invalid literal for int() with base 10: 'received,'
-------------------- >> begin captured stdout << ---------------------
=== TestName: test_vpc_site2site_vpn | Status : EXCEPTION ===
--------------------- >> end captured stdout << ----------------------
```
I'm pretty sure this has to do with: https://github.com/sanju1010/cloudstack/blob/09409a7ac264e864c45146927b86229c8e67fbc8/test/integration/smoke/test_vpc_vpn.py/#L711
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1156#issuecomment-162539384
Hi Remi,
As I mentioned in my PR the second test failure is related to connectivity
issues between the vms part of s2s vpn. It is not because of my changes.
Thanks,
Sanjeev
On Dec 7, 2015 7:48 PM, "Remi Bergsma" <no...@github.com> wrote:
> Doesn't work for me either:
>
> Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn | Status : SUCCESS ===
> ok
> Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : EXCEPTION ===
> ERROR
>
> The original one works:
>
> Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn | Status : SUCCESS ===
> ok
> Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 2 tests in 1054.998s
>
> OK
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cloudstack/pull/1156#issuecomment-162535442>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script
Posted by michaelandersen <gi...@git.apache.org>.
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/1156#issuecomment-162545461
Hi Sanju,
Isn't it the point of the test to verify this exact connectivity?
But I any case I don't believe connectivity is the reason this test is
failing. I changed the -f option on line 711 back to field 7 and the test
passes now.
Please refactor that line and try again.
Best regards, Michael
On Monday, 7 December 2015, sanju1010 <no...@github.com> wrote:
> Hi Remi,
>
> As I mentioned in my PR the second test failure is related to connectivity
> issues between the vms part of s2s vpn. It is not because of my changes.
>
> Thanks,
> Sanjeev
> On Dec 7, 2015 7:48 PM, "Remi Bergsma" <notifications@github.com
> <javascript:_e(%7B%7D,'cvml','notifications@github.com');>> wrote:
>
> > Doesn't work for me either:
> >
> > Test Remote Access VPN in VPC ... === TestName:
> test_vpc_remote_access_vpn | Status : SUCCESS ===
> > ok
> > Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status :
> EXCEPTION ===
> > ERROR
> >
> > The original one works:
> >
> > Test Remote Access VPN in VPC ... === TestName:
> test_vpc_remote_access_vpn | Status : SUCCESS ===
> > ok
> > Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status :
> SUCCESS ===
> > ok
> >
> > ----------------------------------------------------------------------
> > Ran 2 tests in 1054.998s
> >
> > OK
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <https://github.com/apache/cloudstack/pull/1156#issuecomment-162535442>.
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cloudstack/pull/1156#issuecomment-162539384>.
>
--
Michael Andersen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---