[GitHub] [accumulo] keith-turner commented on a change in pull request #1595: Update manual array to collections copy method.

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #1595:
URL: https://github.com/apache/accumulo/pull/1595#discussion_r414758175



##########
File path: core/src/main/java/org/apache/accumulo/core/clientImpl/mapreduce/lib/InputConfigurator.java
##########
@@ -360,9 +361,7 @@ public static void fetchColumns(Class<?> implementingClass, Configuration conf,
     List<String> serialized = new ArrayList<>();
     if (confValue != null) {
       // Split and include any trailing empty strings to allow empty column families
-      for (String val : confValue.split(",", -1)) {
-        serialized.add(val);
-      }
+      Collections.addAll(serialized, confValue.split(",", -1));

Review comment:
       This is a handy method, I didn't know it existed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org