[GitHub] ccollins476ad commented on issue #56: Go ble2

[GitBox <gi...@apache.org>]

ccollins476ad commented on issue #56: Go ble2
URL: https://github.com/apache/mynewt-newtmgr/pull/56#issuecomment-359127774
 
 
   Thanks, Jacob.  I think there are a few issues with newtmgr that this PR exposes.
   
   First, the `README.md` file contains some out of date information.  Every external dependency should be vendored, including go-ble.  The old language in the README.md file about manually using `go get` to get the BLE library was put there due to a bug in Go which has apparently since been fixed.  The bug led to build errors when a vendored package contained OS-specific code.  As I said, this bug has seemingly been fixed, so there no need for the workaround.
   
   In light of the above, the `go-ble` package should be vendored.  Newtmgr uses the `dep` tool for vendoring (https://github.com/golang/dep).  I believe `dep ensure -update` will do the trick.  This will update all the external dependencies, not just go-ble.
   
   Vendoring is confusing, so we should probably add instructions to the readme file (not as part of this PR, though).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services