[jira] [Commented] (LUCENE-4963) Deprecate broken TokenFilter constructors

["Uwe Schindler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-4963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643617#comment-13643617 ] 

Uwe Schindler commented on LUCENE-4963:
---------------------------------------

Hi,
+1 to deprecate the constuctors taking those arguments and make sure the alternatives already implement the correct behaviour.
Unfortunately we may not be able to completely remove that code in 5.x (we can remove the ctors, yes), because matchVersion sometimes implies the wrong behaviour. We nuked almost all of them, we should just check this.
                
> Deprecate broken TokenFilter constructors
> -----------------------------------------
>
>                 Key: LUCENE-4963
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4963
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>             Fix For: 4.4
>
>
> We have some TokenFilters which are only broken with specific options. This includes:
>  * TrimFilter when updateOffsets=true
>  * StopFilter, JapanesePartOfSpeechStopFilter, KeepWordFilter, LengthFilter, TypeTokenFilter when enablePositionIncrements=false
> I think we should deprecate these behaviors in 4.4 and remove them in trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org