You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2021/05/13 13:04:50 UTC

[commons-io] branch master updated: Don't shadow setup method name in JUnit because the super's version is not called.

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git


The following commit(s) were added to refs/heads/master by this push:
     new 18d7310  Don't shadow setup method name in JUnit because the super's version is not called.
18d7310 is described below

commit 18d7310c05beb4af066a4493991199b129407060
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu May 13 09:04:46 2021 -0400

    Don't shadow setup method name in JUnit because the super's version is
    not called.
---
 .../org/apache/commons/io/serialization/MoreComplexObjectTest.java     | 3 +--
 .../commons/io/serialization/ValidatingObjectInputStreamTest.java      | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/test/java/org/apache/commons/io/serialization/MoreComplexObjectTest.java b/src/test/java/org/apache/commons/io/serialization/MoreComplexObjectTest.java
index 02f1d80..b63bf83 100644
--- a/src/test/java/org/apache/commons/io/serialization/MoreComplexObjectTest.java
+++ b/src/test/java/org/apache/commons/io/serialization/MoreComplexObjectTest.java
@@ -41,9 +41,8 @@ public class MoreComplexObjectTest extends ClosingBase {
     private InputStream inputStream;
     private MoreComplexObject original;
 
-    @Override
     @BeforeEach
-    public void setup() throws IOException {
+    public void setupMoreComplexObject() throws IOException {
         original = new MoreComplexObject();
         final ByteArrayOutputStream bos = willClose(new ByteArrayOutputStream());
         final ObjectOutputStream oos = willClose(new ObjectOutputStream(bos));
diff --git a/src/test/java/org/apache/commons/io/serialization/ValidatingObjectInputStreamTest.java b/src/test/java/org/apache/commons/io/serialization/ValidatingObjectInputStreamTest.java
index 2b7cfe3..6d1bede 100644
--- a/src/test/java/org/apache/commons/io/serialization/ValidatingObjectInputStreamTest.java
+++ b/src/test/java/org/apache/commons/io/serialization/ValidatingObjectInputStreamTest.java
@@ -42,9 +42,8 @@ public class ValidatingObjectInputStreamTest extends ClosingBase {
 
     private static final ClassNameMatcher ALWAYS_TRUE = className -> true;
 
-    @Override
     @BeforeEach
-    public void setup() throws IOException {
+    public void setupMockSerializedClass() throws IOException {
         testObject = new MockSerializedClass(UUID.randomUUID().toString());
         final ByteArrayOutputStream bos = willClose(new ByteArrayOutputStream());
         final ObjectOutputStream oos = willClose(new ObjectOutputStream(bos));