You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@devlake.apache.org by "daniel-hutao (via GitHub)" <gi...@apache.org> on 2023/04/17 08:16:20 UTC
[GitHub] [incubator-devlake-helm-chart] daniel-hutao opened a new pull request, #113: feat: add TZ option and remote timezone option
daniel-hutao opened a new pull request, #113:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/113
Add TZ option and remote timezone option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] daniel-hutao commented on a diff in pull request #113: feat: add TZ option and remote timezone option
Posted by "daniel-hutao (via GitHub)" <gi...@apache.org>.
daniel-hutao commented on code in PR #113:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/113#discussion_r1169625005
##########
HelmSetup.md:
##########
@@ -112,50 +112,50 @@ After deployed, visit devlake: https://devlake-0.example.com:8443, and grafana a
Some useful parameters for the chart, you could also check them in values.yaml
-| Parameter | Description | Default |
-| ----------------------------- | -------------------------------------------------------- | -------------------------- |
-| replicaCount | Replica Count for devlake, currently not used | 1 |
-| imageTag | The version tag for all images | see Values.yaml |
-| mysql.useExternal | If use external mysql server, set true | false |
-| mysql.externalServer | External mysql server address | 127.0.0.1 |
-| mysql.externalPort | External mysql server port | 3306 |
-| mysql.username | username for mysql | merico |
-| mysql.password | password for mysql | merico |
-| mysql.database | database for mysql | lake |
-| mysql.rootPassword | root password for mysql | admin |
-| mysql.storage.class | storage class for mysql's volume | "" |
-| mysql.storage.size | volume size for mysql's data | 5Gi |
-| mysql.image.repository | repository for mysql's image | mysql |
-| mysql.image.tag | image tag for mysql's image | 8 |
-| mysql.image.pullPolicy | pullPolicy for mysql's image | IfNotPresent |
-| grafana.image.repository | repository for grafana's image | apache/devlake-dashboard |
-| grafana.image.pullPolicy | pullPolicy for grafana's image | Always |
-| grafana.useExternal | If use external grafana server | false |
-| grafana.externalUrl | external grafana server if use external | "" |
-| lake.storage.class | storage class for lake's volume | "" |
-| lake.storage.size | volume size for lake's data | 100Mi |
-| lake.image.repository | repository for lake's image | apache/devlake |
-| lake.image.pullPolicy | pullPolicy for lake's image | Always |
-| lake.loggingDir | log dir for the lake server | /app/logs |
-| lake.loggingLevel | log level for the lake server | info |
-| lake.dotenv | initial configurations for injecting to lake's .env | see Values.yaml |
-| ui.image.repository | repository for ui's image | apache/devlake-config-ui |
-| ui.image.pullPolicy | pullPolicy for ui's image | Always |
-| ui.basicAuth.enabled | If the basic auth in ui is enabled | false |
-| ui.basicAuth.user | The user name for the basic auth | "admin" |
-| ui.basicAuth.password | The password for the basic auth | "admin" |
-| service.type | Service type for exposed service | NodePort |
-| service.uiPort | Node port for config ui | 32001 |
-| service.ingress.enabled | If enable ingress | false |
-| service.ingress.enableHttps | If enable https | false |
-| service.ingress.className | Name for ingressClass. leave empty for using default | "" |
-| service.ingress.hostname | The hostname/domainname for ingress | localhost |
-| service.ingress.prefix | The prefix for endpoints, currently not used | / |
-| service.ingress.tlsSecretName | The secret name for tls's certificate for https | "" |
-| service.ingress.httpPort | The http port for ingress | 80 |
-| service.ingress.httpsPort | The https port for ingress | 443 |
-| option.localtime | The hostpath for mount as /etc/localtime | /etc/localtime |
-| option.database | The database type, valids: mysql | mysql |
+| Parameter | Description | Default |
+|-------------------------------|------------------------------------------------------|--------------------------|
+| replicaCount | Replica Count for devlake, currently not used | 1 |
+| imageTag | The version tag for all images | see Values.yaml |
+| mysql.useExternal | If use external mysql server, set true | false |
+| mysql.externalServer | External mysql server address | 127.0.0.1 |
+| mysql.externalPort | External mysql server port | 3306 |
+| mysql.username | username for mysql | merico |
+| mysql.password | password for mysql | merico |
+| mysql.database | database for mysql | lake |
+| mysql.rootPassword | root password for mysql | admin |
+| mysql.storage.class | storage class for mysql's volume | "" |
+| mysql.storage.size | volume size for mysql's data | 5Gi |
+| mysql.image.repository | repository for mysql's image | mysql |
+| mysql.image.tag | image tag for mysql's image | 8 |
+| mysql.image.pullPolicy | pullPolicy for mysql's image | IfNotPresent |
+| grafana.image.repository | repository for grafana's image | apache/devlake-dashboard |
+| grafana.image.pullPolicy | pullPolicy for grafana's image | Always |
+| grafana.useExternal | If use external grafana server | false |
+| grafana.externalUrl | external grafana server if use external | "" |
+| lake.storage.class | storage class for lake's volume | "" |
+| lake.storage.size | volume size for lake's data | 100Mi |
+| lake.image.repository | repository for lake's image | apache/devlake |
+| lake.image.pullPolicy | pullPolicy for lake's image | Always |
+| lake.loggingDir | log dir for the lake server | /app/logs |
+| lake.loggingLevel | log level for the lake server | info |
+| lake.dotenv | initial configurations for injecting to lake's .env | see Values.yaml |
+| ui.image.repository | repository for ui's image | apache/devlake-config-ui |
+| ui.image.pullPolicy | pullPolicy for ui's image | Always |
+| ui.basicAuth.enabled | If the basic auth in ui is enabled | false |
+| ui.basicAuth.user | The user name for the basic auth | "admin" |
+| ui.basicAuth.password | The password for the basic auth | "admin" |
+| service.type | Service type for exposed service | NodePort |
+| service.uiPort | Node port for config ui | 32001 |
+| service.ingress.enabled | If enable ingress | false |
+| service.ingress.enableHttps | If enable https | false |
+| service.ingress.className | Name for ingressClass. leave empty for using default | "" |
+| service.ingress.hostname | The hostname/domainname for ingress | localhost |
+| service.ingress.prefix | The prefix for endpoints, currently not used | / |
+| service.ingress.tlsSecretName | The secret name for tls's certificate for https | "" |
+| service.ingress.httpPort | The http port for ingress | 80 |
+| service.ingress.httpsPort | The https port for ingress | 443 |
+| option.TZ | The timezone | Asia/Shanghai |
Review Comment:
@klesh @warren830 What's your opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] klesh commented on pull request #113: feat: add TZ option and remote timezone option
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on PR #113:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/113#issuecomment-1625370790
solved by #151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] matrixji commented on a diff in pull request #113: feat: add TZ option and remote timezone option
Posted by "matrixji (via GitHub)" <gi...@apache.org>.
matrixji commented on code in PR #113:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/113#discussion_r1168639201
##########
HelmSetup.md:
##########
@@ -112,50 +112,50 @@ After deployed, visit devlake: https://devlake-0.example.com:8443, and grafana a
Some useful parameters for the chart, you could also check them in values.yaml
-| Parameter | Description | Default |
-| ----------------------------- | -------------------------------------------------------- | -------------------------- |
-| replicaCount | Replica Count for devlake, currently not used | 1 |
-| imageTag | The version tag for all images | see Values.yaml |
-| mysql.useExternal | If use external mysql server, set true | false |
-| mysql.externalServer | External mysql server address | 127.0.0.1 |
-| mysql.externalPort | External mysql server port | 3306 |
-| mysql.username | username for mysql | merico |
-| mysql.password | password for mysql | merico |
-| mysql.database | database for mysql | lake |
-| mysql.rootPassword | root password for mysql | admin |
-| mysql.storage.class | storage class for mysql's volume | "" |
-| mysql.storage.size | volume size for mysql's data | 5Gi |
-| mysql.image.repository | repository for mysql's image | mysql |
-| mysql.image.tag | image tag for mysql's image | 8 |
-| mysql.image.pullPolicy | pullPolicy for mysql's image | IfNotPresent |
-| grafana.image.repository | repository for grafana's image | apache/devlake-dashboard |
-| grafana.image.pullPolicy | pullPolicy for grafana's image | Always |
-| grafana.useExternal | If use external grafana server | false |
-| grafana.externalUrl | external grafana server if use external | "" |
-| lake.storage.class | storage class for lake's volume | "" |
-| lake.storage.size | volume size for lake's data | 100Mi |
-| lake.image.repository | repository for lake's image | apache/devlake |
-| lake.image.pullPolicy | pullPolicy for lake's image | Always |
-| lake.loggingDir | log dir for the lake server | /app/logs |
-| lake.loggingLevel | log level for the lake server | info |
-| lake.dotenv | initial configurations for injecting to lake's .env | see Values.yaml |
-| ui.image.repository | repository for ui's image | apache/devlake-config-ui |
-| ui.image.pullPolicy | pullPolicy for ui's image | Always |
-| ui.basicAuth.enabled | If the basic auth in ui is enabled | false |
-| ui.basicAuth.user | The user name for the basic auth | "admin" |
-| ui.basicAuth.password | The password for the basic auth | "admin" |
-| service.type | Service type for exposed service | NodePort |
-| service.uiPort | Node port for config ui | 32001 |
-| service.ingress.enabled | If enable ingress | false |
-| service.ingress.enableHttps | If enable https | false |
-| service.ingress.className | Name for ingressClass. leave empty for using default | "" |
-| service.ingress.hostname | The hostname/domainname for ingress | localhost |
-| service.ingress.prefix | The prefix for endpoints, currently not used | / |
-| service.ingress.tlsSecretName | The secret name for tls's certificate for https | "" |
-| service.ingress.httpPort | The http port for ingress | 80 |
-| service.ingress.httpsPort | The https port for ingress | 443 |
-| option.localtime | The hostpath for mount as /etc/localtime | /etc/localtime |
-| option.database | The database type, valids: mysql | mysql |
+| Parameter | Description | Default |
+|-------------------------------|------------------------------------------------------|--------------------------|
+| replicaCount | Replica Count for devlake, currently not used | 1 |
+| imageTag | The version tag for all images | see Values.yaml |
+| mysql.useExternal | If use external mysql server, set true | false |
+| mysql.externalServer | External mysql server address | 127.0.0.1 |
+| mysql.externalPort | External mysql server port | 3306 |
+| mysql.username | username for mysql | merico |
+| mysql.password | password for mysql | merico |
+| mysql.database | database for mysql | lake |
+| mysql.rootPassword | root password for mysql | admin |
+| mysql.storage.class | storage class for mysql's volume | "" |
+| mysql.storage.size | volume size for mysql's data | 5Gi |
+| mysql.image.repository | repository for mysql's image | mysql |
+| mysql.image.tag | image tag for mysql's image | 8 |
+| mysql.image.pullPolicy | pullPolicy for mysql's image | IfNotPresent |
+| grafana.image.repository | repository for grafana's image | apache/devlake-dashboard |
+| grafana.image.pullPolicy | pullPolicy for grafana's image | Always |
+| grafana.useExternal | If use external grafana server | false |
+| grafana.externalUrl | external grafana server if use external | "" |
+| lake.storage.class | storage class for lake's volume | "" |
+| lake.storage.size | volume size for lake's data | 100Mi |
+| lake.image.repository | repository for lake's image | apache/devlake |
+| lake.image.pullPolicy | pullPolicy for lake's image | Always |
+| lake.loggingDir | log dir for the lake server | /app/logs |
+| lake.loggingLevel | log level for the lake server | info |
+| lake.dotenv | initial configurations for injecting to lake's .env | see Values.yaml |
+| ui.image.repository | repository for ui's image | apache/devlake-config-ui |
+| ui.image.pullPolicy | pullPolicy for ui's image | Always |
+| ui.basicAuth.enabled | If the basic auth in ui is enabled | false |
+| ui.basicAuth.user | The user name for the basic auth | "admin" |
+| ui.basicAuth.password | The password for the basic auth | "admin" |
+| service.type | Service type for exposed service | NodePort |
+| service.uiPort | Node port for config ui | 32001 |
+| service.ingress.enabled | If enable ingress | false |
+| service.ingress.enableHttps | If enable https | false |
+| service.ingress.className | Name for ingressClass. leave empty for using default | "" |
+| service.ingress.hostname | The hostname/domainname for ingress | localhost |
+| service.ingress.prefix | The prefix for endpoints, currently not used | / |
+| service.ingress.tlsSecretName | The secret name for tls's certificate for https | "" |
+| service.ingress.httpPort | The http port for ingress | 80 |
+| service.ingress.httpsPort | The https port for ingress | 443 |
+| option.TZ | The timezone | Asia/Shanghai |
Review Comment:
That's great. just one discussion: do we need to use UTC as our default timezone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] klesh commented on a diff in pull request #113: feat: add TZ option and remote timezone option
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on code in PR #113:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/113#discussion_r1169714489
##########
HelmSetup.md:
##########
@@ -112,50 +112,50 @@ After deployed, visit devlake: https://devlake-0.example.com:8443, and grafana a
Some useful parameters for the chart, you could also check them in values.yaml
-| Parameter | Description | Default |
-| ----------------------------- | -------------------------------------------------------- | -------------------------- |
-| replicaCount | Replica Count for devlake, currently not used | 1 |
-| imageTag | The version tag for all images | see Values.yaml |
-| mysql.useExternal | If use external mysql server, set true | false |
-| mysql.externalServer | External mysql server address | 127.0.0.1 |
-| mysql.externalPort | External mysql server port | 3306 |
-| mysql.username | username for mysql | merico |
-| mysql.password | password for mysql | merico |
-| mysql.database | database for mysql | lake |
-| mysql.rootPassword | root password for mysql | admin |
-| mysql.storage.class | storage class for mysql's volume | "" |
-| mysql.storage.size | volume size for mysql's data | 5Gi |
-| mysql.image.repository | repository for mysql's image | mysql |
-| mysql.image.tag | image tag for mysql's image | 8 |
-| mysql.image.pullPolicy | pullPolicy for mysql's image | IfNotPresent |
-| grafana.image.repository | repository for grafana's image | apache/devlake-dashboard |
-| grafana.image.pullPolicy | pullPolicy for grafana's image | Always |
-| grafana.useExternal | If use external grafana server | false |
-| grafana.externalUrl | external grafana server if use external | "" |
-| lake.storage.class | storage class for lake's volume | "" |
-| lake.storage.size | volume size for lake's data | 100Mi |
-| lake.image.repository | repository for lake's image | apache/devlake |
-| lake.image.pullPolicy | pullPolicy for lake's image | Always |
-| lake.loggingDir | log dir for the lake server | /app/logs |
-| lake.loggingLevel | log level for the lake server | info |
-| lake.dotenv | initial configurations for injecting to lake's .env | see Values.yaml |
-| ui.image.repository | repository for ui's image | apache/devlake-config-ui |
-| ui.image.pullPolicy | pullPolicy for ui's image | Always |
-| ui.basicAuth.enabled | If the basic auth in ui is enabled | false |
-| ui.basicAuth.user | The user name for the basic auth | "admin" |
-| ui.basicAuth.password | The password for the basic auth | "admin" |
-| service.type | Service type for exposed service | NodePort |
-| service.uiPort | Node port for config ui | 32001 |
-| service.ingress.enabled | If enable ingress | false |
-| service.ingress.enableHttps | If enable https | false |
-| service.ingress.className | Name for ingressClass. leave empty for using default | "" |
-| service.ingress.hostname | The hostname/domainname for ingress | localhost |
-| service.ingress.prefix | The prefix for endpoints, currently not used | / |
-| service.ingress.tlsSecretName | The secret name for tls's certificate for https | "" |
-| service.ingress.httpPort | The http port for ingress | 80 |
-| service.ingress.httpsPort | The https port for ingress | 443 |
-| option.localtime | The hostpath for mount as /etc/localtime | /etc/localtime |
-| option.database | The database type, valids: mysql | mysql |
+| Parameter | Description | Default |
+|-------------------------------|------------------------------------------------------|--------------------------|
+| replicaCount | Replica Count for devlake, currently not used | 1 |
+| imageTag | The version tag for all images | see Values.yaml |
+| mysql.useExternal | If use external mysql server, set true | false |
+| mysql.externalServer | External mysql server address | 127.0.0.1 |
+| mysql.externalPort | External mysql server port | 3306 |
+| mysql.username | username for mysql | merico |
+| mysql.password | password for mysql | merico |
+| mysql.database | database for mysql | lake |
+| mysql.rootPassword | root password for mysql | admin |
+| mysql.storage.class | storage class for mysql's volume | "" |
+| mysql.storage.size | volume size for mysql's data | 5Gi |
+| mysql.image.repository | repository for mysql's image | mysql |
+| mysql.image.tag | image tag for mysql's image | 8 |
+| mysql.image.pullPolicy | pullPolicy for mysql's image | IfNotPresent |
+| grafana.image.repository | repository for grafana's image | apache/devlake-dashboard |
+| grafana.image.pullPolicy | pullPolicy for grafana's image | Always |
+| grafana.useExternal | If use external grafana server | false |
+| grafana.externalUrl | external grafana server if use external | "" |
+| lake.storage.class | storage class for lake's volume | "" |
+| lake.storage.size | volume size for lake's data | 100Mi |
+| lake.image.repository | repository for lake's image | apache/devlake |
+| lake.image.pullPolicy | pullPolicy for lake's image | Always |
+| lake.loggingDir | log dir for the lake server | /app/logs |
+| lake.loggingLevel | log level for the lake server | info |
+| lake.dotenv | initial configurations for injecting to lake's .env | see Values.yaml |
+| ui.image.repository | repository for ui's image | apache/devlake-config-ui |
+| ui.image.pullPolicy | pullPolicy for ui's image | Always |
+| ui.basicAuth.enabled | If the basic auth in ui is enabled | false |
+| ui.basicAuth.user | The user name for the basic auth | "admin" |
+| ui.basicAuth.password | The password for the basic auth | "admin" |
+| service.type | Service type for exposed service | NodePort |
+| service.uiPort | Node port for config ui | 32001 |
+| service.ingress.enabled | If enable ingress | false |
+| service.ingress.enableHttps | If enable https | false |
+| service.ingress.className | Name for ingressClass. leave empty for using default | "" |
+| service.ingress.hostname | The hostname/domainname for ingress | localhost |
+| service.ingress.prefix | The prefix for endpoints, currently not used | / |
+| service.ingress.tlsSecretName | The secret name for tls's certificate for https | "" |
+| service.ingress.httpPort | The http port for ingress | 80 |
+| service.ingress.httpsPort | The https port for ingress | 443 |
+| option.TZ | The timezone | Asia/Shanghai |
Review Comment:
UTC has a special meaning for developers.
It would be better to choose a neutral timezone to make it clear that it should be set by users to their own timezone.
I suggest that we use `America/Cayman` as the placeholder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] klesh closed pull request #113: feat: add TZ option and remote timezone option
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh closed pull request #113: feat: add TZ option and remote timezone option
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org