You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/28 16:45:01 UTC

[GitHub] [arrow] MingyuZhong commented on pull request #8279: ARROW-10102: [C++] Refactor BasicDecimal128 Multiplication to use unsigned helper

MingyuZhong commented on pull request #8279:
URL: https://github.com/apache/arrow/pull/8279#issuecomment-700151910


   > We have 128-bit integer types in `arrow/util/int128_internal.h`, why not use them always?
   
   Because BasicDecimal128 cannot depend on boost per the comment at https://github.com/apache/arrow/blob/3d0a9d58b6fe29dcb208c3fa244c789449517988/cpp/src/arrow/util/basic_decimal.h#L41


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org