You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@issues.apache.org on 2011/01/07 15:23:19 UTC

[Bug 6531] New: clear_uridnsbl_skip_domain feature to allow admin override of default configuration

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6531

           Summary: clear_uridnsbl_skip_domain feature to allow admin
                    override of default configuration
           Product: Spamassassin
           Version: SVN Trunk (Latest Devel Version)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Rules
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: kmcgrail@pccc.com


Synopsis of Key Points below to open bug:

Discussion to increase uridsnbl domain skip list from approximately 200 to more
(as high as 500 domains) to reduce unnecessary uribl queries.  However,
concerns over the inability to administratively override this list on a per
installation basis led to a feature request as follows:

Alex Broens:
I'd welcome having uridnsbl_skip_domain as a switchable feature:
 enable_uridnsbl_skip_domain yes.
 or clear_uridnsbl_skip_domain
 same syntax as clear_internal_networks / clear_trusted_networks ...

Warren Togami:
How about we implement a clear_* parameter so this becomes a non-issue? In
reality it is counter-productive to actually use such an option, but if you
insist it must be possible...

Mark Martinec:
That's a good suggestion to keep everyone happy, and is fairly easy to
implement. Will do it.

Here is what I have in mind:

 =item clear_uridnsbl_skip_domain [domain1 domain2 ...]

 If no argument is given, then clears the entire list of domains declared
 by I<uridnsbl_skip_domain> configuration directives so far. Any subsequent
 I<uridnsbl_skip_domain> directives will start creating a new list of skip
 domains.

 When given a list of domains as arguments, only the specified domains
 are removed from the list of skipped domains.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6531] [review] clear_uridnsbl_skip_domain feature to allow admin override of default configuration

Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6531

--- Comment #4 from Mark Martinec <Ma...@ijs.si> 2011-01-10 20:05:22 UTC ---
> Is this patch intended for 3.3.x too?

I tentatively set the target to 3.4.0, but that can be changed if
there is sufficient interest.

> What is the voting for?

Well, eventually each nontrivial change needs voting. In case of a trunk
we use the commit-then-review, but eventually the time for a review/approval
comes, either by individual tickets, or perhaps by a broader agreement.

I labeled the ticket as "[review]" to make it more easily distinguishable
from the mass of the open tickets - with an intention to get at least
the more straightforward ones off the dashboard.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6531] [review] clear_uridnsbl_skip_domain feature to allow admin override of default configuration

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6531

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Mark Martinec <Ma...@ijs.si> 2011-05-06 13:37:20 UTC ---
branch 3.3:
  Bug 6531: clear_uridnsbl_skip_domain feature to allow admin override
  of default configuration
  Sending lib/Mail/SpamAssassin/Plugin/URIDNSBL.pm
Committed revision 1100210.

Assuming that it's alright, accepting votes as if they were for 3.3.

Closing.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6531] [review] clear_uridnsbl_skip_domain feature to allow admin override of default configuration

Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6531

--- Comment #5 from Warren Togami <wt...@gmail.com> 2011-01-11 01:56:57 UTC ---
I should have remembered CTR.  In any case, I don't think 3.3.x needs this
patch.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6531] [review] clear_uridnsbl_skip_domain feature to allow admin override of default configuration

Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6531

--- Comment #3 from Warren Togami <wt...@gmail.com> 2011-01-07 15:50:05 UTC ---
What is the voting for?  Is this patch intended for 3.3.x too?

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6531] [review] clear_uridnsbl_skip_domain feature to allow admin override of default configuration

Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6531

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|clear_uridnsbl_skip_domain  |[review]
                   |feature to allow admin      |clear_uridnsbl_skip_domain
                   |override of default         |feature to allow admin
                   |configuration               |override of default
                   |                            |configuration
  Status Whiteboard|                            |needs 1 vote

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6531] clear_uridnsbl_skip_domain feature to allow admin override of default configuration

Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6531

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P2                          |P3
   Target Milestone|Undefined                   |3.4.0

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6531] [review] clear_uridnsbl_skip_domain feature to allow admin override of default configuration

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6531

Warren Togami <wt...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.0                       |3.3.2

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6531] clear_uridnsbl_skip_domain feature to allow admin override of default configuration

Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6531

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kmcgrail@pccc.com

--- Comment #2 from Kevin A. McGrail <km...@pccc.com> 2011-01-07 09:50:24 UTC ---
(In reply to comment #1)
> Created an attachment (id=4838)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4838) [details]
> proposed patch to add the clear_uridnsbl_skip_domain directive
> 
> trunk:
>   Bug 6531: clear_uridnsbl_skip_domain feature to allow
>   admin override of default configuration
> Sending lib/Mail/SpamAssassin/Plugin/URIDNSBL.pm
> Committed revision 1056334.

+1 KAM

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6531] clear_uridnsbl_skip_domain feature to allow admin override of default configuration

Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6531

--- Comment #1 from Mark Martinec <Ma...@ijs.si> 2011-01-07 09:33:12 UTC ---
Created an attachment (id=4838)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4838)
proposed patch to add the clear_uridnsbl_skip_domain directive

trunk:
  Bug 6531: clear_uridnsbl_skip_domain feature to allow
  admin override of default configuration
Sending lib/Mail/SpamAssassin/Plugin/URIDNSBL.pm
Committed revision 1056334.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.