You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Krisztian Horvath <kr...@sequenceiq.com> on 2014/06/15 20:16:19 UTC
Review Request 22610: Ambari Shell improvements
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22610/
-----------------------------------------------------------
Review request for Ambari and Yusaku Sako.
Repository: ambari
Description
-------
There are a few new Ambari shell and client functionalities - this issue encapsulate them. To list a few of the enhancements:
installation flash/progress bar
tab completion for hostname/blueprint
service start/stop
auto assign for hosts to host group
exit on finish at cluster creation
command log name changed to ambari-log.ash instead of spring-log
new blueprints added - warmup - lambda-architecture
There is a new dependency introduced: jackson-mapper-asl
Diffs
-----
ambari-client/groovy-client/pom.xml 7e4860c
ambari-client/groovy-client/src/main/groovy/org/apache/ambari/groovy/client/AmbariClient.groovy 5b05c60
ambari-client/groovy-client/src/main/resources/blueprints/lambda-architecture PRE-CREATION
ambari-client/groovy-client/src/main/resources/blueprints/multi-node-hdfs-yarn 0630453
ambari-client/groovy-client/src/main/resources/blueprints/single-node-hdfs-yarn 1a7d302
ambari-client/groovy-client/src/main/resources/blueprints/warmup PRE-CREATION
ambari-client/groovy-client/src/test/groovy/com.sequenceiq.ambari.client/AmbariClientTest.groovy 77ad26a
ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AbstractAmbariClientTest.groovy PRE-CREATION
ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariBlueprintsTest.groovy PRE-CREATION
ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariClustersTest.groovy PRE-CREATION
ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariHostsTest.groovy PRE-CREATION
ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariServiceConfigurationTest.groovy PRE-CREATION
ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariServicesTest.groovy PRE-CREATION
ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariTasksTest.groovy PRE-CREATION
ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/TestResources.groovy PRE-CREATION
ambari-client/groovy-client/src/test/resources/clusterAll.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/clusters.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/host-components.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/hosts.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/no-blueprint.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/no-clusters.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/no-hosts.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/no-request-tasks.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/no-service-components-hdfs.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/no-services.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/request-tasks.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/service-components-hdfs.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/service-config.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/service-versions-multiple.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/service-versions.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/services.json aceed13
ambari-client/groovy-client/src/test/resources/versions/clusters.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/versions/service-config.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/versions/service-versions.json PRE-CREATION
ambari-project/pom.xml 0d32510
ambari-shell/pom.xml 6f78db5
ambari-shell/src/main/java/org/apache/ambari/shell/AmbariShell.java 02269a8
ambari-shell/src/main/java/org/apache/ambari/shell/commands/BasicCommands.java 8fd6c9f
ambari-shell/src/main/java/org/apache/ambari/shell/commands/BlueprintCommands.java 68ab343
ambari-shell/src/main/java/org/apache/ambari/shell/commands/ClusterCommands.java f3eba83
ambari-shell/src/main/java/org/apache/ambari/shell/commands/HostCommands.java bdcde53
ambari-shell/src/main/java/org/apache/ambari/shell/completion/Blueprint.java PRE-CREATION
ambari-shell/src/main/java/org/apache/ambari/shell/completion/Host.java PRE-CREATION
ambari-shell/src/main/java/org/apache/ambari/shell/configuration/ConverterConfiguration.java f68f384
ambari-shell/src/main/java/org/apache/ambari/shell/configuration/ShellConfiguration.java 4c36cc9
ambari-shell/src/main/java/org/apache/ambari/shell/converter/BlueprintConverter.java PRE-CREATION
ambari-shell/src/main/java/org/apache/ambari/shell/converter/HostConverter.java PRE-CREATION
ambari-shell/src/main/java/org/apache/ambari/shell/customization/AmbariHistory.java PRE-CREATION
ambari-shell/src/main/java/org/apache/ambari/shell/flash/AbstractFlash.java PRE-CREATION
ambari-shell/src/main/java/org/apache/ambari/shell/flash/FlashService.java PRE-CREATION
ambari-shell/src/main/java/org/apache/ambari/shell/flash/FlashType.java PRE-CREATION
ambari-shell/src/main/java/org/apache/ambari/shell/flash/InstallProgress.java PRE-CREATION
ambari-shell/src/test/java/org/apache/ambari/shell/commands/BlueprintCommandsTest.java 0e07edb
ambari-shell/src/test/java/org/apache/ambari/shell/commands/ClusterCommandsTest.java bcd9912
ambari-shell/src/test/java/org/apache/ambari/shell/commands/HostCommandsTest.java 29efcda
ambari-shell/src/test/java/org/apache/ambari/shell/customization/AmbariPromptTest.java aec14b2
Diff: https://reviews.apache.org/r/22610/diff/
Testing
-------
code covered with unit tests
Thanks,
Krisztian Horvath
Re: Review Request 22610: Ambari Shell improvements
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22610/#review45859
-----------------------------------------------------------
Thanks for submitting the improvements.
I've tested on trunk (6433f889255c4455a7752d78518bfd87d948fca8).
I was getting a validation error on the POST blueprint call as the server was saying YARN needs APP_TIMELINE_SERVER.
Can you go ahead and change the default blueprints to add APP_TIMELINE_SERVER?
Once I made that change, I was able to go ahead with blueprint creation, cluster creation, and deployment.
- Yusaku Sako
On June 16, 2014, 5:44 p.m., Krisztian Horvath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22610/
> -----------------------------------------------------------
>
> (Updated June 16, 2014, 5:44 p.m.)
>
>
> Review request for Ambari and Yusaku Sako.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> There are a few new Ambari shell and client functionalities - this issue encapsulate them. To list a few of the enhancements:
> installation flash/progress bar
> tab completion for hostname/blueprint
> service start/stop
> auto assign for hosts to host group
> exit on finish at cluster creation
> command log name changed to ambari-log.ash instead of spring-log
> new blueprints added - warmup - lambda-architecture
> There is a new dependency introduced: jackson-mapper-asl
>
>
> Diffs
> -----
>
> ambari-client/groovy-client/pom.xml 7e4860c
> ambari-client/groovy-client/src/main/groovy/org/apache/ambari/groovy/client/AmbariClient.groovy 5b05c60
> ambari-client/groovy-client/src/main/resources/blueprints/lambda-architecture PRE-CREATION
> ambari-client/groovy-client/src/main/resources/blueprints/multi-node-hdfs-yarn 0630453
> ambari-client/groovy-client/src/main/resources/blueprints/single-node-hdfs-yarn 1a7d302
> ambari-client/groovy-client/src/main/resources/blueprints/warmup PRE-CREATION
> ambari-client/groovy-client/src/test/groovy/com.sequenceiq.ambari.client/AmbariClientTest.groovy 77ad26a
> ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AbstractAmbariClientTest.groovy PRE-CREATION
> ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariBlueprintsTest.groovy PRE-CREATION
> ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariClustersTest.groovy PRE-CREATION
> ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariHostsTest.groovy PRE-CREATION
> ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariServiceConfigurationTest.groovy PRE-CREATION
> ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariServicesTest.groovy PRE-CREATION
> ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariTasksTest.groovy PRE-CREATION
> ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/TestResources.groovy PRE-CREATION
> ambari-client/groovy-client/src/test/resources/clusterAll.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/clusters.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/host-components.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/hosts.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/no-blueprint.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/no-clusters.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/no-hosts.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/no-request-tasks.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/no-service-components-hdfs.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/no-services.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/request-tasks.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/service-components-hdfs.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/service-config.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/service-versions-multiple.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/service-versions.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/services.json aceed13
> ambari-client/groovy-client/src/test/resources/versions/clusters.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/versions/service-config.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/versions/service-versions.json PRE-CREATION
> ambari-project/pom.xml 0d32510
> ambari-shell/pom.xml 6f78db5
> ambari-shell/src/main/java/org/apache/ambari/shell/AmbariShell.java 02269a8
> ambari-shell/src/main/java/org/apache/ambari/shell/commands/BasicCommands.java 8fd6c9f
> ambari-shell/src/main/java/org/apache/ambari/shell/commands/BlueprintCommands.java 68ab343
> ambari-shell/src/main/java/org/apache/ambari/shell/commands/ClusterCommands.java f3eba83
> ambari-shell/src/main/java/org/apache/ambari/shell/commands/HostCommands.java bdcde53
> ambari-shell/src/main/java/org/apache/ambari/shell/completion/Blueprint.java PRE-CREATION
> ambari-shell/src/main/java/org/apache/ambari/shell/completion/Host.java PRE-CREATION
> ambari-shell/src/main/java/org/apache/ambari/shell/configuration/ConverterConfiguration.java f68f384
> ambari-shell/src/main/java/org/apache/ambari/shell/configuration/ShellConfiguration.java 4c36cc9
> ambari-shell/src/main/java/org/apache/ambari/shell/converter/BlueprintConverter.java PRE-CREATION
> ambari-shell/src/main/java/org/apache/ambari/shell/converter/HostConverter.java PRE-CREATION
> ambari-shell/src/main/java/org/apache/ambari/shell/customization/AmbariHistory.java PRE-CREATION
> ambari-shell/src/main/java/org/apache/ambari/shell/flash/AbstractFlash.java PRE-CREATION
> ambari-shell/src/main/java/org/apache/ambari/shell/flash/FlashService.java PRE-CREATION
> ambari-shell/src/main/java/org/apache/ambari/shell/flash/FlashType.java PRE-CREATION
> ambari-shell/src/main/java/org/apache/ambari/shell/flash/InstallProgress.java PRE-CREATION
> ambari-shell/src/test/java/org/apache/ambari/shell/commands/BlueprintCommandsTest.java 0e07edb
> ambari-shell/src/test/java/org/apache/ambari/shell/commands/ClusterCommandsTest.java bcd9912
> ambari-shell/src/test/java/org/apache/ambari/shell/commands/HostCommandsTest.java 29efcda
> ambari-shell/src/test/java/org/apache/ambari/shell/customization/AmbariPromptTest.java aec14b2
>
> Diff: https://reviews.apache.org/r/22610/diff/
>
>
> Testing
> -------
>
> code covered with unit tests
>
>
> Thanks,
>
> Krisztian Horvath
>
>
Re: Review Request 22610: Ambari Shell improvements
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22610/#review45991
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On June 17, 2014, 8:18 a.m., Krisztian Horvath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22610/
> -----------------------------------------------------------
>
> (Updated June 17, 2014, 8:18 a.m.)
>
>
> Review request for Ambari and Yusaku Sako.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> There are a few new Ambari shell and client functionalities - this issue encapsulate them. To list a few of the enhancements:
> installation flash/progress bar
> tab completion for hostname/blueprint
> service start/stop
> auto assign for hosts to host group
> exit on finish at cluster creation
> command log name changed to ambari-log.ash instead of spring-log
> new blueprints added - warmup - lambda-architecture
> There is a new dependency introduced: jackson-mapper-asl
>
>
> Diffs
> -----
>
> ambari-client/groovy-client/pom.xml 7e4860c
> ambari-client/groovy-client/src/main/groovy/org/apache/ambari/groovy/client/AmbariClient.groovy 5b05c60
> ambari-client/groovy-client/src/main/resources/blueprints/lambda-architecture PRE-CREATION
> ambari-client/groovy-client/src/main/resources/blueprints/multi-node-hdfs-yarn 0630453
> ambari-client/groovy-client/src/main/resources/blueprints/single-node-hdfs-yarn 1a7d302
> ambari-client/groovy-client/src/main/resources/blueprints/warmup PRE-CREATION
> ambari-client/groovy-client/src/test/groovy/com.sequenceiq.ambari.client/AmbariClientTest.groovy 77ad26a
> ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AbstractAmbariClientTest.groovy PRE-CREATION
> ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariBlueprintsTest.groovy PRE-CREATION
> ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariClustersTest.groovy PRE-CREATION
> ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariHostsTest.groovy PRE-CREATION
> ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariServiceConfigurationTest.groovy PRE-CREATION
> ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariServicesTest.groovy PRE-CREATION
> ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariTasksTest.groovy PRE-CREATION
> ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/TestResources.groovy PRE-CREATION
> ambari-client/groovy-client/src/test/resources/clusterAll.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/clusters.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/host-components.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/hosts.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/no-blueprint.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/no-clusters.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/no-hosts.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/no-request-tasks.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/no-service-components-hdfs.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/no-services.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/request-tasks.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/service-components-hdfs.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/service-config.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/service-versions-multiple.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/service-versions.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/services.json aceed13
> ambari-client/groovy-client/src/test/resources/versions/clusters.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/versions/service-config.json PRE-CREATION
> ambari-client/groovy-client/src/test/resources/versions/service-versions.json PRE-CREATION
> ambari-project/pom.xml 0d32510
> ambari-shell/pom.xml 6f78db5
> ambari-shell/src/main/java/org/apache/ambari/shell/AmbariShell.java 02269a8
> ambari-shell/src/main/java/org/apache/ambari/shell/commands/BasicCommands.java 8fd6c9f
> ambari-shell/src/main/java/org/apache/ambari/shell/commands/BlueprintCommands.java 68ab343
> ambari-shell/src/main/java/org/apache/ambari/shell/commands/ClusterCommands.java f3eba83
> ambari-shell/src/main/java/org/apache/ambari/shell/commands/HostCommands.java bdcde53
> ambari-shell/src/main/java/org/apache/ambari/shell/completion/Blueprint.java PRE-CREATION
> ambari-shell/src/main/java/org/apache/ambari/shell/completion/Host.java PRE-CREATION
> ambari-shell/src/main/java/org/apache/ambari/shell/configuration/ConverterConfiguration.java f68f384
> ambari-shell/src/main/java/org/apache/ambari/shell/configuration/ShellConfiguration.java 4c36cc9
> ambari-shell/src/main/java/org/apache/ambari/shell/converter/BlueprintConverter.java PRE-CREATION
> ambari-shell/src/main/java/org/apache/ambari/shell/converter/HostConverter.java PRE-CREATION
> ambari-shell/src/main/java/org/apache/ambari/shell/customization/AmbariHistory.java PRE-CREATION
> ambari-shell/src/main/java/org/apache/ambari/shell/flash/AbstractFlash.java PRE-CREATION
> ambari-shell/src/main/java/org/apache/ambari/shell/flash/FlashService.java PRE-CREATION
> ambari-shell/src/main/java/org/apache/ambari/shell/flash/FlashType.java PRE-CREATION
> ambari-shell/src/main/java/org/apache/ambari/shell/flash/InstallProgress.java PRE-CREATION
> ambari-shell/src/test/java/org/apache/ambari/shell/commands/BlueprintCommandsTest.java 0e07edb
> ambari-shell/src/test/java/org/apache/ambari/shell/commands/ClusterCommandsTest.java bcd9912
> ambari-shell/src/test/java/org/apache/ambari/shell/commands/HostCommandsTest.java 29efcda
> ambari-shell/src/test/java/org/apache/ambari/shell/customization/AmbariPromptTest.java aec14b2
>
> Diff: https://reviews.apache.org/r/22610/diff/
>
>
> Testing
> -------
>
> code covered with unit tests
>
>
> Thanks,
>
> Krisztian Horvath
>
>
Re: Review Request 22610: Ambari Shell improvements
Posted by Krisztian Horvath <kr...@sequenceiq.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22610/
-----------------------------------------------------------
(Updated June 17, 2014, 8:18 a.m.)
Review request for Ambari and Yusaku Sako.
Repository: ambari
Description
-------
There are a few new Ambari shell and client functionalities - this issue encapsulate them. To list a few of the enhancements:
installation flash/progress bar
tab completion for hostname/blueprint
service start/stop
auto assign for hosts to host group
exit on finish at cluster creation
command log name changed to ambari-log.ash instead of spring-log
new blueprints added - warmup - lambda-architecture
There is a new dependency introduced: jackson-mapper-asl
Diffs (updated)
-----
ambari-client/groovy-client/pom.xml 7e4860c
ambari-client/groovy-client/src/main/groovy/org/apache/ambari/groovy/client/AmbariClient.groovy 5b05c60
ambari-client/groovy-client/src/main/resources/blueprints/lambda-architecture PRE-CREATION
ambari-client/groovy-client/src/main/resources/blueprints/multi-node-hdfs-yarn 0630453
ambari-client/groovy-client/src/main/resources/blueprints/single-node-hdfs-yarn 1a7d302
ambari-client/groovy-client/src/main/resources/blueprints/warmup PRE-CREATION
ambari-client/groovy-client/src/test/groovy/com.sequenceiq.ambari.client/AmbariClientTest.groovy 77ad26a
ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AbstractAmbariClientTest.groovy PRE-CREATION
ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariBlueprintsTest.groovy PRE-CREATION
ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariClustersTest.groovy PRE-CREATION
ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariHostsTest.groovy PRE-CREATION
ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariServiceConfigurationTest.groovy PRE-CREATION
ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariServicesTest.groovy PRE-CREATION
ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariTasksTest.groovy PRE-CREATION
ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/TestResources.groovy PRE-CREATION
ambari-client/groovy-client/src/test/resources/clusterAll.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/clusters.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/host-components.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/hosts.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/no-blueprint.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/no-clusters.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/no-hosts.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/no-request-tasks.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/no-service-components-hdfs.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/no-services.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/request-tasks.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/service-components-hdfs.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/service-config.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/service-versions-multiple.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/service-versions.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/services.json aceed13
ambari-client/groovy-client/src/test/resources/versions/clusters.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/versions/service-config.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/versions/service-versions.json PRE-CREATION
ambari-project/pom.xml 0d32510
ambari-shell/pom.xml 6f78db5
ambari-shell/src/main/java/org/apache/ambari/shell/AmbariShell.java 02269a8
ambari-shell/src/main/java/org/apache/ambari/shell/commands/BasicCommands.java 8fd6c9f
ambari-shell/src/main/java/org/apache/ambari/shell/commands/BlueprintCommands.java 68ab343
ambari-shell/src/main/java/org/apache/ambari/shell/commands/ClusterCommands.java f3eba83
ambari-shell/src/main/java/org/apache/ambari/shell/commands/HostCommands.java bdcde53
ambari-shell/src/main/java/org/apache/ambari/shell/completion/Blueprint.java PRE-CREATION
ambari-shell/src/main/java/org/apache/ambari/shell/completion/Host.java PRE-CREATION
ambari-shell/src/main/java/org/apache/ambari/shell/configuration/ConverterConfiguration.java f68f384
ambari-shell/src/main/java/org/apache/ambari/shell/configuration/ShellConfiguration.java 4c36cc9
ambari-shell/src/main/java/org/apache/ambari/shell/converter/BlueprintConverter.java PRE-CREATION
ambari-shell/src/main/java/org/apache/ambari/shell/converter/HostConverter.java PRE-CREATION
ambari-shell/src/main/java/org/apache/ambari/shell/customization/AmbariHistory.java PRE-CREATION
ambari-shell/src/main/java/org/apache/ambari/shell/flash/AbstractFlash.java PRE-CREATION
ambari-shell/src/main/java/org/apache/ambari/shell/flash/FlashService.java PRE-CREATION
ambari-shell/src/main/java/org/apache/ambari/shell/flash/FlashType.java PRE-CREATION
ambari-shell/src/main/java/org/apache/ambari/shell/flash/InstallProgress.java PRE-CREATION
ambari-shell/src/test/java/org/apache/ambari/shell/commands/BlueprintCommandsTest.java 0e07edb
ambari-shell/src/test/java/org/apache/ambari/shell/commands/ClusterCommandsTest.java bcd9912
ambari-shell/src/test/java/org/apache/ambari/shell/commands/HostCommandsTest.java 29efcda
ambari-shell/src/test/java/org/apache/ambari/shell/customization/AmbariPromptTest.java aec14b2
Diff: https://reviews.apache.org/r/22610/diff/
Testing
-------
code covered with unit tests
Thanks,
Krisztian Horvath
Re: Review Request 22610: Ambari Shell improvements
Posted by Krisztian Horvath <kr...@sequenceiq.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22610/
-----------------------------------------------------------
(Updated June 16, 2014, 5:44 p.m.)
Review request for Ambari and Yusaku Sako.
Changes
-------
default_password param added to every cluster creation request
Repository: ambari
Description
-------
There are a few new Ambari shell and client functionalities - this issue encapsulate them. To list a few of the enhancements:
installation flash/progress bar
tab completion for hostname/blueprint
service start/stop
auto assign for hosts to host group
exit on finish at cluster creation
command log name changed to ambari-log.ash instead of spring-log
new blueprints added - warmup - lambda-architecture
There is a new dependency introduced: jackson-mapper-asl
Diffs (updated)
-----
ambari-client/groovy-client/pom.xml 7e4860c
ambari-client/groovy-client/src/main/groovy/org/apache/ambari/groovy/client/AmbariClient.groovy 5b05c60
ambari-client/groovy-client/src/main/resources/blueprints/lambda-architecture PRE-CREATION
ambari-client/groovy-client/src/main/resources/blueprints/multi-node-hdfs-yarn 0630453
ambari-client/groovy-client/src/main/resources/blueprints/single-node-hdfs-yarn 1a7d302
ambari-client/groovy-client/src/main/resources/blueprints/warmup PRE-CREATION
ambari-client/groovy-client/src/test/groovy/com.sequenceiq.ambari.client/AmbariClientTest.groovy 77ad26a
ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AbstractAmbariClientTest.groovy PRE-CREATION
ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariBlueprintsTest.groovy PRE-CREATION
ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariClustersTest.groovy PRE-CREATION
ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariHostsTest.groovy PRE-CREATION
ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariServiceConfigurationTest.groovy PRE-CREATION
ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariServicesTest.groovy PRE-CREATION
ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/AmbariTasksTest.groovy PRE-CREATION
ambari-client/groovy-client/src/test/groovy/org/apache/ambari/groovy/client/TestResources.groovy PRE-CREATION
ambari-client/groovy-client/src/test/resources/clusterAll.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/clusters.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/host-components.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/hosts.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/no-blueprint.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/no-clusters.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/no-hosts.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/no-request-tasks.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/no-service-components-hdfs.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/no-services.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/request-tasks.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/service-components-hdfs.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/service-config.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/service-versions-multiple.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/service-versions.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/services.json aceed13
ambari-client/groovy-client/src/test/resources/versions/clusters.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/versions/service-config.json PRE-CREATION
ambari-client/groovy-client/src/test/resources/versions/service-versions.json PRE-CREATION
ambari-project/pom.xml 0d32510
ambari-shell/pom.xml 6f78db5
ambari-shell/src/main/java/org/apache/ambari/shell/AmbariShell.java 02269a8
ambari-shell/src/main/java/org/apache/ambari/shell/commands/BasicCommands.java 8fd6c9f
ambari-shell/src/main/java/org/apache/ambari/shell/commands/BlueprintCommands.java 68ab343
ambari-shell/src/main/java/org/apache/ambari/shell/commands/ClusterCommands.java f3eba83
ambari-shell/src/main/java/org/apache/ambari/shell/commands/HostCommands.java bdcde53
ambari-shell/src/main/java/org/apache/ambari/shell/completion/Blueprint.java PRE-CREATION
ambari-shell/src/main/java/org/apache/ambari/shell/completion/Host.java PRE-CREATION
ambari-shell/src/main/java/org/apache/ambari/shell/configuration/ConverterConfiguration.java f68f384
ambari-shell/src/main/java/org/apache/ambari/shell/configuration/ShellConfiguration.java 4c36cc9
ambari-shell/src/main/java/org/apache/ambari/shell/converter/BlueprintConverter.java PRE-CREATION
ambari-shell/src/main/java/org/apache/ambari/shell/converter/HostConverter.java PRE-CREATION
ambari-shell/src/main/java/org/apache/ambari/shell/customization/AmbariHistory.java PRE-CREATION
ambari-shell/src/main/java/org/apache/ambari/shell/flash/AbstractFlash.java PRE-CREATION
ambari-shell/src/main/java/org/apache/ambari/shell/flash/FlashService.java PRE-CREATION
ambari-shell/src/main/java/org/apache/ambari/shell/flash/FlashType.java PRE-CREATION
ambari-shell/src/main/java/org/apache/ambari/shell/flash/InstallProgress.java PRE-CREATION
ambari-shell/src/test/java/org/apache/ambari/shell/commands/BlueprintCommandsTest.java 0e07edb
ambari-shell/src/test/java/org/apache/ambari/shell/commands/ClusterCommandsTest.java bcd9912
ambari-shell/src/test/java/org/apache/ambari/shell/commands/HostCommandsTest.java 29efcda
ambari-shell/src/test/java/org/apache/ambari/shell/customization/AmbariPromptTest.java aec14b2
Diff: https://reviews.apache.org/r/22610/diff/
Testing
-------
code covered with unit tests
Thanks,
Krisztian Horvath