Re: [PR] ATLAS-5148: Atlas DSL GROUP BY fails for non-String attributes (DATE/Long) [atlas]

["pinal-shah (via GitHub)" <gi...@apache.org>]

pinal-shah commented on code in PR #500:
URL: https://github.com/apache/atlas/pull/500#discussion_r2762708146


##########
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphTraversal.java:
##########
@@ -114,9 +114,13 @@ public Map<String, Collection<AtlasJanusVertex>> getAtlasVertexMap() {
             ret = new HashMap<>(map.size());
 
             for (Object key : map.keySet()) {
-                if (!(key instanceof String)) {
-                    continue;
-                }
+                LOG.info("Printing Key DataType: {}", key.getClass());

Review Comment:
   Consider removing comments from here and add in the jira descreiption



##########
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphTraversalTest.java:
##########
@@ -271,6 +272,44 @@ public void testGetAtlasVertexMapEmpty() throws Exception {
         assertTrue(vertexMap.isEmpty());
     }
 
+    @Test
+    public void testGetAtlasVertexMapWithLongKeysForDSLGroupByCreateTime() throws Exception {

Review Comment:
   Consider adding test in TraversalComposerTest as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org