You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/06 16:09:51 UTC
[GitHub] [arrow] bkietz opened a new pull request #7911: ARROW-9606: [C++][Dataset] Support "a"_.In(<>).Assume()"
bkietz opened a new pull request #7911:
URL: https://github.com/apache/arrow/pull/7911
@mpjdem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #7911: ARROW-9606: [C++][Dataset] Support `"a"_.In(<>).Assume()`
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #7911:
URL: https://github.com/apache/arrow/pull/7911
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7911: ARROW-9606: [C++][Dataset] Support `"a"_.In(<>).Assume()`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7911:
URL: https://github.com/apache/arrow/pull/7911#issuecomment-670033979
https://issues.apache.org/jira/browse/ARROW-9606
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #7911: ARROW-9606: [C++][Dataset] Support `"a"_.In(<>).Assume()`
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #7911:
URL: https://github.com/apache/arrow/pull/7911#discussion_r467099186
##########
File path: r/tests/testthat/test-dataset.R
##########
@@ -391,6 +391,17 @@ test_that("filter() with %in%", {
collect(),
tibble(int = df1$int[c(3, 4, 6)], part = 1)
)
+
+ ds <- open_dataset(hive_dir, partitioning = hive_partition(other = utf8(), group = uint8()))
Review comment:
It's hive-style so you don't need to tell it what the partitions are.
```suggestion
ds <- open_dataset(hive_dir)
```
##########
File path: r/tests/testthat/test-dataset.R
##########
@@ -391,6 +391,17 @@ test_that("filter() with %in%", {
collect(),
tibble(int = df1$int[c(3, 4, 6)], part = 1)
)
+
Review comment:
```suggestion
# ARROW-9606: bug in %in% filter on partition column with >1 partition columns
```
##########
File path: r/tests/testthat/test-dataset.R
##########
@@ -391,6 +391,17 @@ test_that("filter() with %in%", {
collect(),
tibble(int = df1$int[c(3, 4, 6)], part = 1)
)
+
+ ds <- open_dataset(hive_dir, partitioning = hive_partition(other = utf8(), group = uint8()))
+ expect_equivalent(
+ ds %>%
+ filter(group %in% c(2)) %>%
+ select(chr, dbl) %>%
+ filter(dbl > 7 & dbl < 53) %>%
+ collect() %>%
+ arrange(dbl),
+ df2[1:2, c("chr", "dbl")]
Review comment:
A simpler test better shows what this is testing. I confirmed that this fails on master per the user report.
```suggestion
filter(group %in% 2) %>%
collect(),
df2
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org