You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2018/03/08 16:50:42 UTC
Review Request 65986: [ATLAS-2481]: Rename entity-classification edge
label to 'classifiedAs' and add edge properties
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65986/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
Bugs: ATLAS-2481
https://issues.apache.org/jira/browse/ATLAS-2481
Repository: atlas
Description
-------
This patch updates classification and propagated classification edge label to a static name - 'classifiedAs' and additional properties areadded to the edge:
1. name - name of the classification
2. isPropagated - whether this tag is associated or propagated one
Modify advanced (DSL) search to handle searching on edges instead of vertex property for tag based searches.
Diffs
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 813fc874
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java 09f584e9
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 73db22e2
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java 9beb6a31
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/NativeTinkerpopGraphQuery.java 5c57d6fa
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java 163bf48e
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java cf1965b2
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusObjectFactory.java 6d31c7bd
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusVertexQuery.java 30c6e6ed
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java 679e3dc9
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphManagement.java 32e4d02c
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0VertexQuery.java 091e7d4a
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/TitanObjectFactory.java 8dff1e40
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 60e51076
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 6ac7786d
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 4a18ed13
repository/src/main/java/org/apache/atlas/query/GremlinClause.java 77212bcf
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java e6093660
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 97e49418
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 4056eb12
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 73e5aa26
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 73ed6b4b
repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java ff234369
Diff: https://reviews.apache.org/r/65986/diff/1/
Testing
-------
in progress
Thanks,
Sarath Subramanian
Re: Review Request 65986: [ATLAS-2481]: Rename entity-classification
edge label to 'classifiedAs' and add edge properties
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65986/#review198938
-----------------------------------------------------------
Ship it!
@Sarath - the changes look good. Applying this patch on an existing Atlas graph db will result in entity-classification associations to be not recognized (due to change in edge-label). Please send a note to the dev list on this; and there shouldn't be any need to support data-migration across 1.0 builds while in development.
- Madhan Neethiraj
On March 9, 2018, 9:01 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65986/
> -----------------------------------------------------------
>
> (Updated March 9, 2018, 9:01 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2481
> https://issues.apache.org/jira/browse/ATLAS-2481
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch updates classification and propagated classification edge label to a static name - 'classifiedAs' and additional properties areadded to the edge:
> 1. name - name of the classification
> 2. isPropagated - whether this tag is associated or propagated one
>
> Modify advanced (DSL) search to handle searching on edges instead of vertex property for tag based searches.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 813fc874
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java 09f584e9
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 73db22e2
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java 9beb6a31
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/NativeTinkerpopGraphQuery.java 5c57d6fa
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java 163bf48e
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java cf1965b2
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusObjectFactory.java 6d31c7bd
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusVertexQuery.java 30c6e6ed
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java 679e3dc9
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphManagement.java 32e4d02c
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0VertexQuery.java 091e7d4a
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/TitanObjectFactory.java 8dff1e40
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 60e51076
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 6ac7786d
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 4a18ed13
> repository/src/main/java/org/apache/atlas/query/GremlinClause.java 77212bcf
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java e6093660
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 97e49418
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 4056eb12
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 73e5aa26
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 73ed6b4b
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java ff234369
>
>
> Diff: https://reviews.apache.org/r/65986/diff/3/
>
>
> Testing
> -------
>
> in progress
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 65986: [ATLAS-2481]: Rename entity-classification
edge label to 'classifiedAs' and add edge properties
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65986/
-----------------------------------------------------------
(Updated March 9, 2018, 1:01 a.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
Bugs: ATLAS-2481
https://issues.apache.org/jira/browse/ATLAS-2481
Repository: atlas
Description
-------
This patch updates classification and propagated classification edge label to a static name - 'classifiedAs' and additional properties areadded to the edge:
1. name - name of the classification
2. isPropagated - whether this tag is associated or propagated one
Modify advanced (DSL) search to handle searching on edges instead of vertex property for tag based searches.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 813fc874
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java 09f584e9
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 73db22e2
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java 9beb6a31
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/NativeTinkerpopGraphQuery.java 5c57d6fa
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java 163bf48e
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java cf1965b2
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusObjectFactory.java 6d31c7bd
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusVertexQuery.java 30c6e6ed
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java 679e3dc9
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphManagement.java 32e4d02c
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0VertexQuery.java 091e7d4a
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/TitanObjectFactory.java 8dff1e40
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 60e51076
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 6ac7786d
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 4a18ed13
repository/src/main/java/org/apache/atlas/query/GremlinClause.java 77212bcf
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java e6093660
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 97e49418
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 4056eb12
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 73e5aa26
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 73ed6b4b
repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java ff234369
Diff: https://reviews.apache.org/r/65986/diff/2/
Changes: https://reviews.apache.org/r/65986/diff/1-2/
Testing
-------
in progress
Thanks,
Sarath Subramanian
Re: Review Request 65986: [ATLAS-2481]: Rename entity-classification
edge label to 'classifiedAs' and add edge properties
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65986/#review198908
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
Line 263 (original), 266 (patched)
<https://reviews.apache.org/r/65986/#comment279174>
Since a classification's 'propagate' flag can be updated later, consider moving this line from createClassificatioVertex() to mapClassification() - along with handling of 'validityPeriods' value.
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
Line 1481 (original), 1486 (patched)
<https://reviews.apache.org/r/65986/#comment279178>
It is not clear why currentClassification is updated with attributes from incoming classifications. It doesn't seem to be used further. If this is not necessary, can this be removed?
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
Line 1501 (original), 1506 (patched)
<https://reviews.apache.org/r/65986/#comment279179>
currentTagPropagation value might be different across iterations on classifications (#1464). We must track propagation additions and removals separately.
- Madhan Neethiraj
On March 8, 2018, 4:50 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65986/
> -----------------------------------------------------------
>
> (Updated March 8, 2018, 4:50 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2481
> https://issues.apache.org/jira/browse/ATLAS-2481
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch updates classification and propagated classification edge label to a static name - 'classifiedAs' and additional properties areadded to the edge:
> 1. name - name of the classification
> 2. isPropagated - whether this tag is associated or propagated one
>
> Modify advanced (DSL) search to handle searching on edges instead of vertex property for tag based searches.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 813fc874
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java 09f584e9
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 73db22e2
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java 9beb6a31
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/NativeTinkerpopGraphQuery.java 5c57d6fa
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java 163bf48e
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java cf1965b2
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusObjectFactory.java 6d31c7bd
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusVertexQuery.java 30c6e6ed
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java 679e3dc9
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphManagement.java 32e4d02c
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0VertexQuery.java 091e7d4a
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/TitanObjectFactory.java 8dff1e40
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 60e51076
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 6ac7786d
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 4a18ed13
> repository/src/main/java/org/apache/atlas/query/GremlinClause.java 77212bcf
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java e6093660
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 97e49418
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 4056eb12
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 73e5aa26
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 73ed6b4b
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java ff234369
>
>
> Diff: https://reviews.apache.org/r/65986/diff/1/
>
>
> Testing
> -------
>
> in progress
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 65986: [ATLAS-2481]: Rename entity-classification
edge label to 'classifiedAs' and add edge properties
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65986/#review198923
-----------------------------------------------------------
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java
Lines 216 (patched)
<https://reviews.apache.org/r/65986/#comment279189>
Ternary operator can be folded here.
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphManagement.java
Lines 223 (patched)
<https://reviews.apache.org/r/65986/#comment279190>
Ternary operator is not needed
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java
Lines 129 (patched)
<https://reviews.apache.org/r/65986/#comment279191>
07E -> 06F
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java
Line 1567 (original), 1629 (patched)
<https://reviews.apache.org/r/65986/#comment279193>
Since we're moving away from "trait" references in the vertex, might be a good idea to rename the method to be consistent.
- Apoorv Naik
On March 8, 2018, 4:50 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65986/
> -----------------------------------------------------------
>
> (Updated March 8, 2018, 4:50 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2481
> https://issues.apache.org/jira/browse/ATLAS-2481
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch updates classification and propagated classification edge label to a static name - 'classifiedAs' and additional properties areadded to the edge:
> 1. name - name of the classification
> 2. isPropagated - whether this tag is associated or propagated one
>
> Modify advanced (DSL) search to handle searching on edges instead of vertex property for tag based searches.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 813fc874
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java 09f584e9
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 73db22e2
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java 9beb6a31
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/NativeTinkerpopGraphQuery.java 5c57d6fa
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java 163bf48e
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java cf1965b2
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusObjectFactory.java 6d31c7bd
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusVertexQuery.java 30c6e6ed
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java 679e3dc9
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphManagement.java 32e4d02c
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0VertexQuery.java 091e7d4a
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/TitanObjectFactory.java 8dff1e40
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 60e51076
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 6ac7786d
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 4a18ed13
> repository/src/main/java/org/apache/atlas/query/GremlinClause.java 77212bcf
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java e6093660
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 97e49418
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 4056eb12
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 73e5aa26
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 73ed6b4b
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java ff234369
>
>
> Diff: https://reviews.apache.org/r/65986/diff/1/
>
>
> Testing
> -------
>
> in progress
>
>
> Thanks,
>
> Sarath Subramanian
>
>