[GitHub] [helix] kaisun2000 commented on a change in pull request #1401: Mark AutoRebalancer as deprecated and convert the default test logic to not use AutoRebalancer.

[GitBox <gi...@apache.org>]

kaisun2000 commented on a change in pull request #1401:
URL: https://github.com/apache/helix/pull/1401#discussion_r493961914



##########
File path: helix-core/src/test/java/org/apache/helix/TestHelper.java
##########
@@ -287,7 +289,10 @@ public static void setupCluster(String clusterName, String zkAddr, int startPort
 
       for (int i = 0; i < resourceNb; i++) {
         String resourceName = resourceNamePrefix + i;
-        setupTool.addResourceToCluster(clusterName, resourceName, partitionNb, stateModelDef, mode.toString());
+        setupTool.addResourceToCluster(clusterName, resourceName, partitionNb, stateModelDef,
+            mode.name(),
+            mode == RebalanceMode.FULL_AUTO ? CrushEdRebalanceStrategy.class.getName()
+                : RebalanceStrategy.DEFAULT_REBALANCE_STRATEGY);

Review comment:
       Here, RebalanceMode.FULL_AUTO, we will always use crushED, which means delayAutoRebalancer with CrushED
   
   Before this change, it is AutoRebalancer with AutoRebalanceStrategy, both takes current state into consideration. They bestPossibleVerifier may still work, but the state mapping can be different from one run to another run




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org