You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/01/06 22:44:09 UTC

[GitHub] [trafficserver] masaori335 commented on a change in pull request #8576: LGTM: Fix constant comparison

masaori335 commented on a change in pull request #8576:
URL: https://github.com/apache/trafficserver/pull/8576#discussion_r779915405



##########
File path: iocore/net/UnixUDPNet.cc
##########
@@ -534,7 +534,7 @@ UDPNetProcessor::recvfrom_re(Continuation *cont, void *token, int fd, struct soc
     cont->handleEvent(NET_EVENT_DATAGRAM_READ_COMPLETE, event);
     completionUtil::destroy(event);
     return ACTION_RESULT_DONE;
-  } else if (actual == 0 || (actual < 0 && actual == -EAGAIN)) {
+  } else if (actual == 0 || (actual < 0 && actual == -EAGAIN)) { // lgtm[cpp/constant-comparison]

Review comment:
       Ah, right. Now I got what the alert says.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org