You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/01/15 21:47:43 UTC
[GitHub] [incubator-gobblin] jack-moseley opened a new pull request #3203: [GOBBLIN-1362] Fix bug where state is set twice when no workunits created
jack-moseley opened a new pull request #3203:
URL: https://github.com/apache/incubator-gobblin/pull/3203
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1362
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
Move the normal notifyListeners calls to an else block, so that it will only be run if isWorkUnitsEmpty is false. Otherwise the state will try to be set twice in the case of no workunits.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3203: [GOBBLIN-1362] Fix bug where state is set twice when no workunits created
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3203:
URL: https://github.com/apache/incubator-gobblin/pull/3203
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io commented on pull request #3203: [GOBBLIN-1362] Fix bug where state is set twice when no workunits created
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #3203:
URL: https://github.com/apache/incubator-gobblin/pull/3203#issuecomment-761563034
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3203?src=pr&el=h1) Report
> Merging [#3203](https://codecov.io/gh/apache/incubator-gobblin/pull/3203?src=pr&el=desc) (7046a96) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/4e9326bd96ab9b5ec05dd1cd5e8010a7d6175f0c?el=desc) (4e9326b) will **decrease** coverage by `0.00%`.
> The diff coverage is `73.33%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-gobblin/pull/3203/graphs/tree.svg?width=650&height=150&src=pr&token=4MgURJ0bGc)](https://codecov.io/gh/apache/incubator-gobblin/pull/3203?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3203 +/- ##
===========================================
- Coverage 9.18% 9.17% -0.01%
+ Complexity 1738 1737 -1
===========================================
Files 2019 2019
Lines 77429 77437 +8
Branches 8601 8602 +1
===========================================
- Hits 7110 7108 -2
- Misses 69624 69634 +10
Partials 695 695
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3203?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/gobblin/runtime/AbstractJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3203/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvQWJzdHJhY3RKb2JMYXVuY2hlci5qYXZh) | `55.58% <73.33%> (ø)` | `28.00 <0.00> (ø)` | |
| [...ction/action/CompactionHiveRegistrationAction.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3203/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYWN0aW9uL0NvbXBhY3Rpb25IaXZlUmVnaXN0cmF0aW9uQWN0aW9uLmphdmE=) | `41.46% <0.00%> (-1.04%)` | `5.00% <0.00%> (ø%)` | |
| [...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3203/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==) | `29.93% <0.00%> (-0.66%)` | `24.00% <0.00%> (-1.00%)` | |
| [...in/java/org/apache/gobblin/util/DownloadUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3203/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvRG93bmxvYWRVdGlscy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3203?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3203?src=pr&el=footer). Last update [4e9326b...7046a96](https://codecov.io/gh/apache/incubator-gobblin/pull/3203?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io edited a comment on pull request #3203: [GOBBLIN-1362] Fix bug where state is set twice when no workunits created
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #3203:
URL: https://github.com/apache/incubator-gobblin/pull/3203#issuecomment-761563034
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3203?src=pr&el=h1) Report
> Merging [#3203](https://codecov.io/gh/apache/incubator-gobblin/pull/3203?src=pr&el=desc) (7046a96) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/4e9326bd96ab9b5ec05dd1cd5e8010a7d6175f0c?el=desc) (4e9326b) will **increase** coverage by `37.06%`.
> The diff coverage is `100.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-gobblin/pull/3203/graphs/tree.svg?width=650&height=150&src=pr&token=4MgURJ0bGc)](https://codecov.io/gh/apache/incubator-gobblin/pull/3203?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3203 +/- ##
=============================================
+ Coverage 9.18% 46.24% +37.06%
- Complexity 1738 9789 +8051
=============================================
Files 2019 2019
Lines 77429 77437 +8
Branches 8601 8602 +1
=============================================
+ Hits 7110 35810 +28700
+ Misses 69624 38297 -31327
- Partials 695 3330 +2635
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3203?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/gobblin/runtime/AbstractJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3203/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvQWJzdHJhY3RKb2JMYXVuY2hlci5qYXZh) | `61.55% <100.00%> (+5.97%)` | `38.00 <0.00> (+10.00)` | |
| [...ction/action/CompactionHiveRegistrationAction.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3203/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYWN0aW9uL0NvbXBhY3Rpb25IaXZlUmVnaXN0cmF0aW9uQWN0aW9uLmphdmE=) | `41.46% <0.00%> (-1.04%)` | `5.00% <0.00%> (ø%)` | |
| [...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3203/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==) | `29.93% <0.00%> (-0.66%)` | `24.00% <0.00%> (-1.00%)` | |
| [...in/java/org/apache/gobblin/util/DownloadUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3203/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvRG93bmxvYWRVdGlscy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [.../org/apache/gobblin/writer/AvroHdfsDataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3203/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9BdnJvSGRmc0RhdGFXcml0ZXIuamF2YQ==) | `77.77% <0.00%> (ø)` | `5.00% <0.00%> (+1.00%)` | |
| [...gobblin/service/monitoring/JobStatusRetriever.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3203/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9Kb2JTdGF0dXNSZXRyaWV2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `2.00% <0.00%> (+2.00%)` | |
| [...ata/management/copy/hive/HivePartitionFileSet.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3203/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaGl2ZS9IaXZlUGFydGl0aW9uRmlsZVNldC5qYXZh) | `0.93% <0.00%> (+0.93%)` | `1.00% <0.00%> (+1.00%)` | |
| [...ain/java/org/apache/gobblin/runtime/TaskState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3203/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFza1N0YXRlLmphdmE=) | `81.97% <0.00%> (+1.16%)` | `32.00% <0.00%> (ø%)` | |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3203/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `63.46% <0.00%> (+1.28%)` | `35.00% <0.00%> (+2.00%)` | |
| [...in/java/org/apache/gobblin/util/FileListUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3203/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvRmlsZUxpc3RVdGlscy5qYXZh) | `71.42% <0.00%> (+1.29%)` | `28.00% <0.00%> (ø%)` | |
| ... and [1064 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3203/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3203?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3203?src=pr&el=footer). Last update [4e9326b...7046a96](https://codecov.io/gh/apache/incubator-gobblin/pull/3203?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org