You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/07/01 19:49:15 UTC
Re: Review Request 70899: Refactored the agent's task-killing code.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70899/
-----------------------------------------------------------
(Updated July 1, 2019, 7:49 p.m.)
Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
Bugs: MESOS-9821
https://issues.apache.org/jira/browse/MESOS-9821
Repository: mesos
Description
-------
This patch factors the code responsible for killing tasks
out into two helper functions. This will facilitate the
calling of this common code by the agent-draining handler.
Diffs (updated)
-----
src/slave/slave.hpp 6954f53ff1531b9fcb688ef76acddf6a3d849a41
src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e
Diff: https://reviews.apache.org/r/70899/diff/4/
Changes: https://reviews.apache.org/r/70899/diff/3-4/
Testing
-------
Testing details at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 70899: Refactored the agent's task-killing code.
Posted by Greg Mann <gr...@mesosphere.io>.
> On July 2, 2019, 10:52 p.m., Joseph Wu wrote:
> > src/slave/slave.cpp
> > Lines 3673-3680 (original), 3673-3679 (patched)
> > <https://reviews.apache.org/r/70899/diff/4/?file=2152982#file2152982line3673>
> >
> > Due to splitting out the `killPendingTask`, this logic is now executed before the check for `framework->state == Framework::TERMINATING`. This means the agent will no longer log that warning message (Ignoring kill task ...) for pending tasks only.
> >
> > Is this intentional? (It probably isn't a big deal if we don't log this warning.)
Oh whoops this was unintentional; thanks!! I think it's best to move the conditional logging back into `killTask()` just before we call into `killPendingTask()`. This maintains exactly the same behavior as before.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70899/#review216322
-----------------------------------------------------------
On July 10, 2019, 6:59 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70899/
> -----------------------------------------------------------
>
> (Updated July 10, 2019, 6:59 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9821
> https://issues.apache.org/jira/browse/MESOS-9821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch factors the code responsible for killing tasks
> out into two helper functions. This will facilitate the
> calling of this common code by the agent-draining handler.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 6954f53ff1531b9fcb688ef76acddf6a3d849a41
> src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e
>
>
> Diff: https://reviews.apache.org/r/70899/diff/5/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70899: Refactored the agent's task-killing code.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70899/#review216322
-----------------------------------------------------------
src/slave/slave.cpp
Lines 3673-3680 (original), 3673-3679 (patched)
<https://reviews.apache.org/r/70899/#comment303492>
Due to splitting out the `killPendingTask`, this logic is now executed before the check for `framework->state == Framework::TERMINATING`. This means the agent will no longer log that warning message (Ignoring kill task ...) for pending tasks only.
Is this intentional? (It probably isn't a big deal if we don't log this warning.)
- Joseph Wu
On July 1, 2019, 12:49 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70899/
> -----------------------------------------------------------
>
> (Updated July 1, 2019, 12:49 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9821
> https://issues.apache.org/jira/browse/MESOS-9821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch factors the code responsible for killing tasks
> out into two helper functions. This will facilitate the
> calling of this common code by the agent-draining handler.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 6954f53ff1531b9fcb688ef76acddf6a3d849a41
> src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e
>
>
> Diff: https://reviews.apache.org/r/70899/diff/4/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70899: Refactored the agent's task-killing code.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70899/#review216565
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On July 10, 2019, 11:59 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70899/
> -----------------------------------------------------------
>
> (Updated July 10, 2019, 11:59 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9821
> https://issues.apache.org/jira/browse/MESOS-9821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch factors the code responsible for killing tasks
> out into two helper functions. This will facilitate the
> calling of this common code by the agent-draining handler.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 6954f53ff1531b9fcb688ef76acddf6a3d849a41
> src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e
>
>
> Diff: https://reviews.apache.org/r/70899/diff/5/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70899: Refactored the agent's task-killing code.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70899/
-----------------------------------------------------------
(Updated July 10, 2019, 6:59 p.m.)
Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
Bugs: MESOS-9821
https://issues.apache.org/jira/browse/MESOS-9821
Repository: mesos
Description
-------
This patch factors the code responsible for killing tasks
out into two helper functions. This will facilitate the
calling of this common code by the agent-draining handler.
Diffs (updated)
-----
src/slave/slave.hpp 6954f53ff1531b9fcb688ef76acddf6a3d849a41
src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e
Diff: https://reviews.apache.org/r/70899/diff/5/
Changes: https://reviews.apache.org/r/70899/diff/4-5/
Testing
-------
Testing details at the end of this chain.
Thanks,
Greg Mann