You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/03 16:18:10 UTC

[GitHub] [flink] wuchong opened a new pull request #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source

wuchong opened a new pull request #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10763
 
 
   
   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   Fix NPE when left input is a query (e.g. a filter/project/temporal join) in temporal table function join. 
   
   ## Brief change log
   
   - Get the RelOptSchema from the leaf RelNode which holds the non-null RelOptSchema
   
   ## Verifying this change
   
   - Add a plan test that left input is a filter query
   - Add a IT case that left input is a temporal join
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10763#issuecomment-570630824
 
 
   <!--
   Meta data
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143024027 TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4084 TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   Hash:da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4090 TriggerType:PUSH TriggerID:da8137a5c135ee86f12bd4cbd33f6aea77c06a14
   Hash:da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143077002 TriggerType:PUSH TriggerID:da8137a5c135ee86f12bd4cbd33f6aea77c06a14
   -->
   ## CI report:
   
   * 19e2bf9244667af4490f1463bdf48ba40d02e5ed Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143024027) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4084) 
   * da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143077002) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4090) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong commented on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source

Posted by GitBox <gi...@apache.org>.
wuchong commented on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10763#issuecomment-571089235
 
 
   Thanks @dawidwys for the reviewing. Comments are addressed. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dawidwys commented on a change in pull request #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source

Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10763#discussion_r363209651
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TemporalJoinITCase.scala
 ##########
 @@ -158,11 +160,87 @@ class TemporalJoinITCase(state: StateBackendMode)
 
     assertEquals(expectedOutput, sink.getAppendResults.toSet)
   }
+
+  @Test
+  def testNestedTemporalJoin(): Unit = {
+    val env = StreamExecutionEnvironment.getExecutionEnvironment
+    val tEnv = StreamTableEnvironment.create(env, TableTestUtil.STREAM_SETTING)
+    env.setStreamTimeCharacteristic(TimeCharacteristic.EventTime)
+
+    val sqlQuery =
+      """
+        |SELECT
+        |  o.amount, r.rate, p.price
+        |FROM
+        |  Orders AS o,
+        |  LATERAL TABLE (Rates(o.rowtime)) AS r,
+        |  LATERAL TABLE (Prices(o.rowtime)) AS p
+        |WHERE r.currency = o.currency AND p.productId = o.productId
+        |""".stripMargin
+
+    val ordersData = new mutable.MutableList[(Long, String, String, Timestamp)]
+    ordersData.+=((2L, "A1", "Euro", new Timestamp(2L)))
+    ordersData.+=((1L, "A2", "US Dollar", new Timestamp(3L)))
+    ordersData.+=((50L, "A4", "Yen", new Timestamp(4L)))
+    ordersData.+=((3L, "A2", "Euro", new Timestamp(5L)))
+
+    val ratesHistoryData = new mutable.MutableList[(String, Long, Timestamp)]
+    ratesHistoryData.+=(("US Dollar", 102L, new Timestamp(1L)))
+    ratesHistoryData.+=(("Euro", 114L, new Timestamp(1L)))
+    ratesHistoryData.+=(("Yen", 1L, new Timestamp(1L)))
+    ratesHistoryData.+=(("Euro", 116L, new Timestamp(5L)))
+    ratesHistoryData.+=(("Euro", 119L, new Timestamp(7L)))
+
+    val pricesHistoryData = new mutable.MutableList[(String, Double, Timestamp)]
+    pricesHistoryData.+=(("A2", 10.2D, new Timestamp(1L)))
+    pricesHistoryData.+=(("A1", 11.4D, new Timestamp(1L)))
+    pricesHistoryData.+=(("A4", 1D, new Timestamp(1L)))
+    pricesHistoryData.+=(("A1", 11.6D, new Timestamp(5L)))
+    pricesHistoryData.+=(("A1", 11.9D, new Timestamp(7L)))
+
+    val orders = env
+      .fromCollection(ordersData)
+      .asInstanceOf[DataStream[Product]]
 
 Review comment:
   How about fixing the generic type of `TimestampExtractor` instead?
   
   ```
         .fromCollection(ordersData)
         .assignTimestampsAndWatermarks(new TimestampExtractor[(Long, String, String, Timestamp)]())
   
   
   class TimestampExtractor[T <: Product]
     extends BoundedOutOfOrdernessTimestampExtractor[T]
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10763#issuecomment-570630824
 
 
   <!--
   Meta data
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143024027 TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4084 TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   Hash:da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4090 TriggerType:PUSH TriggerID:da8137a5c135ee86f12bd4cbd33f6aea77c06a14
   Hash:da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143077002 TriggerType:PUSH TriggerID:da8137a5c135ee86f12bd4cbd33f6aea77c06a14
   Hash:0bcdc9a62338aefab77a8277e87f10f8afcfc48e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4095 TriggerType:PUSH TriggerID:0bcdc9a62338aefab77a8277e87f10f8afcfc48e
   Hash:0bcdc9a62338aefab77a8277e87f10f8afcfc48e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143095852 TriggerType:PUSH TriggerID:0bcdc9a62338aefab77a8277e87f10f8afcfc48e
   Hash:4311bd9a01f16b10d03ce1744c7baebd3c2872e4 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143225320 TriggerType:PUSH TriggerID:4311bd9a01f16b10d03ce1744c7baebd3c2872e4
   Hash:4311bd9a01f16b10d03ce1744c7baebd3c2872e4 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4121 TriggerType:PUSH TriggerID:4311bd9a01f16b10d03ce1744c7baebd3c2872e4
   -->
   ## CI report:
   
   * 19e2bf9244667af4490f1463bdf48ba40d02e5ed Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143024027) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4084) 
   * da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143077002) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4090) 
   * 0bcdc9a62338aefab77a8277e87f10f8afcfc48e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143095852) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4095) 
   * 4311bd9a01f16b10d03ce1744c7baebd3c2872e4 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143225320) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4121) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10763#issuecomment-570620627
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 19e2bf9244667af4490f1463bdf48ba40d02e5ed (Fri Jan 03 16:20:21 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong merged pull request #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10763
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10763#issuecomment-570630824
 
 
   <!--
   Meta data
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143024027 TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4084 TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   Hash:da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4090 TriggerType:PUSH TriggerID:da8137a5c135ee86f12bd4cbd33f6aea77c06a14
   Hash:da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143077002 TriggerType:PUSH TriggerID:da8137a5c135ee86f12bd4cbd33f6aea77c06a14
   Hash:0bcdc9a62338aefab77a8277e87f10f8afcfc48e Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4095 TriggerType:PUSH TriggerID:0bcdc9a62338aefab77a8277e87f10f8afcfc48e
   Hash:0bcdc9a62338aefab77a8277e87f10f8afcfc48e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143095852 TriggerType:PUSH TriggerID:0bcdc9a62338aefab77a8277e87f10f8afcfc48e
   -->
   ## CI report:
   
   * 19e2bf9244667af4490f1463bdf48ba40d02e5ed Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143024027) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4084) 
   * da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143077002) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4090) 
   * 0bcdc9a62338aefab77a8277e87f10f8afcfc48e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143095852) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4095) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong commented on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source

Posted by GitBox <gi...@apache.org>.
wuchong commented on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10763#issuecomment-571444243
 
 
   The failed case `BackPressureITCase.tearDown` is not related to this PR which has been tracked by FLINK-15247.
   
   Merging...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10763#issuecomment-570630824
 
 
   <!--
   Meta data
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143024027 TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4084 TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   Hash:da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4090 TriggerType:PUSH TriggerID:da8137a5c135ee86f12bd4cbd33f6aea77c06a14
   Hash:da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143077002 TriggerType:PUSH TriggerID:da8137a5c135ee86f12bd4cbd33f6aea77c06a14
   Hash:0bcdc9a62338aefab77a8277e87f10f8afcfc48e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4095 TriggerType:PUSH TriggerID:0bcdc9a62338aefab77a8277e87f10f8afcfc48e
   Hash:0bcdc9a62338aefab77a8277e87f10f8afcfc48e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143095852 TriggerType:PUSH TriggerID:0bcdc9a62338aefab77a8277e87f10f8afcfc48e
   -->
   ## CI report:
   
   * 19e2bf9244667af4490f1463bdf48ba40d02e5ed Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143024027) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4084) 
   * da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143077002) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4090) 
   * 0bcdc9a62338aefab77a8277e87f10f8afcfc48e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143095852) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4095) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dawidwys commented on a change in pull request #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source

Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10763#discussion_r363215985
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TemporalJoinITCase.scala
 ##########
 @@ -158,11 +160,87 @@ class TemporalJoinITCase(state: StateBackendMode)
 
     assertEquals(expectedOutput, sink.getAppendResults.toSet)
   }
+
+  @Test
+  def testNestedTemporalJoin(): Unit = {
+    val env = StreamExecutionEnvironment.getExecutionEnvironment
+    val tEnv = StreamTableEnvironment.create(env, TableTestUtil.STREAM_SETTING)
+    env.setStreamTimeCharacteristic(TimeCharacteristic.EventTime)
+
+    val sqlQuery =
+      """
+        |SELECT
+        |  o.amount, r.rate, p.price
+        |FROM
+        |  Orders AS o,
+        |  LATERAL TABLE (Rates(o.rowtime)) AS r,
+        |  LATERAL TABLE (Prices(o.rowtime)) AS p
+        |WHERE r.currency = o.currency AND p.productId = o.productId
+        |""".stripMargin
+
+    val ordersData = new mutable.MutableList[(Long, String, String, Timestamp)]
+    ordersData.+=((2L, "A1", "Euro", new Timestamp(2L)))
+    ordersData.+=((1L, "A2", "US Dollar", new Timestamp(3L)))
+    ordersData.+=((50L, "A4", "Yen", new Timestamp(4L)))
+    ordersData.+=((3L, "A2", "Euro", new Timestamp(5L)))
+
+    val ratesHistoryData = new mutable.MutableList[(String, Long, Timestamp)]
+    ratesHistoryData.+=(("US Dollar", 102L, new Timestamp(1L)))
+    ratesHistoryData.+=(("Euro", 114L, new Timestamp(1L)))
+    ratesHistoryData.+=(("Yen", 1L, new Timestamp(1L)))
+    ratesHistoryData.+=(("Euro", 116L, new Timestamp(5L)))
+    ratesHistoryData.+=(("Euro", 119L, new Timestamp(7L)))
+
+    val pricesHistoryData = new mutable.MutableList[(String, Double, Timestamp)]
+    pricesHistoryData.+=(("A2", 10.2D, new Timestamp(1L)))
+    pricesHistoryData.+=(("A1", 11.4D, new Timestamp(1L)))
+    pricesHistoryData.+=(("A4", 1D, new Timestamp(1L)))
+    pricesHistoryData.+=(("A1", 11.6D, new Timestamp(5L)))
+    pricesHistoryData.+=(("A1", 11.9D, new Timestamp(7L)))
+
+    val orders = env
+      .fromCollection(ordersData)
+      .asInstanceOf[DataStream[Product]]
+      .assignTimestampsAndWatermarks(new TimestampExtractor())
+      .toTable(tEnv, 'amount, 'productId, 'currency, 'rowtime.rowtime)
+    val ratesHistory = env
+      .fromCollection(ratesHistoryData)
+      .asInstanceOf[DataStream[Product]]
+      .assignTimestampsAndWatermarks(new TimestampExtractor())
+      .toTable(tEnv, 'currency, 'rate, 'rowtime.rowtime)
+    val pricesHistory = env
+      .fromCollection(pricesHistoryData)
+      .asInstanceOf[DataStream[Product]]
+      .assignTimestampsAndWatermarks(new TimestampExtractor())
+      .toTable(tEnv, 'productId, 'price, 'rowtime.rowtime)
+
+    tEnv.createTemporaryView("Orders", orders)
+    tEnv.createTemporaryView("RatesHistory", ratesHistory)
+    tEnv.registerFunction(
+      "Rates",
+      ratesHistory.createTemporalTableFunction("rowtime", "currency"))
+    tEnv.registerFunction(
+      "Prices",
+      pricesHistory.createTemporalTableFunction("rowtime", "productId"))
+
+    tEnv.createTemporaryView("TemporalJoinResult", tEnv.sqlQuery(sqlQuery))
+
+    // Scan from registered table to test for interplay between
+    // LogicalCorrelateToTemporalTableJoinRule and TableScanRule
+    val result = tEnv.from("TemporalJoinResult").toAppendStream[Row]
+    val sink = new TestingAppendSink
+    result.addSink(sink)
+    env.execute()
+
+    val expected = List("1,102,10.2", "3,116,10.2", "2,114,11.4", "50,1,1.0")
+    assertEquals(expected.sorted, sink.getAppendResults.sorted)
+  }
 }
 
-class TimestampExtractor[T1, T2]
-  extends BoundedOutOfOrdernessTimestampExtractor[(T1, T2, Timestamp)](Time.seconds(10))  {
-  override def extractTimestamp(element: (T1, T2, Timestamp)): Long = {
-    element._3.getTime
+class TimestampExtractor
+  extends BoundedOutOfOrdernessTimestampExtractor[Product](Time.seconds(10))  {
+  override def extractTimestamp(element: Product): Long = element match {
+    case (_, _, ts: Timestamp) => ts.getTime
+    case (_, _, _, ts: Timestamp) => ts.getTime
 
 Review comment:
   add a default branch:
   ```
   case _ => throw new IllegalArgumentException("Expected the last element in a tuple to be of a Timestamp type.")
   ```
   
   This will make it easier to use this extractor in future tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10763#issuecomment-570630824
 
 
   <!--
   Meta data
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143024027 TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4084 TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   Hash:da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4090 TriggerType:PUSH TriggerID:da8137a5c135ee86f12bd4cbd33f6aea77c06a14
   Hash:da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143077002 TriggerType:PUSH TriggerID:da8137a5c135ee86f12bd4cbd33f6aea77c06a14
   Hash:0bcdc9a62338aefab77a8277e87f10f8afcfc48e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4095 TriggerType:PUSH TriggerID:0bcdc9a62338aefab77a8277e87f10f8afcfc48e
   Hash:0bcdc9a62338aefab77a8277e87f10f8afcfc48e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143095852 TriggerType:PUSH TriggerID:0bcdc9a62338aefab77a8277e87f10f8afcfc48e
   Hash:4311bd9a01f16b10d03ce1744c7baebd3c2872e4 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:4311bd9a01f16b10d03ce1744c7baebd3c2872e4
   -->
   ## CI report:
   
   * 19e2bf9244667af4490f1463bdf48ba40d02e5ed Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143024027) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4084) 
   * da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143077002) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4090) 
   * 0bcdc9a62338aefab77a8277e87f10f8afcfc48e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143095852) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4095) 
   * 4311bd9a01f16b10d03ce1744c7baebd3c2872e4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong commented on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source

Posted by GitBox <gi...@apache.org>.
wuchong commented on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10763#issuecomment-570977107
 
 
   The failed case `BackPressureITCase.tearDown` should be not related to this issue. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10763#issuecomment-570630824
 
 
   <!--
   Meta data
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143024027 TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4084 TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   Hash:da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4090 TriggerType:PUSH TriggerID:da8137a5c135ee86f12bd4cbd33f6aea77c06a14
   Hash:da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143077002 TriggerType:PUSH TriggerID:da8137a5c135ee86f12bd4cbd33f6aea77c06a14
   Hash:0bcdc9a62338aefab77a8277e87f10f8afcfc48e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4095 TriggerType:PUSH TriggerID:0bcdc9a62338aefab77a8277e87f10f8afcfc48e
   Hash:0bcdc9a62338aefab77a8277e87f10f8afcfc48e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143095852 TriggerType:PUSH TriggerID:0bcdc9a62338aefab77a8277e87f10f8afcfc48e
   Hash:4311bd9a01f16b10d03ce1744c7baebd3c2872e4 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143225320 TriggerType:PUSH TriggerID:4311bd9a01f16b10d03ce1744c7baebd3c2872e4
   Hash:4311bd9a01f16b10d03ce1744c7baebd3c2872e4 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4121 TriggerType:PUSH TriggerID:4311bd9a01f16b10d03ce1744c7baebd3c2872e4
   -->
   ## CI report:
   
   * 19e2bf9244667af4490f1463bdf48ba40d02e5ed Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143024027) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4084) 
   * da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143077002) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4090) 
   * 0bcdc9a62338aefab77a8277e87f10f8afcfc48e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143095852) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4095) 
   * 4311bd9a01f16b10d03ce1744c7baebd3c2872e4 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143225320) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4121) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10763#issuecomment-570630824
 
 
   <!--
   Meta data
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143024027 TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4084 TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   Hash:da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:da8137a5c135ee86f12bd4cbd33f6aea77c06a14
   -->
   ## CI report:
   
   * 19e2bf9244667af4490f1463bdf48ba40d02e5ed Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143024027) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4084) 
   * da8137a5c135ee86f12bd4cbd33f6aea77c06a14 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10763#issuecomment-570630824
 
 
   <!--
   Meta data
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143024027 TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4084 TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   Hash:da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4090 TriggerType:PUSH TriggerID:da8137a5c135ee86f12bd4cbd33f6aea77c06a14
   Hash:da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143077002 TriggerType:PUSH TriggerID:da8137a5c135ee86f12bd4cbd33f6aea77c06a14
   Hash:0bcdc9a62338aefab77a8277e87f10f8afcfc48e Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4095 TriggerType:PUSH TriggerID:0bcdc9a62338aefab77a8277e87f10f8afcfc48e
   Hash:0bcdc9a62338aefab77a8277e87f10f8afcfc48e Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143095852 TriggerType:PUSH TriggerID:0bcdc9a62338aefab77a8277e87f10f8afcfc48e
   -->
   ## CI report:
   
   * 19e2bf9244667af4490f1463bdf48ba40d02e5ed Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143024027) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4084) 
   * da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143077002) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4090) 
   * 0bcdc9a62338aefab77a8277e87f10f8afcfc48e Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143095852) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4095) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10763#issuecomment-570630824
 
 
   <!--
   Meta data
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   -->
   ## CI report:
   
   * 19e2bf9244667af4490f1463bdf48ba40d02e5ed UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10763#issuecomment-570630824
 
 
   <!--
   Meta data
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143024027 TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4084 TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   -->
   ## CI report:
   
   * 19e2bf9244667af4490f1463bdf48ba40d02e5ed Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143024027) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4084) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10763#issuecomment-570630824
 
 
   <!--
   Meta data
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143024027 TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4084 TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   -->
   ## CI report:
   
   * 19e2bf9244667af4490f1463bdf48ba40d02e5ed Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143024027) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4084) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dawidwys commented on a change in pull request #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source

Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10763#discussion_r363202235
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/join/TemporalJoinTest.scala
 ##########
 @@ -73,6 +73,21 @@ class TemporalJoinTest extends TableTestBase {
     util.verifyPlan(sqlQuery)
   }
 
+  @Test
+  def testJoinOnQueryLeft(): Unit = {
+    val orders = util.tableEnv.sqlQuery("SELECT * FROM Orders WHERE o_amount > 1000")
+    // register a query as left side
 
 Review comment:
   nit: this comment is a bit misleading don't you think? It depends on the subsequent query what will be the view used for.
   Anyway it does not provide any extra info therefore personally I'm always against adding redundant comments as they easily go out of sync.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10763#issuecomment-570630824
 
 
   <!--
   Meta data
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143024027 TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4084 TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   Hash:da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4090 TriggerType:PUSH TriggerID:da8137a5c135ee86f12bd4cbd33f6aea77c06a14
   Hash:da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143077002 TriggerType:PUSH TriggerID:da8137a5c135ee86f12bd4cbd33f6aea77c06a14
   -->
   ## CI report:
   
   * 19e2bf9244667af4490f1463bdf48ba40d02e5ed Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143024027) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4084) 
   * da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143077002) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4090) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10763#issuecomment-570630824
 
 
   <!--
   Meta data
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143024027 TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   Hash:19e2bf9244667af4490f1463bdf48ba40d02e5ed Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4084 TriggerType:PUSH TriggerID:19e2bf9244667af4490f1463bdf48ba40d02e5ed
   Hash:da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4090 TriggerType:PUSH TriggerID:da8137a5c135ee86f12bd4cbd33f6aea77c06a14
   Hash:da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143077002 TriggerType:PUSH TriggerID:da8137a5c135ee86f12bd4cbd33f6aea77c06a14
   Hash:0bcdc9a62338aefab77a8277e87f10f8afcfc48e Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:0bcdc9a62338aefab77a8277e87f10f8afcfc48e
   -->
   ## CI report:
   
   * 19e2bf9244667af4490f1463bdf48ba40d02e5ed Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143024027) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4084) 
   * da8137a5c135ee86f12bd4cbd33f6aea77c06a14 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143077002) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4090) 
   * 0bcdc9a62338aefab77a8277e87f10f8afcfc48e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dawidwys commented on a change in pull request #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source

Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #10763: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10763#discussion_r363214928
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TemporalJoinITCase.scala
 ##########
 @@ -158,11 +160,87 @@ class TemporalJoinITCase(state: StateBackendMode)
 
     assertEquals(expectedOutput, sink.getAppendResults.toSet)
   }
+
+  @Test
+  def testNestedTemporalJoin(): Unit = {
+    val env = StreamExecutionEnvironment.getExecutionEnvironment
+    val tEnv = StreamTableEnvironment.create(env, TableTestUtil.STREAM_SETTING)
+    env.setStreamTimeCharacteristic(TimeCharacteristic.EventTime)
+
+    val sqlQuery =
+      """
+        |SELECT
+        |  o.amount, r.rate, p.price
 
 Review comment:
   If we are using a real world example, could we make it more useful? 
   
   How about:
   ```
   Orders
     |- orderId: String
     |- productId: String
     |- amount: Long
     |- timestamp: Timestamp
   
   Rates
     |- currency: String
     |- rate: Double
     |- timestamp: Timestamp
   
   Prices
     |- productId: String
     |- currency: String
     |- price: Double
     |- timestamp: Timestamp
   
   Query:
   SELECT
     o.orderId,
     (o.amount * p.price * r.rate) as total_price
   FROM
     Orders AS o,
     LATERAL TABLE (Rates(o.rowtime)) AS r,
     LATERAL TABLE (Prices(o.rowtime)) AS p
   WHERE
     o.productId = p.productId AND 
     r.currency = p.currency
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services