You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/02/04 17:58:20 UTC
[GitHub] [fineract] galovics opened a new pull request #2028: FINERACT-1496: Lazy relationship loading for Loan and it's correspond…
galovics opened a new pull request #2028:
URL: https://github.com/apache/fineract/pull/2028
…ing LoanCollateralManagement entities and removed unnecessary data loads from ApplicationCurrency.
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [x] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #2028: FINERACT-1496: Lazy relationship loading for Loan and it's correspond…
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #2028:
URL: https://github.com/apache/fineract/pull/2028#issuecomment-1030464266
@galovics ... just minor formatting stuff... just do a ```./gradlew spotlessApply``` and push again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic merged pull request #2028: FINERACT-1496: Lazy relationship loading for Loan and it's correspond…
Posted by GitBox <gi...@apache.org>.
vidakovic merged pull request #2028:
URL: https://github.com/apache/fineract/pull/2028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #2028: FINERACT-1496: Lazy relationship loading for Loan and it's correspond…
Posted by GitBox <gi...@apache.org>.
galovics commented on pull request #2028:
URL: https://github.com/apache/fineract/pull/2028#issuecomment-1031492801
Thanks @vidakovic. Let's see if it passes the checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org