You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2019/01/12 02:00:40 UTC
[GitHub] mcvsubbu commented on a change in pull request #3684: Add touch
method in PinotFS; Call touch when moving deleted segments.
mcvsubbu commented on a change in pull request #3684: Add touch method in PinotFS; Call touch when moving deleted segments.
URL: https://github.com/apache/incubator-pinot/pull/3684#discussion_r247298157
##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/SegmentDeletionManager.java
##########
@@ -248,7 +250,7 @@ public void removeAgedDeletedSegments(int retentionInDays) {
}
}
} catch (IOException e) {
- LOGGER.error("Had trouble deleting directories", deletedDirURI.toString());
+ LOGGER.error("Had trouble deleting directories: {}", deletedDirURI.toString(), e.toString());
Review comment:
Good catch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org