You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/08/15 03:06:15 UTC
[GitHub] [arrow] kou opened a new pull request, #37167: GH-37144: [C++] Add RecordBatchFileReader::To{RecordBatches,Table}
kou opened a new pull request, #37167:
URL: https://github.com/apache/arrow/pull/37167
### Rationale for this change
`RecordBatchReader` has them but `RecordBatchFileReader` doesn't. They are convenient.
### What changes are included in this PR?
Add them.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37167: GH-37144: [C++] Add RecordBatchFileReader::To{RecordBatches,Table}
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37167:
URL: https://github.com/apache/arrow/pull/37167#issuecomment-1678363141
:warning: GitHub issue #37144 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #37167: GH-37144: [C++] Add RecordBatchFileReader::To{RecordBatches,Table}
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #37167:
URL: https://github.com/apache/arrow/pull/37167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #37167: GH-37144: [C++] Add RecordBatchFileReader::To{RecordBatches,Table}
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #37167:
URL: https://github.com/apache/arrow/pull/37167#discussion_r1296573973
##########
cpp/src/arrow/table.h:
##########
@@ -75,7 +75,7 @@ class ARROW_EXPORT Table {
/// \brief Construct a Table from a RecordBatchReader.
///
- /// \param[in] reader the arrow::Schema for each batch
+ /// \param[in] reader the arrow::RecordBatchReader that produces batches
static Result<std::shared_ptr<Table>> FromRecordBatchReader(RecordBatchReader* reader);
Review Comment:
If we want this, we'll add this later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #37167: GH-37144: [C++] Add RecordBatchFileReader::To{RecordBatches,Table}
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #37167:
URL: https://github.com/apache/arrow/pull/37167#discussion_r1294142051
##########
cpp/src/arrow/table.h:
##########
@@ -75,7 +75,7 @@ class ARROW_EXPORT Table {
/// \brief Construct a Table from a RecordBatchReader.
///
- /// \param[in] reader the arrow::Schema for each batch
+ /// \param[in] reader the arrow::RecordBatchReader that produces batches
static Result<std::shared_ptr<Table>> FromRecordBatchReader(RecordBatchReader* reader);
Review Comment:
We may want to add `Table::FromRecordBatchFileReader()` like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #37167: GH-37144: [C++] Add RecordBatchFileReader::To{RecordBatches,Table}
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #37167:
URL: https://github.com/apache/arrow/pull/37167#issuecomment-1683880220
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 4fc2731a3ceaf7dd5b1dce6f29bf7cad0ab2f13e.
There were 18 benchmark results indicating a performance regression:
- Commit Run on `ursa-i9-9960x` at [2023-08-17 03:12:46Z](http://conbench.ursa.dev/compare/runs/cf0cce073ec74227bd4d2159e270eb4b...ebc8a30b3b5f4397ab9c803da023bf3d/)
- [`csv-read` (Python) with compression=uncompressed, dataset=nyctaxi_2010-01, output_format=arrow_table, streaming=file](http://conbench.ursa.dev/compare/benchmarks/064dd388820870e48000dc1b5fe28973...064dd90b1ce3765a80006b83127e351a)
- [`csv-read` (Python) with compression=uncompressed, dataset=nyctaxi_2010-01, output_format=arrow_table, streaming=file](http://conbench.ursa.dev/compare/benchmarks/064dd63861f773178000db7c40629cec...064dd90b1ce3765a80006b83127e351a)
- and 16 more (see the report linked below)
The [full Conbench report](https://github.com/apache/arrow/runs/16011730476) has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org