You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/26 02:11:13 UTC

[GitHub] [superset] kamalkeshavani-aiinside opened a new issue #12755: Filter 'IS NULL' in chart causes error in dashboard

kamalkeshavani-aiinside opened a new issue #12755:
URL: https://github.com/apache/superset/issues/12755


   I have a time-series bar chart in which I am using a filter of 'IS NULL' on a column. It works fine in 'Chart Explore' view, but when added in a dashboard it shows **Unexpected Error: 'comparator'**.
   I haven't tried this in all the chart types but I think the issue is common for all charts.
   
   ### Expected results
   
   The chart should show data in dashboard as well.
   
   ### Actual results
   
   The chart shows error when seen from dashboard
   
   #### Screenshots
   
   ![image](https://user-images.githubusercontent.com/74634977/105789020-f4c96480-5fc4-11eb-80c1-594bd429d0fb.png)
   
   
   ![image](https://user-images.githubusercontent.com/74634977/105788481-f5adc680-5fc3-11eb-980f-eaa30e21ead4.png)
   
   
   #### How to reproduce the bug
   
   1. Create a Time-series bar or line chart with a filter of 'IS NULL' on a column(any column)
   2. Save the chart and add to a dashboard
   3. Open dashboard and notice error
   
   ### Environment
   
   - superset version: 1.0.0
   - python version: 3.7
   Using official docker image. 
   
   This issue is not reproduced on Superset 0.36.0
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [ ] I have reproduced the issue with at least the latest released version of superset.
   - [ ] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   ### Additional context
   
   When clicking 'View Chart in Explore' from dashboard showing error, it leads to below error:
   ```
   }
   Sorry, something went wrong
   500 - Internal Server Error
   Stacktrace
           Traceback (most recent call last):
     File "/usr/local/lib/python3.7/site-packages/flask/app.py", line 2447, in wsgi_app
       response = self.full_dispatch_request()
     File "/usr/local/lib/python3.7/site-packages/flask/app.py", line 1952, in full_dispatch_request
       rv = self.handle_user_exception(e)
     File "/usr/local/lib/python3.7/site-packages/flask/app.py", line 1821, in handle_user_exception
       reraise(exc_type, exc_value, tb)
     File "/usr/local/lib/python3.7/site-packages/flask/_compat.py", line 39, in reraise
       raise value
     File "/usr/local/lib/python3.7/site-packages/flask/app.py", line 1950, in full_dispatch_request
       rv = self.dispatch_request()
     File "/usr/local/lib/python3.7/site-packages/flask/app.py", line 1936, in dispatch_request
       return self.view_functions[rule.endpoint](**req.view_args)
     File "/usr/local/lib/python3.7/site-packages/flask_appbuilder/security/decorators.py", line 109, in wraps
       return f(self, *args, **kwargs)
     File "/app/superset/utils/log.py", line 164, in wrapper
       value = f(*args, **kwargs)
     File "/app/superset/views/core.py", line 745, in explore
       utils.merge_extra_filters(form_data)
     File "/app/superset/utils/core.py", line 1028, in merge_extra_filters
       and existing["comparator"] is not None
   KeyError: 'comparator'
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #12755: Filter 'IS NULL' in chart causes error in dashboard

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12755:
URL: https://github.com/apache/superset/issues/12755#issuecomment-767257141


   ![image](https://user-images.githubusercontent.com/67837651/105793559-2fd48500-5f3e-11eb-94f8-6633a8162cfe.png)
   
   @kamalkeshavani-aiinside I'm not able to reproduce in master. i also tried other NVD3 charts. @villebro @zhaoyongjie any idea what this error means


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #12755: Filter 'IS NULL' in chart causes error in dashboard

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12755:
URL: https://github.com/apache/superset/issues/12755#issuecomment-768116898


   thanks @kamalkeshavani-aiinside feel free to close this issue if everything looks good to you :) 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #12755: Filter 'IS NULL' in chart causes error in dashboard

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12755:
URL: https://github.com/apache/superset/issues/12755#issuecomment-767257141


   ![image](https://user-images.githubusercontent.com/67837651/105793559-2fd48500-5f3e-11eb-94f8-6633a8162cfe.png)
   
   @kamalkeshavani-aiinside I'm not able to reproduce in master. i also tried other NVD3 charts. @villebro @zhaoyongjie any idea what this error means


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] kamalkeshavani-aiinside commented on issue #12755: Filter 'IS NULL' in chart causes error in dashboard

Posted by GitBox <gi...@apache.org>.
kamalkeshavani-aiinside commented on issue #12755:
URL: https://github.com/apache/superset/issues/12755#issuecomment-767258044


   @junlincc I haven't tried on latest master, but could see this in 1.0.0. Let me check in master as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] kamalkeshavani-aiinside closed issue #12755: Filter 'IS NULL' in chart causes error in dashboard

Posted by GitBox <gi...@apache.org>.
kamalkeshavani-aiinside closed issue #12755:
URL: https://github.com/apache/superset/issues/12755


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] kamalkeshavani-aiinside commented on issue #12755: Filter 'IS NULL' in chart causes error in dashboard

Posted by GitBox <gi...@apache.org>.
kamalkeshavani-aiinside commented on issue #12755:
URL: https://github.com/apache/superset/issues/12755#issuecomment-767258044






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] krsnik93 commented on issue #12755: Filter 'IS NULL' in chart causes error in dashboard

Posted by GitBox <gi...@apache.org>.
krsnik93 commented on issue #12755:
URL: https://github.com/apache/superset/issues/12755#issuecomment-784331703


   Seeing this as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org