[GitHub] [dolphinscheduler] kyoty commented on pull request #5676: [Improvement] the automatically generated spi service name in alert-plugin is wrong

[GitBox <gi...@apache.org>]

kyoty commented on pull request #5676:
URL: https://github.com/apache/dolphinscheduler/pull/5676#issuecomment-867376043


   
   
       
   
   
   
       font{
           line-height: 1.6;
       }
       ul,ol{
           padding-left: 20px;
           list-style-position: inside;
       }
   
   
       
       ***@***.***, It can't work, I've tried it yesterday.
       
       
        
       
           
                       
               
                   
                       
                               
                                   
                               
                               
                                   echohlne
                               
                       
                           
                               
                                       ***@***.***
                               
                           
                   
               
           
           
       
       
           签名由
           网易邮箱大师
           定制
       
    
   
       On 6/24/2021 14:09，Wenjun ***@***.***> wrote： 
   
   
   
   @ruanwenjun commented on this pull request.
   
   
   
   In dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/plugin/DolphinPluginDiscovery.java:
   > @@ -83,6 +83,7 @@ private DolphinPluginDiscovery() {
    
            return listClasses(file.toPath()).stream()
                    .filter(name -> classInterfaces(name, classLoader).contains(DolphinSchedulerPlugin.class.getName()))
   +                .map(plugin -> plugin.replace(File.separatorChar, '.'))
   
   @kyoty Can we direct use File.separator?
   
   —You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org