You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/09/26 13:48:54 UTC
[PR] Refactor Proxy DistSQL executors into neutral handler modules [shardingsphere]
terrymanu opened a new pull request, #39972:
URL: https://github.com/apache/shardingsphere/pull/39972
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Proxy DistSQL executors into neutral handler modules [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39972:
URL: https://github.com/apache/shardingsphere/pull/39972#issuecomment-5846787414
### Result
**Review Result: Mergeable**
Yes—the 132 substantive uncommitted paths belong to this DistSQL migration. The staging area is empty. Two untracked `.pyc` files are tool caches; exclude them from the commit.
### Suggested Commit Message
Refactor Proxy DistSQL executors into neutral handler modules
Move the 20 open-source executors and their required support code out of
Proxy. Keep Proxy loading them through SPI, with federation PREVIEW and
global-clock snapshot export supplied by their feature modules.
Update module dependencies, service registrations, native metadata, and
the affected tests.
### Review Suggestions
- Check that ordinary PREVIEW still uses the kernel path for sharding and encryption, while the federation SPI handles only queries it selects.
- Review the two new `DistSQLConnectionContext` fields against Proxy’s existing executor and process ID behavior. This is the main shared-contract decision.
- Verify all 20 executor registrations are unique, and check import/export formats, YAML output, and cluster-lock behavior. The `ClusterLockStrategy` class-name break was explicitly approved.
### Evidence
The unchanged source state passed 677 scoped tests, Spotless and Checkstyle for 84 Java files, and RAT. `git diff --check` reports three blank-line indent warnings that match the repository’s Spotless formatting.
### Coverage
Standalone local candidate on `dev` at `887f95d`: 132 task paths reviewed; two tool-cache files excluded. This is a code-scope review; CI was not reviewed. Jev was not used or called because this required multi-file code analysis. It did not affect the review; efficiency change cannot be measured accurately, and no Jev-related problems were found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Proxy DistSQL executors into neutral handler modules [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39972:
URL: https://github.com/apache/shardingsphere/pull/39972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org