You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/21 17:05:19 UTC
[GitHub] [flink] zentol opened a new pull request #19192: [FLINK-26780][coordination] Add tests to force RPC serialization
zentol opened a new pull request #19192:
URL: https://github.com/apache/flink/pull/19192
Based on #19189.
Adds an option to prefer RPC serialization, and enables it for the maven tests. The goal is to find issues like FLINK-26779 without having to write explicit tests for the serialization.
Additionally adds a `Local` annotation to mark RPC calls that can only work without serialization (only used by tests). (Which we could in theory infer automatically based on the types, but I'd rather make this explicit).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #19192: [FLINK-26780][coordination] Add option to force RPC serialization
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #19192:
URL: https://github.com/apache/flink/pull/19192#issuecomment-1075302131
See also [this](https://dev.azure.com/chesnay/flink/_build/results?buildId=2230&view=logs&j=dafbab6d-4616-5d7b-ee37-3c54e4828fd7&t=e204f081-e6cd-5c04-4f4c-919639b63be9) build that discovered FLINK-26779.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19192: [FLINK-26780][coordination] Add tests to force RPC serialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19192:
URL: https://github.com/apache/flink/pull/19192#issuecomment-1074176275
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ea9e023961e446a4010785ebebb46d0a89a8e43",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33536",
"triggerID" : "2ea9e023961e446a4010785ebebb46d0a89a8e43",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ea9e023961e446a4010785ebebb46d0a89a8e43 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33536)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19192: [FLINK-26780][coordination] Add option to force RPC serialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19192:
URL: https://github.com/apache/flink/pull/19192#issuecomment-1074176275
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ea9e023961e446a4010785ebebb46d0a89a8e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33536",
"triggerID" : "2ea9e023961e446a4010785ebebb46d0a89a8e43",
"triggerType" : "PUSH"
}, {
"hash" : "7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33610",
"triggerID" : "7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33610)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19192: [FLINK-26780][coordination] Add option to force RPC serialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19192:
URL: https://github.com/apache/flink/pull/19192#issuecomment-1074176275
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ea9e023961e446a4010785ebebb46d0a89a8e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33536",
"triggerID" : "2ea9e023961e446a4010785ebebb46d0a89a8e43",
"triggerType" : "PUSH"
}, {
"hash" : "7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33610",
"triggerID" : "7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a",
"triggerType" : "PUSH"
}, {
"hash" : "7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33610",
"triggerID" : "1076106210",
"triggerType" : "MANUAL"
}, {
"hash" : "1a34dbe580c9fdc924a9acddda0353a3768d905d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33850",
"triggerID" : "1a34dbe580c9fdc924a9acddda0353a3768d905d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1a34dbe580c9fdc924a9acddda0353a3768d905d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33850)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19192: [FLINK-26780][coordination] Add tests to force RPC serialization
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19192:
URL: https://github.com/apache/flink/pull/19192#issuecomment-1074176275
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ea9e023961e446a4010785ebebb46d0a89a8e43",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2ea9e023961e446a4010785ebebb46d0a89a8e43",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ea9e023961e446a4010785ebebb46d0a89a8e43 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19192: [FLINK-26780][coordination] Add option to force RPC serialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19192:
URL: https://github.com/apache/flink/pull/19192#issuecomment-1074176275
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ea9e023961e446a4010785ebebb46d0a89a8e43",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33536",
"triggerID" : "2ea9e023961e446a4010785ebebb46d0a89a8e43",
"triggerType" : "PUSH"
}, {
"hash" : "7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ea9e023961e446a4010785ebebb46d0a89a8e43 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33536)
* 7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19192: [FLINK-26780][coordination] Add option to force RPC serialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19192:
URL: https://github.com/apache/flink/pull/19192#issuecomment-1074176275
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ea9e023961e446a4010785ebebb46d0a89a8e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33536",
"triggerID" : "2ea9e023961e446a4010785ebebb46d0a89a8e43",
"triggerType" : "PUSH"
}, {
"hash" : "7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33610",
"triggerID" : "7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a",
"triggerType" : "PUSH"
}, {
"hash" : "7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33610",
"triggerID" : "1076106210",
"triggerType" : "MANUAL"
}, {
"hash" : "1a34dbe580c9fdc924a9acddda0353a3768d905d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1a34dbe580c9fdc924a9acddda0353a3768d905d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33610)
* 1a34dbe580c9fdc924a9acddda0353a3768d905d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19192: [FLINK-26780][coordination] Add option to force RPC serialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19192:
URL: https://github.com/apache/flink/pull/19192#issuecomment-1074176275
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ea9e023961e446a4010785ebebb46d0a89a8e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33536",
"triggerID" : "2ea9e023961e446a4010785ebebb46d0a89a8e43",
"triggerType" : "PUSH"
}, {
"hash" : "7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33610",
"triggerID" : "7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a",
"triggerType" : "PUSH"
}, {
"hash" : "7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33610",
"triggerID" : "1076106210",
"triggerType" : "MANUAL"
}, {
"hash" : "1a34dbe580c9fdc924a9acddda0353a3768d905d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33850",
"triggerID" : "1a34dbe580c9fdc924a9acddda0353a3768d905d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33610)
* 1a34dbe580c9fdc924a9acddda0353a3768d905d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33850)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19192: [FLINK-26780][coordination] Add option to force RPC serialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19192:
URL: https://github.com/apache/flink/pull/19192#issuecomment-1074176275
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ea9e023961e446a4010785ebebb46d0a89a8e43",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33536",
"triggerID" : "2ea9e023961e446a4010785ebebb46d0a89a8e43",
"triggerType" : "PUSH"
}, {
"hash" : "7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33610",
"triggerID" : "7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ea9e023961e446a4010785ebebb46d0a89a8e43 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33536)
* 7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33610)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a change in pull request #19192: [FLINK-26780][coordination] Add option to force RPC serialization
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #19192:
URL: https://github.com/apache/flink/pull/19192#discussion_r832180611
##########
File path: flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaInvocationHandler.java
##########
@@ -282,22 +288,27 @@ private Object invokeRpc(Method method, Object[] args) throws Exception {
*
* @param declaringClassName of the RPC
* @param methodName of the RPC
+ * @param isLocalRpcInvocation whether the RPC must be sent as a local message
* @param parameterTypes of the RPC
* @param args of the RPC
* @return RpcInvocation message which encapsulates the RPC details
* @throws IOException if we cannot serialize the RPC invocation parameters
*/
- protected RpcInvocation createRpcInvocationMessage(
+ private RpcInvocation createRpcInvocationMessage(
Review comment:
It was unnecessarily labeled as `protected`, wasn't it?
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java
##########
@@ -30,6 +32,18 @@
@PublicEvolving
public class AkkaOptions {
+ @Internal
+ @Documentation.ExcludeFromDocumentation("Internal use only")
Review comment:
Can we add more documentation here? Some description on what this configuration option is used for
##########
File path: flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaInvocationHandler.java
##########
@@ -282,22 +288,27 @@ private Object invokeRpc(Method method, Object[] args) throws Exception {
*
* @param declaringClassName of the RPC
* @param methodName of the RPC
+ * @param isLocalRpcInvocation whether the RPC must be sent as a local message
* @param parameterTypes of the RPC
* @param args of the RPC
* @return RpcInvocation message which encapsulates the RPC details
* @throws IOException if we cannot serialize the RPC invocation parameters
*/
- protected RpcInvocation createRpcInvocationMessage(
+ private RpcInvocation createRpcInvocationMessage(
final String declaringClassName,
final String methodName,
+ final boolean isLocalRpcInvocation,
final Class<?>[] parameterTypes,
final Object[] args)
throws IOException {
final RpcInvocation rpcInvocation;
- if (isLocal) {
+ if (isLocal && (!forceRpcInvocationSerialization || isLocalRpcInvocation)) {
rpcInvocation =
new LocalRpcInvocation(declaringClassName, methodName, parameterTypes, args);
+ } else if (forceRpcInvocationSerialization) {
+ rpcInvocation =
+ new RemoteRpcInvocation(declaringClassName, methodName, parameterTypes, args);
Review comment:
This `else if` triggers the same content as the `else` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19192: [FLINK-26780][coordination] Add option to force RPC serialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19192:
URL: https://github.com/apache/flink/pull/19192#issuecomment-1074176275
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ea9e023961e446a4010785ebebb46d0a89a8e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33536",
"triggerID" : "2ea9e023961e446a4010785ebebb46d0a89a8e43",
"triggerType" : "PUSH"
}, {
"hash" : "7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33610",
"triggerID" : "7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a",
"triggerType" : "PUSH"
}, {
"hash" : "7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33610",
"triggerID" : "1076106210",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33610)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19192: [FLINK-26780][coordination] Add option to force RPC serialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19192:
URL: https://github.com/apache/flink/pull/19192#issuecomment-1074176275
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ea9e023961e446a4010785ebebb46d0a89a8e43",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33536",
"triggerID" : "2ea9e023961e446a4010785ebebb46d0a89a8e43",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ea9e023961e446a4010785ebebb46d0a89a8e43 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33536)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19192: [FLINK-26780][coordination] Add option to force RPC serialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19192:
URL: https://github.com/apache/flink/pull/19192#issuecomment-1074176275
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ea9e023961e446a4010785ebebb46d0a89a8e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33536",
"triggerID" : "2ea9e023961e446a4010785ebebb46d0a89a8e43",
"triggerType" : "PUSH"
}, {
"hash" : "7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33610",
"triggerID" : "7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a",
"triggerType" : "PUSH"
}, {
"hash" : "7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33610",
"triggerID" : "1076106210",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33610)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #19192: [FLINK-26780][coordination] Add option to force RPC serialization
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #19192:
URL: https://github.com/apache/flink/pull/19192#issuecomment-1075284966
> how I can test the behavior locally
Revert FLINK-26779, enable the new option, run `RMQSourceITCase.testStopWithSavepoint` (or any test that uses stopWithSavepoint via the Rest API).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19192: [FLINK-26780][coordination] Add option to force RPC serialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19192:
URL: https://github.com/apache/flink/pull/19192#issuecomment-1074176275
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ea9e023961e446a4010785ebebb46d0a89a8e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33536",
"triggerID" : "2ea9e023961e446a4010785ebebb46d0a89a8e43",
"triggerType" : "PUSH"
}, {
"hash" : "7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33610",
"triggerID" : "7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a",
"triggerType" : "PUSH"
}, {
"hash" : "7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33610",
"triggerID" : "1076106210",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 7dc9d74b1734479ea8fd9ba3e99b7ef988fda52a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33610)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #19192: [FLINK-26780][coordination] Add option to force RPC serialization
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #19192:
URL: https://github.com/apache/flink/pull/19192#issuecomment-1076106210
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #19192: [FLINK-26780][coordination] Add option to force RPC serialization
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #19192:
URL: https://github.com/apache/flink/pull/19192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org