You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bharat kumar <bh...@citrix.com> on 2013/07/31 16:53:28 UTC
Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema
Inconsistencies on the Upgraded Setup - Table "volumes"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13112/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
Bugs: Cloudstack-3836
Repository: cloudstack-git
Description
-------
upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"
https://issues.apache.org/jira/browse/CLOUDSTACK-3836
This extra column is because of the fix
Parent id of template incorrectly recorded as last ISO attached to VM.
when a template is created form the snapshot the sourcetemplateid is recorded as the iso attached to the VM at thee time of creation.
we fix this by adding a iso_id column to the volume table. when a template is created from the snapshot we fetch the iso_id form the parent volume and set it as the sourcetemplated id of the newly created template.
Diffs
-----
engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99
engine/schema/src/com/cloud/upgrade/dao/DbUpgradeUtils.java c37be3e
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 13074cf
server/src/com/cloud/storage/VolumeManager.java 2e44a3c
server/src/com/cloud/storage/VolumeManagerImpl.java d8cbf11
server/src/com/cloud/template/TemplateManagerImpl.java 8ccc567
server/src/com/cloud/vm/VirtualMachineManagerImpl.java eedf4d2
setup/db/db/schema-410to420.sql 9cdf837
Diff: https://reviews.apache.org/r/13112/diff/
Testing
-------
Tested on 4.2.
Thanks,
bharat kumar
Re: Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema
Inconsistencies on the Upgraded Setup - Table "volumes"
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13112/#review24349
-----------------------------------------------------------
Review 13112 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #94 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/94/
- Jenkins Cloudstack.org
On July 31, 2013, 2:53 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13112/
> -----------------------------------------------------------
>
> (Updated July 31, 2013, 2:53 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Bugs: Cloudstack-3836
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"
> https://issues.apache.org/jira/browse/CLOUDSTACK-3836
>
> This extra column is because of the fix
> Parent id of template incorrectly recorded as last ISO attached to VM.
>
> when a template is created form the snapshot the sourcetemplateid is recorded as the iso attached to the VM at thee time of creation.
>
> we fix this by adding a iso_id column to the volume table. when a template is created from the snapshot we fetch the iso_id form the parent volume and set it as the sourcetemplated id of the newly created template.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99
> engine/schema/src/com/cloud/upgrade/dao/DbUpgradeUtils.java c37be3e
> engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 13074cf
> server/src/com/cloud/storage/VolumeManager.java 2e44a3c
> server/src/com/cloud/storage/VolumeManagerImpl.java d8cbf11
> server/src/com/cloud/template/TemplateManagerImpl.java 8ccc567
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java eedf4d2
> setup/db/db/schema-410to420.sql 9cdf837
>
> Diff: https://reviews.apache.org/r/13112/diff/
>
>
> Testing
> -------
>
> Tested on 4.2.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema
Inconsistencies on the Upgraded Setup - Table "volumes"
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13112/#review24433
-----------------------------------------------------------
failed to apply on 4.2 and master
Applying: 3.0.6 to ASF 4.2 Upgrade: "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"
error: patch failed: setup/db/db/schema-410to420.sql:2207
error: setup/db/db/schema-410to420.sql: patch does not apply
Patch failed at 0001 3.0.6 to ASF 4.2 Upgrade: "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"
The copy of the patch that failed is found in:
/Users/agneya2001/citrix/asf/.git/rebase-apply/patch
- Abhinandan Prateek
On July 31, 2013, 7:17 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13112/
> -----------------------------------------------------------
>
> (Updated July 31, 2013, 7:17 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Bugs: Cloudstack-3836
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"
> https://issues.apache.org/jira/browse/CLOUDSTACK-3836
>
> This extra column is because of the fix
> Parent id of template incorrectly recorded as last ISO attached to VM.
>
> when a template is created form the snapshot the sourcetemplateid is recorded as the iso attached to the VM at thee time of creation.
>
> we fix this by adding a iso_id column to the volume table. when a template is created from the snapshot we fetch the iso_id form the parent volume and set it as the sourcetemplated id of the newly created template.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99
> engine/schema/src/com/cloud/upgrade/dao/DbUpgradeUtils.java c37be3e
> engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 13074cf
> server/src/com/cloud/storage/VolumeManager.java 2e44a3c
> server/src/com/cloud/storage/VolumeManagerImpl.java d8cbf11
> server/src/com/cloud/template/TemplateManagerImpl.java 8ccc567
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java eedf4d2
> setup/db/db/schema-307to410.sql be6c17d
> setup/db/db/schema-410to420.sql 9cdf837
>
> Diff: https://reviews.apache.org/r/13112/diff/
>
>
> Testing
> -------
>
> Tested on 4.2.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema
Inconsistencies on the Upgraded Setup - Table "volumes"
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13112/
-----------------------------------------------------------
(Updated Aug. 2, 2013, 11:16 a.m.)
Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
Changes
-------
rebased with master.
Bugs: Cloudstack-3836
Repository: cloudstack-git
Description
-------
upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"
https://issues.apache.org/jira/browse/CLOUDSTACK-3836
This extra column is because of the fix
Parent id of template incorrectly recorded as last ISO attached to VM.
when a template is created form the snapshot the sourcetemplateid is recorded as the iso attached to the VM at thee time of creation.
we fix this by adding a iso_id column to the volume table. when a template is created from the snapshot we fetch the iso_id form the parent volume and set it as the sourcetemplated id of the newly created template.
Diffs (updated)
-----
engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99
server/src/com/cloud/storage/VolumeManager.java 13ddbab
server/src/com/cloud/storage/VolumeManagerImpl.java 393904e
server/src/com/cloud/template/TemplateManagerImpl.java d26ebe2
server/src/com/cloud/vm/VirtualMachineManagerImpl.java 08bca43
setup/db/db/schema-307to410.sql be6c17d
setup/db/db/schema-410to420.sql 657d947
Diff: https://reviews.apache.org/r/13112/diff/
Testing
-------
Tested on 4.2.
Thanks,
bharat kumar
Re: Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema
Inconsistencies on the Upgraded Setup - Table "volumes"
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13112/#review24518
-----------------------------------------------------------
Ship it!
Ship It!
- Abhinandan Prateek
On Aug. 1, 2013, 6:01 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13112/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2013, 6:01 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Bugs: Cloudstack-3836
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"
> https://issues.apache.org/jira/browse/CLOUDSTACK-3836
>
> This extra column is because of the fix
> Parent id of template incorrectly recorded as last ISO attached to VM.
>
> when a template is created form the snapshot the sourcetemplateid is recorded as the iso attached to the VM at thee time of creation.
>
> we fix this by adding a iso_id column to the volume table. when a template is created from the snapshot we fetch the iso_id form the parent volume and set it as the sourcetemplated id of the newly created template.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99
> server/src/com/cloud/storage/VolumeManager.java 13ddbab
> server/src/com/cloud/storage/VolumeManagerImpl.java 3cce8b6
> server/src/com/cloud/template/TemplateManagerImpl.java d26ebe2
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java 5b7aa5b
> setup/db/db/schema-307to410.sql be6c17d
> setup/db/db/schema-410to420.sql 99a0208
>
> Diff: https://reviews.apache.org/r/13112/diff/
>
>
> Testing
> -------
>
> Tested on 4.2.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema
Inconsistencies on the Upgraded Setup - Table "volumes"
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13112/
-----------------------------------------------------------
(Updated Aug. 1, 2013, 6:01 p.m.)
Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
Changes
-------
rebased with master
Bugs: Cloudstack-3836
Repository: cloudstack-git
Description
-------
upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"
https://issues.apache.org/jira/browse/CLOUDSTACK-3836
This extra column is because of the fix
Parent id of template incorrectly recorded as last ISO attached to VM.
when a template is created form the snapshot the sourcetemplateid is recorded as the iso attached to the VM at thee time of creation.
we fix this by adding a iso_id column to the volume table. when a template is created from the snapshot we fetch the iso_id form the parent volume and set it as the sourcetemplated id of the newly created template.
Diffs (updated)
-----
engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99
server/src/com/cloud/storage/VolumeManager.java 13ddbab
server/src/com/cloud/storage/VolumeManagerImpl.java 3cce8b6
server/src/com/cloud/template/TemplateManagerImpl.java d26ebe2
server/src/com/cloud/vm/VirtualMachineManagerImpl.java 5b7aa5b
setup/db/db/schema-307to410.sql be6c17d
setup/db/db/schema-410to420.sql 99a0208
Diff: https://reviews.apache.org/r/13112/diff/
Testing
-------
Tested on 4.2.
Thanks,
bharat kumar
Re: Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema
Inconsistencies on the Upgraded Setup - Table "volumes"
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13112/
-----------------------------------------------------------
(Updated Aug. 1, 2013, 5:08 p.m.)
Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
Changes
-------
Missed a change while rebasing with 4.2
Bugs: Cloudstack-3836
Repository: cloudstack-git
Description
-------
upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"
https://issues.apache.org/jira/browse/CLOUDSTACK-3836
This extra column is because of the fix
Parent id of template incorrectly recorded as last ISO attached to VM.
when a template is created form the snapshot the sourcetemplateid is recorded as the iso attached to the VM at thee time of creation.
we fix this by adding a iso_id column to the volume table. when a template is created from the snapshot we fetch the iso_id form the parent volume and set it as the sourcetemplated id of the newly created template.
Diffs (updated)
-----
engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99
server/src/com/cloud/storage/VolumeManager.java 2e44a3c
server/src/com/cloud/storage/VolumeManagerImpl.java d8cbf11
server/src/com/cloud/template/TemplateManagerImpl.java 8ccc567
server/src/com/cloud/vm/VirtualMachineManagerImpl.java eedf4d2
setup/db/db/schema-307to410.sql be6c17d
setup/db/db/schema-410to420.sql 3f25c3b
Diff: https://reviews.apache.org/r/13112/diff/
Testing
-------
Tested on 4.2.
Thanks,
bharat kumar
Re: Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema
Inconsistencies on the Upgraded Setup - Table "volumes"
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13112/
-----------------------------------------------------------
(Updated Aug. 1, 2013, 4:51 p.m.)
Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
Changes
-------
rebased with master.
Bugs: Cloudstack-3836
Repository: cloudstack-git
Description
-------
upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"
https://issues.apache.org/jira/browse/CLOUDSTACK-3836
This extra column is because of the fix
Parent id of template incorrectly recorded as last ISO attached to VM.
when a template is created form the snapshot the sourcetemplateid is recorded as the iso attached to the VM at thee time of creation.
we fix this by adding a iso_id column to the volume table. when a template is created from the snapshot we fetch the iso_id form the parent volume and set it as the sourcetemplated id of the newly created template.
Diffs (updated)
-----
engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99
server/src/com/cloud/storage/VolumeManager.java 13ddbab
server/src/com/cloud/storage/VolumeManagerImpl.java 3cce8b6
server/src/com/cloud/template/TemplateManagerImpl.java d26ebe2
server/src/com/cloud/vm/VirtualMachineManagerImpl.java 5b7aa5b
setup/db/db/schema-307to410.sql be6c17d
setup/db/db/schema-410to420.sql 99a0208
Diff: https://reviews.apache.org/r/13112/diff/
Testing
-------
Tested on 4.2.
Thanks,
bharat kumar
Re: Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema
Inconsistencies on the Upgraded Setup - Table "volumes"
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13112/
-----------------------------------------------------------
(Updated Aug. 1, 2013, 4:34 p.m.)
Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
Changes
-------
rebased with 4.2
Bugs: Cloudstack-3836
Repository: cloudstack-git
Description
-------
upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"
https://issues.apache.org/jira/browse/CLOUDSTACK-3836
This extra column is because of the fix
Parent id of template incorrectly recorded as last ISO attached to VM.
when a template is created form the snapshot the sourcetemplateid is recorded as the iso attached to the VM at thee time of creation.
we fix this by adding a iso_id column to the volume table. when a template is created from the snapshot we fetch the iso_id form the parent volume and set it as the sourcetemplated id of the newly created template.
Diffs (updated)
-----
engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99
server/src/com/cloud/storage/VolumeManager.java 2e44a3c
server/src/com/cloud/storage/VolumeManagerImpl.java d8cbf11
server/src/com/cloud/template/TemplateManagerImpl.java 8ccc567
server/src/com/cloud/vm/VirtualMachineManagerImpl.java eedf4d2
setup/db/db/schema-410to420.sql 3f25c3b
Diff: https://reviews.apache.org/r/13112/diff/
Testing
-------
Tested on 4.2.
Thanks,
bharat kumar
Re: Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema
Inconsistencies on the Upgraded Setup - Table "volumes"
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13112/
-----------------------------------------------------------
(Updated July 31, 2013, 7:17 p.m.)
Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
Changes
-------
Chaged the way we handle upgrade. now we remove the column iso_id in schema307-401 and
add iso_id in schema401-402.
Bugs: Cloudstack-3836
Repository: cloudstack-git
Description
-------
upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"
https://issues.apache.org/jira/browse/CLOUDSTACK-3836
This extra column is because of the fix
Parent id of template incorrectly recorded as last ISO attached to VM.
when a template is created form the snapshot the sourcetemplateid is recorded as the iso attached to the VM at thee time of creation.
we fix this by adding a iso_id column to the volume table. when a template is created from the snapshot we fetch the iso_id form the parent volume and set it as the sourcetemplated id of the newly created template.
Diffs (updated)
-----
engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99
engine/schema/src/com/cloud/upgrade/dao/DbUpgradeUtils.java c37be3e
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 13074cf
server/src/com/cloud/storage/VolumeManager.java 2e44a3c
server/src/com/cloud/storage/VolumeManagerImpl.java d8cbf11
server/src/com/cloud/template/TemplateManagerImpl.java 8ccc567
server/src/com/cloud/vm/VirtualMachineManagerImpl.java eedf4d2
setup/db/db/schema-307to410.sql be6c17d
setup/db/db/schema-410to420.sql 9cdf837
Diff: https://reviews.apache.org/r/13112/diff/
Testing
-------
Tested on 4.2.
Thanks,
bharat kumar