You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Adam B <ad...@mesosphere.io> on 2014/06/03 19:29:26 UTC
Re: Review Request 21713: Route overload to add auth HTTP Response + tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21713/#review44643
-----------------------------------------------------------
Great stuff. Just a couple of comments from me.
3rdparty/libprocess/include/process/process.hpp
<https://reviews.apache.org/r/21713/#comment79057>
Or you could default to an empty vector, and treat that as no authorization.
3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/21713/#comment79055>
name vs. name.substr(1)?
3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/21713/#comment79056>
name vs. name.substr(1)?
3rdparty/libprocess/src/tests/http_tests.cpp
<https://reviews.apache.org/r/21713/#comment79058>
auth2 is only expected to actually be called for the "right auth header"? If so, put the expectation down by that section.
- Adam B
On May 20, 2014, 10:20 a.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21713/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 10:20 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, and Dominic Hamon.
>
>
> Bugs: MESOS-1131
> https://issues.apache.org/jira/browse/MESOS-1131
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Depends on : https://reviews.apache.org/r/21324/
> 3rd phase following Ben's comments on https://reviews.apache.org/r/19575/
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/base64.hpp 1f0944a
> 3rdparty/libprocess/include/process/process.hpp c29cd21
> 3rdparty/libprocess/src/process.cpp 58bae5b
> 3rdparty/libprocess/src/tests/http_tests.cpp f58a129
>
> Diff: https://reviews.apache.org/r/21713/diff/
>
>
> Testing
> -------
>
> Make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 21713: Route overload to add auth HTTP Response +
tests
Posted by Adam B <ad...@mesosphere.io>.
> On June 3, 2014, 10:29 a.m., Adam B wrote:
> > Great stuff. Just a couple of comments from me.
@ijimenez Is this patch still necessary? If not, let's discard it. If so, please rebase and revive it. Thanks.
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21713/#review44643
-----------------------------------------------------------
On May 20, 2014, 10:20 a.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21713/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 10:20 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, and Dominic Hamon.
>
>
> Bugs: MESOS-1131
> https://issues.apache.org/jira/browse/MESOS-1131
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Depends on : https://reviews.apache.org/r/21324/
> 3rd phase following Ben's comments on https://reviews.apache.org/r/19575/
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/base64.hpp 1f0944a
> 3rdparty/libprocess/include/process/process.hpp c29cd21
> 3rdparty/libprocess/src/process.cpp 58bae5b
> 3rdparty/libprocess/src/tests/http_tests.cpp f58a129
>
> Diff: https://reviews.apache.org/r/21713/diff/
>
>
> Testing
> -------
>
> Make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>