You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "liferoad (via GitHub)" <gi...@apache.org> on 2023/05/10 20:30:13 UTC

[GitHub] [beam] liferoad opened a new pull request, #26650: proposal for more reviewers

liferoad opened a new pull request, #26650:
URL: https://github.com/apache/beam/pull/26650

   The proposal to add more IO reviewers for the bot.
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bvolpato commented on pull request #26650: proposal for more reviewers

Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on PR #26650:
URL: https://github.com/apache/beam/pull/26650#issuecomment-1543027274

   Agreed in participating in the Java / IO. Might have some learning curve especially on the Java side, but I think this will be good to expand my context here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #26650: proposal for more reviewers

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26650:
URL: https://github.com/apache/beam/pull/26650#issuecomment-1542809899

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @Abacn for label build.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] liferoad commented on pull request #26650: proposal for more reviewers

Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on PR #26650:
URL: https://github.com/apache/beam/pull/26650#issuecomment-1542771419

   R: kennknowles


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on a diff in pull request #26650: proposal for more reviewers

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #26650:
URL: https://github.com/apache/beam/pull/26650#discussion_r1190387028


##########
.github/REVIEWERS.yml:
##########
@@ -45,6 +48,18 @@ labels:
       - pabloem
       - Abacn
       - ahmedabu98
+      - bvolpato
+      - manavgarg
+    exclusionList: []
+  - name: spanner
+    reviewers:
+      - nielm
+    exclusionList: []
+  - name: pubsub
+    reviewers:
+      - johnjcasey
+      - manavgarg
+      - bvolpato

Review Comment:
   I'd vote to remove this. This will already go to the IO team which contains all of these people and probably has sufficient expertise to effectively round robin reviews



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm merged pull request #26650: proposal for more reviewers

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #26650:
URL: https://github.com/apache/beam/pull/26650


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] riteshghorse commented on pull request #26650: proposal for more reviewers

Posted by "riteshghorse (via GitHub)" <gi...@apache.org>.
riteshghorse commented on PR #26650:
URL: https://github.com/apache/beam/pull/26650#issuecomment-1542872515

   I'm fine for my addition to Python list.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] manavgarg commented on pull request #26650: proposal for more reviewers

Posted by "manavgarg (via GitHub)" <gi...@apache.org>.
manavgarg commented on PR #26650:
URL: https://github.com/apache/beam/pull/26650#issuecomment-1543400778

   I am willing to be added to the IO list. Have limited knowledge & might have a learning curve but would like to contribute and increase my knowldge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bvolpato commented on a diff in pull request #26650: proposal for more reviewers

Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on code in PR #26650:
URL: https://github.com/apache/beam/pull/26650#discussion_r1190534045


##########
.github/REVIEWERS.yml:
##########
@@ -45,6 +48,18 @@ labels:
       - pabloem
       - Abacn
       - ahmedabu98
+      - bvolpato
+      - manavgarg
+    exclusionList: []
+  - name: spanner
+    reviewers:
+      - nielm
+    exclusionList: []
+  - name: pubsub
+    reviewers:
+      - johnjcasey
+      - manavgarg
+      - bvolpato

Review Comment:
   I think this is fair. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] liferoad commented on pull request #26650: proposal for more reviewers

Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on PR #26650:
URL: https://github.com/apache/beam/pull/26650#issuecomment-1542771710

   R: damccorm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] liferoad commented on a diff in pull request #26650: proposal for more reviewers

Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on code in PR #26650:
URL: https://github.com/apache/beam/pull/26650#discussion_r1191368696


##########
.github/REVIEWERS.yml:
##########
@@ -45,6 +48,18 @@ labels:
       - pabloem
       - Abacn
       - ahmedabu98
+      - bvolpato
+      - manavgarg
+    exclusionList: []
+  - name: spanner
+    reviewers:
+      - nielm
+    exclusionList: []
+  - name: pubsub
+    reviewers:
+      - johnjcasey
+      - manavgarg
+      - bvolpato

Review Comment:
   SG.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] liferoad commented on a diff in pull request #26650: proposal for more reviewers

Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on code in PR #26650:
URL: https://github.com/apache/beam/pull/26650#discussion_r1191407440


##########
.github/REVIEWERS.yml:
##########
@@ -45,6 +48,18 @@ labels:
       - pabloem
       - Abacn
       - ahmedabu98
+      - bvolpato
+      - manavgarg
+    exclusionList: []
+  - name: spanner
+    reviewers:
+      - nielm

Review Comment:
   @nielm FYI.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] liferoad commented on a diff in pull request #26650: proposal for more reviewers

Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on code in PR #26650:
URL: https://github.com/apache/beam/pull/26650#discussion_r1191215794


##########
.github/REVIEWERS.yml:
##########
@@ -45,6 +48,18 @@ labels:
       - pabloem
       - Abacn
       - ahmedabu98
+      - bvolpato
+      - manavgarg
+    exclusionList: []
+  - name: spanner
+    reviewers:
+      - nielm

Review Comment:
   @kennknowles Do you know other people could help reviewing spanner?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org