You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/12/10 22:57:54 UTC

[GitHub] [incubator-pinot] codecov-io commented on issue #4907: Replacing usage of Class.forName with PluginManager.createInstance

codecov-io commented on issue #4907: Replacing usage of Class.forName with PluginManager.createInstance
URL: https://github.com/apache/incubator-pinot/pull/4907#issuecomment-564297930
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4907?src=pr&el=h1) Report
   > Merging [#4907](https://codecov.io/gh/apache/incubator-pinot/pull/4907?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/1c582ed489869f3d863e58b321d52f43d538d0ae?src=pr&el=desc) will **decrease** coverage by `6.59%`.
   > The diff coverage is `54.54%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4907/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4907?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##             master    #4907     +/-   ##
   ===========================================
   - Coverage     56.45%   49.85%   -6.6%     
     Complexity       53       53             
   ===========================================
     Files          1178     1178             
     Lines         62922    62925      +3     
     Branches       9232     9232             
   ===========================================
   - Hits          35523    31372   -4151     
   - Misses        24765    29117   +4352     
   + Partials       2634     2436    -198
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4907?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rg/apache/pinot/spi/stream/StreamDataProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4907/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvc3RyZWFtL1N0cmVhbURhdGFQcm92aWRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...inot/spi/stream/StreamConsumerFactoryProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4907/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvc3RyZWFtL1N0cmVhbUNvbnN1bWVyRmFjdG9yeVByb3ZpZGVyLmphdmE=) | `62.5% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [....pinot.thrift.data.readers/ThriftRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4907/diff?src=pr&el=tree#diff-cGlub3QtcmVjb3JkLXJlYWRlcnMvcGlub3QtdGhyaWZ0L3NyYy9tYWluL2phdmEvb3JnLmFwYWNoZS5waW5vdC50aHJpZnQuZGF0YS5yZWFkZXJzL1RocmlmdFJlY29yZFJlYWRlci5qYXZh) | `81.48% <100%> (ø)` | `13 <0> (ø)` | :arrow_down: |
   | [...apache/pinot/spi/stream/StreamDecoderProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4907/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvc3RyZWFtL1N0cmVhbURlY29kZXJQcm92aWRlci5qYXZh) | `70% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...he/pinot/spi/data/readers/RecordReaderFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4907/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9yZWFkZXJzL1JlY29yZFJlYWRlckZhY3RvcnkuamF2YQ==) | `58.33% <33.33%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...rg/apache/pinot/spi/crypt/PinotCrypterFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4907/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY3J5cHQvUGlub3RDcnlwdGVyRmFjdG9yeS5qYXZh) | `75% <50%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...va/org/apache/pinot/filesystem/PinotFSFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4907/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9maWxlc3lzdGVtL1Bpbm90RlNGYWN0b3J5LmphdmE=) | `82.85% <50%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ava/org/apache/pinot/spi/plugin/PluginManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4907/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvcGx1Z2luL1BsdWdpbk1hbmFnZXIuamF2YQ==) | `41.66% <60%> (+41.66%)` | `0 <0> (ø)` | :arrow_down: |
   | [.../apache/pinot/common/metrics/BrokerQueryPhase.java](https://codecov.io/gh/apache/incubator-pinot/pull/4907/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Ccm9rZXJRdWVyeVBoYXNlLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | [...g/apache/pinot/sql/parsers/CalciteSqlCompiler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4907/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9DYWxjaXRlU3FsQ29tcGlsZXIuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | ... and [261 more](https://codecov.io/gh/apache/incubator-pinot/pull/4907/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4907?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4907?src=pr&el=footer). Last update [1c582ed...5795886](https://codecov.io/gh/apache/incubator-pinot/pull/4907?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org