You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Toshihiro Suzuki <br...@apache.org> on 2019/07/11 03:47:39 UTC
Can we remove OfflineMetaRepair in the master branch and branch-2+?
Hi folks!
I think we no longer support OfflineMetaRepair in HBase-2.x and it has a
critical bug that breaks the meta data:
https://issues.apache.org/jira/browse/HBASE-21665
Actually, I have seen several cases where some users ran OfflineMetaRepair
mistakenly in their cluster and corrupted their meta data.
Also, new meta rebuilding tool is being developed by Wellington at the
moment in HBCK2:
https://issues.apache.org/jira/browse/HBASE-22567
So I think we can remove OfflineMetaRepair in the master branch and
branch-2+. What do you think?
If no objections, I'll file this in Apache Jira.
Regards,
Toshi
Re: Can we remove OfflineMetaRepair in the master branch and branch-2+?
Posted by Toshihiro Suzuki <br...@apache.org>.
Thank you for your replies, guys!
Then, I will file this in Apache Jira.
> or better, as per Duo, output a message pointing user to hbck2 operator
tools
Sure, I will do that.
On Sat, Jul 13, 2019 at 12:12 AM Stack <st...@duboce.net> wrote:
> +1 on removal in 2.0+ (or better, as per Duo, output a message pointing
> user to hbck2 operator tools). Yes, OMR destroys the hbase2 meta table. It
> is in violation of our attempt at having hbck1 tooling be read-only in
> hbase2.
>
> Thanks for bringing this up Toshihiro,
> S
>
> On Wed, Jul 10, 2019 at 8:47 PM Toshihiro Suzuki <br...@apache.org>
> wrote:
>
> > Hi folks!
> >
> > I think we no longer support OfflineMetaRepair in HBase-2.x and it has a
> > critical bug that breaks the meta data:
> > https://issues.apache.org/jira/browse/HBASE-21665
> >
> > Actually, I have seen several cases where some users ran
> OfflineMetaRepair
> > mistakenly in their cluster and corrupted their meta data.
> >
> > Also, new meta rebuilding tool is being developed by Wellington at the
> > moment in HBCK2:
> > https://issues.apache.org/jira/browse/HBASE-22567
> >
> > So I think we can remove OfflineMetaRepair in the master branch and
> > branch-2+. What do you think?
> >
> > If no objections, I'll file this in Apache Jira.
> >
> > Regards,
> > Toshi
> >
>
Re: Can we remove OfflineMetaRepair in the master branch and branch-2+?
Posted by Stack <st...@duboce.net>.
+1 on removal in 2.0+ (or better, as per Duo, output a message pointing
user to hbck2 operator tools). Yes, OMR destroys the hbase2 meta table. It
is in violation of our attempt at having hbck1 tooling be read-only in
hbase2.
Thanks for bringing this up Toshihiro,
S
On Wed, Jul 10, 2019 at 8:47 PM Toshihiro Suzuki <br...@apache.org>
wrote:
> Hi folks!
>
> I think we no longer support OfflineMetaRepair in HBase-2.x and it has a
> critical bug that breaks the meta data:
> https://issues.apache.org/jira/browse/HBASE-21665
>
> Actually, I have seen several cases where some users ran OfflineMetaRepair
> mistakenly in their cluster and corrupted their meta data.
>
> Also, new meta rebuilding tool is being developed by Wellington at the
> moment in HBCK2:
> https://issues.apache.org/jira/browse/HBASE-22567
>
> So I think we can remove OfflineMetaRepair in the master branch and
> branch-2+. What do you think?
>
> If no objections, I'll file this in Apache Jira.
>
> Regards,
> Toshi
>
Re: Can we remove OfflineMetaRepair in the master branch and branch-2+?
Posted by Wellington Chevreuil <we...@gmail.com>.
>
> Actually, I have seen several cases where some users ran OfflineMetaRepair
> mistakenly in their cluster and corrupted their meta data.
>
+1 to remove it, just had another of those this morning. There's
now HBASE-22680 to eventually port it to operators-tool as well.
Em sex, 12 de jul de 2019 às 03:04, 张铎(Duo Zhang) <pa...@gmail.com>
escreveu:
> +1. If it always fails then let's remove it.
> Or keep it there, but when user wants to execute it we just output a
> warning message to say that this tool is no longer supported as it will
> mess up your cluster.
>
> Vladimir Rodionov <vl...@gmail.com> 于2019年7月12日周五 上午12:01写道：
>
> > +1. It has always been obscure tool.
> >
> > On Wed, Jul 10, 2019 at 8:47 PM Toshihiro Suzuki <br...@apache.org>
> > wrote:
> >
> > > Hi folks!
> > >
> > > I think we no longer support OfflineMetaRepair in HBase-2.x and it has
> a
> > > critical bug that breaks the meta data:
> > > https://issues.apache.org/jira/browse/HBASE-21665
> > >
> > > Actually, I have seen several cases where some users ran
> > OfflineMetaRepair
> > > mistakenly in their cluster and corrupted their meta data.
> > >
> > > Also, new meta rebuilding tool is being developed by Wellington at the
> > > moment in HBCK2:
> > > https://issues.apache.org/jira/browse/HBASE-22567
> > >
> > > So I think we can remove OfflineMetaRepair in the master branch and
> > > branch-2+. What do you think?
> > >
> > > If no objections, I'll file this in Apache Jira.
> > >
> > > Regards,
> > > Toshi
> > >
> >
>
Re: Can we remove OfflineMetaRepair in the master branch and branch-2+?
Posted by "张铎 (Duo Zhang)" <pa...@gmail.com>.
+1. If it always fails then let's remove it.
Or keep it there, but when user wants to execute it we just output a
warning message to say that this tool is no longer supported as it will
mess up your cluster.
Vladimir Rodionov <vl...@gmail.com> 于2019年7月12日周五 上午12:01写道：
> +1. It has always been obscure tool.
>
> On Wed, Jul 10, 2019 at 8:47 PM Toshihiro Suzuki <br...@apache.org>
> wrote:
>
> > Hi folks!
> >
> > I think we no longer support OfflineMetaRepair in HBase-2.x and it has a
> > critical bug that breaks the meta data:
> > https://issues.apache.org/jira/browse/HBASE-21665
> >
> > Actually, I have seen several cases where some users ran
> OfflineMetaRepair
> > mistakenly in their cluster and corrupted their meta data.
> >
> > Also, new meta rebuilding tool is being developed by Wellington at the
> > moment in HBCK2:
> > https://issues.apache.org/jira/browse/HBASE-22567
> >
> > So I think we can remove OfflineMetaRepair in the master branch and
> > branch-2+. What do you think?
> >
> > If no objections, I'll file this in Apache Jira.
> >
> > Regards,
> > Toshi
> >
>
Re: Can we remove OfflineMetaRepair in the master branch and branch-2+?
Posted by Vladimir Rodionov <vl...@gmail.com>.
+1. It has always been obscure tool.
On Wed, Jul 10, 2019 at 8:47 PM Toshihiro Suzuki <br...@apache.org>
wrote:
> Hi folks!
>
> I think we no longer support OfflineMetaRepair in HBase-2.x and it has a
> critical bug that breaks the meta data:
> https://issues.apache.org/jira/browse/HBASE-21665
>
> Actually, I have seen several cases where some users ran OfflineMetaRepair
> mistakenly in their cluster and corrupted their meta data.
>
> Also, new meta rebuilding tool is being developed by Wellington at the
> moment in HBCK2:
> https://issues.apache.org/jira/browse/HBASE-22567
>
> So I think we can remove OfflineMetaRepair in the master branch and
> branch-2+. What do you think?
>
> If no objections, I'll file this in Apache Jira.
>
> Regards,
> Toshi
>