You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/02 19:51:53 UTC
[GitHub] [geode] jhuynh1 opened a new pull request #5200: GEODE-8203: Adding standard-output-always-on
jhuynh1 opened a new pull request #5200:
URL: https://github.com/apache/geode/pull/5200
Added information about a new system property that prevents disabling logging to standard out when a log file is present
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] aaronlindsey commented on a change in pull request #5200: GEODE-8203: Adding standard-output-always-on to docs
Posted by GitBox <gi...@apache.org>.
aaronlindsey commented on a change in pull request #5200:
URL: https://github.com/apache/geode/pull/5200#discussion_r434153488
##########
File path: geode-docs/reference/topics/gemfire_properties.html.md.erb
##########
@@ -756,6 +756,13 @@ When enabled, also sets ssl-endpoint-identification-enabled to true.</td>
<td>JKS</td>
</tr>
+<tr>
+<td>standard-output-always-on</td>
Review comment:
Sorry, I missed #5197. Now it all makes sense!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jhuynh1 merged pull request #5200: GEODE-8203: Adding standard-output-always-on to docs
Posted by GitBox <gi...@apache.org>.
jhuynh1 merged pull request #5200:
URL: https://github.com/apache/geode/pull/5200
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] aaronlindsey commented on a change in pull request #5200: GEODE-8203: Adding standard-output-always-on to docs
Posted by GitBox <gi...@apache.org>.
aaronlindsey commented on a change in pull request #5200:
URL: https://github.com/apache/geode/pull/5200#discussion_r434152288
##########
File path: geode-docs/reference/topics/gemfire_properties.html.md.erb
##########
@@ -756,6 +756,13 @@ When enabled, also sets ssl-endpoint-identification-enabled to true.</td>
<td>JKS</td>
</tr>
+<tr>
+<td>standard-output-always-on</td>
Review comment:
I thought the property was `StandardOutputAlwaysOn` (pascal case) according to #5183 ? Maybe I'm not understanding how it works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org