You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/12 16:35:29 UTC
[GitHub] [doris] Yukang-Lian opened a new pull request, #15885: [fix](datetimev2) Fix BE datetimev2 type returning wrong result
Yukang-Lian opened a new pull request, #15885:
URL: https://github.com/apache/doris/pull/15885
# Proposed changes
Issue Number: close #15813
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15885: [fix](datetimev2) Fix BE datetimev2 type returning wrong result
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15885:
URL: https://github.com/apache/doris/pull/15885#issuecomment-1380920190
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.96 seconds
load time: 492 seconds
storage size: 17123088829 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230112194446_clickbench_pr_79184.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15885: [fix](datetimev2) Fix BE datetimev2 type returning wrong result
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15885:
URL: https://github.com/apache/doris/pull/15885#issuecomment-1380696029
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15885: [fix](datetimev2) Fix BE datetimev2 type returning wrong result
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15885:
URL: https://github.com/apache/doris/pull/15885#issuecomment-1381326786
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15885: [fix](datetimev2) Fix BE datetimev2 type returning wrong result
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15885:
URL: https://github.com/apache/doris/pull/15885#issuecomment-1381348793
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 commented on a diff in pull request #15885: [fix](datetimev2) Fix BE datetimev2 type returning wrong result
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on code in PR #15885:
URL: https://github.com/apache/doris/pull/15885#discussion_r1068872731
##########
be/src/vec/sink/vmysql_result_writer.cpp:
##########
@@ -367,6 +367,14 @@ int VMysqlResultWriter::_add_one_cell(const ColumnPtr& column_ptr, size_t row_id
char buf[64];
char* pos = datev2.to_string(buf);
return buffer.push_string(buf, pos - buf - 1);
+ } else if (which.is_date_time_v2()) {
+ auto& column_vector = assert_cast<const ColumnVector<UInt64>&>(*column);
+ auto value = column_vector[row_idx].get<UInt64>();
+ DateV2Value<DateTimeV2ValueType> datetimev2;
Review Comment:
Use `DateV2Value<DateTimeV2ValueType> datetimev2 = binary_cast<UInt64, DateV2Value<DateTimeV2ValueType>>(value)`.
Could you also change datev2 to this method ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 merged pull request #15885: [fix](datetimev2) Fix BE datetimev2 type returning wrong result
Posted by GitBox <gi...@apache.org>.
Gabriel39 merged PR #15885:
URL: https://github.com/apache/doris/pull/15885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 commented on pull request #15885: [fix](datetimev2) Fix BE datetimev2 type returning wrong result
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on PR #15885:
URL: https://github.com/apache/doris/pull/15885#issuecomment-1381251662
Please add a regression case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Yukang-Lian commented on a diff in pull request #15885: [fix](datetimev2) Fix BE datetimev2 type returning wrong result
Posted by GitBox <gi...@apache.org>.
Yukang-Lian commented on code in PR #15885:
URL: https://github.com/apache/doris/pull/15885#discussion_r1068886241
##########
be/src/vec/sink/vmysql_result_writer.cpp:
##########
@@ -367,6 +367,14 @@ int VMysqlResultWriter::_add_one_cell(const ColumnPtr& column_ptr, size_t row_id
char buf[64];
char* pos = datev2.to_string(buf);
return buffer.push_string(buf, pos - buf - 1);
+ } else if (which.is_date_time_v2()) {
+ auto& column_vector = assert_cast<const ColumnVector<UInt64>&>(*column);
+ auto value = column_vector[row_idx].get<UInt64>();
+ DateV2Value<DateTimeV2ValueType> datetimev2;
Review Comment:
sure, will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15885: [fix](datetimev2) Fix BE datetimev2 type returning wrong result
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15885:
URL: https://github.com/apache/doris/pull/15885#issuecomment-1396845602
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org